diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2009-11-16 06:11:48 -0500 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2009-11-18 11:37:40 -0500 |
commit | 6d4561110a3e9fa742aeec6717248a491dfb1878 (patch) | |
tree | 689e2abf19940416ce597ba56ed31026ff59bd21 /fs/xfs | |
parent | 86926d0096279b9739ceeff40f68d3c33b9119a9 (diff) |
sysctl: Drop & in front of every proc_handler.
For consistency drop & in front of every proc_handler. Explicity
taking the address is unnecessary and it prevents optimizations
like stubbing the proc_handlers to NULL.
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r-- | fs/xfs/linux-2.6/xfs_sysctl.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/fs/xfs/linux-2.6/xfs_sysctl.c b/fs/xfs/linux-2.6/xfs_sysctl.c index 6880147cafa8..7bb5092d6ae4 100644 --- a/fs/xfs/linux-2.6/xfs_sysctl.c +++ b/fs/xfs/linux-2.6/xfs_sysctl.c | |||
@@ -59,7 +59,7 @@ static ctl_table xfs_table[] = { | |||
59 | .data = &xfs_params.sgid_inherit.val, | 59 | .data = &xfs_params.sgid_inherit.val, |
60 | .maxlen = sizeof(int), | 60 | .maxlen = sizeof(int), |
61 | .mode = 0644, | 61 | .mode = 0644, |
62 | .proc_handler = &proc_dointvec_minmax, | 62 | .proc_handler = proc_dointvec_minmax, |
63 | .extra1 = &xfs_params.sgid_inherit.min, | 63 | .extra1 = &xfs_params.sgid_inherit.min, |
64 | .extra2 = &xfs_params.sgid_inherit.max | 64 | .extra2 = &xfs_params.sgid_inherit.max |
65 | }, | 65 | }, |
@@ -68,7 +68,7 @@ static ctl_table xfs_table[] = { | |||
68 | .data = &xfs_params.symlink_mode.val, | 68 | .data = &xfs_params.symlink_mode.val, |
69 | .maxlen = sizeof(int), | 69 | .maxlen = sizeof(int), |
70 | .mode = 0644, | 70 | .mode = 0644, |
71 | .proc_handler = &proc_dointvec_minmax, | 71 | .proc_handler = proc_dointvec_minmax, |
72 | .extra1 = &xfs_params.symlink_mode.min, | 72 | .extra1 = &xfs_params.symlink_mode.min, |
73 | .extra2 = &xfs_params.symlink_mode.max | 73 | .extra2 = &xfs_params.symlink_mode.max |
74 | }, | 74 | }, |
@@ -77,7 +77,7 @@ static ctl_table xfs_table[] = { | |||
77 | .data = &xfs_params.panic_mask.val, | 77 | .data = &xfs_params.panic_mask.val, |
78 | .maxlen = sizeof(int), | 78 | .maxlen = sizeof(int), |
79 | .mode = 0644, | 79 | .mode = 0644, |
80 | .proc_handler = &proc_dointvec_minmax, | 80 | .proc_handler = proc_dointvec_minmax, |
81 | .extra1 = &xfs_params.panic_mask.min, | 81 | .extra1 = &xfs_params.panic_mask.min, |
82 | .extra2 = &xfs_params.panic_mask.max | 82 | .extra2 = &xfs_params.panic_mask.max |
83 | }, | 83 | }, |
@@ -87,7 +87,7 @@ static ctl_table xfs_table[] = { | |||
87 | .data = &xfs_params.error_level.val, | 87 | .data = &xfs_params.error_level.val, |
88 | .maxlen = sizeof(int), | 88 | .maxlen = sizeof(int), |
89 | .mode = 0644, | 89 | .mode = 0644, |
90 | .proc_handler = &proc_dointvec_minmax, | 90 | .proc_handler = proc_dointvec_minmax, |
91 | .extra1 = &xfs_params.error_level.min, | 91 | .extra1 = &xfs_params.error_level.min, |
92 | .extra2 = &xfs_params.error_level.max | 92 | .extra2 = &xfs_params.error_level.max |
93 | }, | 93 | }, |
@@ -96,7 +96,7 @@ static ctl_table xfs_table[] = { | |||
96 | .data = &xfs_params.syncd_timer.val, | 96 | .data = &xfs_params.syncd_timer.val, |
97 | .maxlen = sizeof(int), | 97 | .maxlen = sizeof(int), |
98 | .mode = 0644, | 98 | .mode = 0644, |
99 | .proc_handler = &proc_dointvec_minmax, | 99 | .proc_handler = proc_dointvec_minmax, |
100 | .extra1 = &xfs_params.syncd_timer.min, | 100 | .extra1 = &xfs_params.syncd_timer.min, |
101 | .extra2 = &xfs_params.syncd_timer.max | 101 | .extra2 = &xfs_params.syncd_timer.max |
102 | }, | 102 | }, |
@@ -105,7 +105,7 @@ static ctl_table xfs_table[] = { | |||
105 | .data = &xfs_params.inherit_sync.val, | 105 | .data = &xfs_params.inherit_sync.val, |
106 | .maxlen = sizeof(int), | 106 | .maxlen = sizeof(int), |
107 | .mode = 0644, | 107 | .mode = 0644, |
108 | .proc_handler = &proc_dointvec_minmax, | 108 | .proc_handler = proc_dointvec_minmax, |
109 | .extra1 = &xfs_params.inherit_sync.min, | 109 | .extra1 = &xfs_params.inherit_sync.min, |
110 | .extra2 = &xfs_params.inherit_sync.max | 110 | .extra2 = &xfs_params.inherit_sync.max |
111 | }, | 111 | }, |
@@ -114,7 +114,7 @@ static ctl_table xfs_table[] = { | |||
114 | .data = &xfs_params.inherit_nodump.val, | 114 | .data = &xfs_params.inherit_nodump.val, |
115 | .maxlen = sizeof(int), | 115 | .maxlen = sizeof(int), |
116 | .mode = 0644, | 116 | .mode = 0644, |
117 | .proc_handler = &proc_dointvec_minmax, | 117 | .proc_handler = proc_dointvec_minmax, |
118 | .extra1 = &xfs_params.inherit_nodump.min, | 118 | .extra1 = &xfs_params.inherit_nodump.min, |
119 | .extra2 = &xfs_params.inherit_nodump.max | 119 | .extra2 = &xfs_params.inherit_nodump.max |
120 | }, | 120 | }, |
@@ -123,7 +123,7 @@ static ctl_table xfs_table[] = { | |||
123 | .data = &xfs_params.inherit_noatim.val, | 123 | .data = &xfs_params.inherit_noatim.val, |
124 | .maxlen = sizeof(int), | 124 | .maxlen = sizeof(int), |
125 | .mode = 0644, | 125 | .mode = 0644, |
126 | .proc_handler = &proc_dointvec_minmax, | 126 | .proc_handler = proc_dointvec_minmax, |
127 | .extra1 = &xfs_params.inherit_noatim.min, | 127 | .extra1 = &xfs_params.inherit_noatim.min, |
128 | .extra2 = &xfs_params.inherit_noatim.max | 128 | .extra2 = &xfs_params.inherit_noatim.max |
129 | }, | 129 | }, |
@@ -132,7 +132,7 @@ static ctl_table xfs_table[] = { | |||
132 | .data = &xfs_params.xfs_buf_timer.val, | 132 | .data = &xfs_params.xfs_buf_timer.val, |
133 | .maxlen = sizeof(int), | 133 | .maxlen = sizeof(int), |
134 | .mode = 0644, | 134 | .mode = 0644, |
135 | .proc_handler = &proc_dointvec_minmax, | 135 | .proc_handler = proc_dointvec_minmax, |
136 | .extra1 = &xfs_params.xfs_buf_timer.min, | 136 | .extra1 = &xfs_params.xfs_buf_timer.min, |
137 | .extra2 = &xfs_params.xfs_buf_timer.max | 137 | .extra2 = &xfs_params.xfs_buf_timer.max |
138 | }, | 138 | }, |
@@ -141,7 +141,7 @@ static ctl_table xfs_table[] = { | |||
141 | .data = &xfs_params.xfs_buf_age.val, | 141 | .data = &xfs_params.xfs_buf_age.val, |
142 | .maxlen = sizeof(int), | 142 | .maxlen = sizeof(int), |
143 | .mode = 0644, | 143 | .mode = 0644, |
144 | .proc_handler = &proc_dointvec_minmax, | 144 | .proc_handler = proc_dointvec_minmax, |
145 | .extra1 = &xfs_params.xfs_buf_age.min, | 145 | .extra1 = &xfs_params.xfs_buf_age.min, |
146 | .extra2 = &xfs_params.xfs_buf_age.max | 146 | .extra2 = &xfs_params.xfs_buf_age.max |
147 | }, | 147 | }, |
@@ -150,7 +150,7 @@ static ctl_table xfs_table[] = { | |||
150 | .data = &xfs_params.inherit_nosym.val, | 150 | .data = &xfs_params.inherit_nosym.val, |
151 | .maxlen = sizeof(int), | 151 | .maxlen = sizeof(int), |
152 | .mode = 0644, | 152 | .mode = 0644, |
153 | .proc_handler = &proc_dointvec_minmax, | 153 | .proc_handler = proc_dointvec_minmax, |
154 | .extra1 = &xfs_params.inherit_nosym.min, | 154 | .extra1 = &xfs_params.inherit_nosym.min, |
155 | .extra2 = &xfs_params.inherit_nosym.max | 155 | .extra2 = &xfs_params.inherit_nosym.max |
156 | }, | 156 | }, |
@@ -159,7 +159,7 @@ static ctl_table xfs_table[] = { | |||
159 | .data = &xfs_params.rotorstep.val, | 159 | .data = &xfs_params.rotorstep.val, |
160 | .maxlen = sizeof(int), | 160 | .maxlen = sizeof(int), |
161 | .mode = 0644, | 161 | .mode = 0644, |
162 | .proc_handler = &proc_dointvec_minmax, | 162 | .proc_handler = proc_dointvec_minmax, |
163 | .extra1 = &xfs_params.rotorstep.min, | 163 | .extra1 = &xfs_params.rotorstep.min, |
164 | .extra2 = &xfs_params.rotorstep.max | 164 | .extra2 = &xfs_params.rotorstep.max |
165 | }, | 165 | }, |
@@ -168,7 +168,7 @@ static ctl_table xfs_table[] = { | |||
168 | .data = &xfs_params.inherit_nodfrg.val, | 168 | .data = &xfs_params.inherit_nodfrg.val, |
169 | .maxlen = sizeof(int), | 169 | .maxlen = sizeof(int), |
170 | .mode = 0644, | 170 | .mode = 0644, |
171 | .proc_handler = &proc_dointvec_minmax, | 171 | .proc_handler = proc_dointvec_minmax, |
172 | .extra1 = &xfs_params.inherit_nodfrg.min, | 172 | .extra1 = &xfs_params.inherit_nodfrg.min, |
173 | .extra2 = &xfs_params.inherit_nodfrg.max | 173 | .extra2 = &xfs_params.inherit_nodfrg.max |
174 | }, | 174 | }, |
@@ -177,7 +177,7 @@ static ctl_table xfs_table[] = { | |||
177 | .data = &xfs_params.fstrm_timer.val, | 177 | .data = &xfs_params.fstrm_timer.val, |
178 | .maxlen = sizeof(int), | 178 | .maxlen = sizeof(int), |
179 | .mode = 0644, | 179 | .mode = 0644, |
180 | .proc_handler = &proc_dointvec_minmax, | 180 | .proc_handler = proc_dointvec_minmax, |
181 | .extra1 = &xfs_params.fstrm_timer.min, | 181 | .extra1 = &xfs_params.fstrm_timer.min, |
182 | .extra2 = &xfs_params.fstrm_timer.max, | 182 | .extra2 = &xfs_params.fstrm_timer.max, |
183 | }, | 183 | }, |
@@ -188,7 +188,7 @@ static ctl_table xfs_table[] = { | |||
188 | .data = &xfs_params.stats_clear.val, | 188 | .data = &xfs_params.stats_clear.val, |
189 | .maxlen = sizeof(int), | 189 | .maxlen = sizeof(int), |
190 | .mode = 0644, | 190 | .mode = 0644, |
191 | .proc_handler = &xfs_stats_clear_proc_handler, | 191 | .proc_handler = xfs_stats_clear_proc_handler, |
192 | .extra1 = &xfs_params.stats_clear.min, | 192 | .extra1 = &xfs_params.stats_clear.min, |
193 | .extra2 = &xfs_params.stats_clear.max | 193 | .extra2 = &xfs_params.stats_clear.max |
194 | }, | 194 | }, |