diff options
author | Dave Chinner <dchinner@redhat.com> | 2012-04-29 08:43:19 -0400 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2012-05-14 17:20:39 -0400 |
commit | 3ed9116e8a3e9c0870b2076340b3da9b8f900f3b (patch) | |
tree | 158b4ea878a46464f0f3c3e5f4ca943a6b5c67c5 /fs/xfs | |
parent | 58e20770646932fe9b758c94e8c278ea9ec93878 (diff) |
xfs: limit specualtive delalloc to maxioffset
Speculative delayed allocation beyond EOF near the maximum supported
file offset can result in creating delalloc extents beyond
mp->m_maxioffset (8EB). These can never be trimmed during
xfs_free_eof_blocks() because they are beyond mp->m_maxioffset, and
that results in assert failures in xfs_fs_destroy_inode() due to
delalloc blocks still being present. xfstests 071 exposes this
problem.
Limit speculative delalloc to mp->m_maxioffset to avoid this
problem.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r-- | fs/xfs/xfs_iomap.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c index 47e714a7bf92..7aa0c1de2e05 100644 --- a/fs/xfs/xfs_iomap.c +++ b/fs/xfs/xfs_iomap.c | |||
@@ -415,6 +415,15 @@ retry: | |||
415 | return error; | 415 | return error; |
416 | } | 416 | } |
417 | 417 | ||
418 | /* | ||
419 | * Make sure preallocation does not create extents beyond the range we | ||
420 | * actually support in this filesystem. | ||
421 | */ | ||
422 | if (last_fsb > XFS_B_TO_FSB(mp, mp->m_maxioffset)) | ||
423 | last_fsb = XFS_B_TO_FSB(mp, mp->m_maxioffset); | ||
424 | |||
425 | ASSERT(last_fsb > offset_fsb); | ||
426 | |||
418 | nimaps = XFS_WRITE_IMAPS; | 427 | nimaps = XFS_WRITE_IMAPS; |
419 | error = xfs_bmapi_delay(ip, offset_fsb, last_fsb - offset_fsb, | 428 | error = xfs_bmapi_delay(ip, offset_fsb, last_fsb - offset_fsb, |
420 | imap, &nimaps, XFS_BMAPI_ENTIRE); | 429 | imap, &nimaps, XFS_BMAPI_ENTIRE); |