diff options
author | Jeff Liu <jeff.liu@oracle.com> | 2013-01-28 08:26:16 -0500 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-02-01 15:40:17 -0500 |
commit | b0c10b983a3e5cc35f239999df1b8bad1ba5b8f6 (patch) | |
tree | 78c41025c277a87c1baea6eb2990572fdfb7bb70 /fs/xfs | |
parent | 5b292ae3a951a58e32119d73c7ac8f5bec7395a3 (diff) |
xfs: calculate XFS_TRANS_QM_SBCHANGE space log reservation at mount time
The transaction log space for clearing/reseting the quota flags
is calculated out at runtime, this patch can figure it out at
mount time.
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
CC: Dave Chinner <david@fromorbit.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r-- | fs/xfs/xfs_mount.c | 4 | ||||
-rw-r--r-- | fs/xfs/xfs_mount.h | 1 | ||||
-rw-r--r-- | fs/xfs/xfs_trans.c | 12 | ||||
-rw-r--r-- | fs/xfs/xfs_trans.h | 2 |
4 files changed, 16 insertions, 3 deletions
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 7d6df7c00c36..0db40205778a 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
@@ -1109,8 +1109,8 @@ xfs_mount_reset_sbqflags( | |||
1109 | return 0; | 1109 | return 0; |
1110 | 1110 | ||
1111 | tp = xfs_trans_alloc(mp, XFS_TRANS_QM_SBCHANGE); | 1111 | tp = xfs_trans_alloc(mp, XFS_TRANS_QM_SBCHANGE); |
1112 | error = xfs_trans_reserve(tp, 0, mp->m_sb.sb_sectsize + 128, 0, 0, | 1112 | error = xfs_trans_reserve(tp, 0, XFS_QM_SBCHANGE_LOG_RES(mp), |
1113 | XFS_DEFAULT_LOG_COUNT); | 1113 | 0, 0, XFS_DEFAULT_LOG_COUNT); |
1114 | if (error) { | 1114 | if (error) { |
1115 | xfs_trans_cancel(tp, 0); | 1115 | xfs_trans_cancel(tp, 0); |
1116 | xfs_alert(mp, "%s: Superblock update failed!", __func__); | 1116 | xfs_alert(mp, "%s: Superblock update failed!", __func__); |
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index bab8314507e4..4e9aa9524840 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h | |||
@@ -40,6 +40,7 @@ typedef struct xfs_trans_reservations { | |||
40 | uint tr_growrtalloc; /* grow realtime allocations */ | 40 | uint tr_growrtalloc; /* grow realtime allocations */ |
41 | uint tr_growrtzero; /* grow realtime zeroing */ | 41 | uint tr_growrtzero; /* grow realtime zeroing */ |
42 | uint tr_growrtfree; /* grow realtime freeing */ | 42 | uint tr_growrtfree; /* grow realtime freeing */ |
43 | uint tr_qm_sbchange; /* change quota flags */ | ||
43 | } xfs_trans_reservations_t; | 44 | } xfs_trans_reservations_t; |
44 | 45 | ||
45 | #ifndef __KERNEL__ | 46 | #ifndef __KERNEL__ |
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index a81625c75a91..6ba62c0e24d1 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c | |||
@@ -546,6 +546,17 @@ xfs_calc_clear_agi_bucket_reservation( | |||
546 | } | 546 | } |
547 | 547 | ||
548 | /* | 548 | /* |
549 | * Clearing the quotaflags in the superblock. | ||
550 | * the super block for changing quota flags: sector size | ||
551 | */ | ||
552 | STATIC uint | ||
553 | xfs_calc_qm_sbchange_reservation( | ||
554 | struct xfs_mount *mp) | ||
555 | { | ||
556 | return xfs_calc_buf_res(1, mp->m_sb.sb_sectsize); | ||
557 | } | ||
558 | |||
559 | /* | ||
549 | * Initialize the precomputed transaction reservation values | 560 | * Initialize the precomputed transaction reservation values |
550 | * in the mount structure. | 561 | * in the mount structure. |
551 | */ | 562 | */ |
@@ -576,6 +587,7 @@ xfs_trans_init( | |||
576 | resp->tr_growrtalloc = xfs_calc_growrtalloc_reservation(mp); | 587 | resp->tr_growrtalloc = xfs_calc_growrtalloc_reservation(mp); |
577 | resp->tr_growrtzero = xfs_calc_growrtzero_reservation(mp); | 588 | resp->tr_growrtzero = xfs_calc_growrtzero_reservation(mp); |
578 | resp->tr_growrtfree = xfs_calc_growrtfree_reservation(mp); | 589 | resp->tr_growrtfree = xfs_calc_growrtfree_reservation(mp); |
590 | resp->tr_qm_sbchange = xfs_calc_qm_sbchange_reservation(mp); | ||
579 | } | 591 | } |
580 | 592 | ||
581 | /* | 593 | /* |
diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h index c6c0601abd7a..a690f2803594 100644 --- a/fs/xfs/xfs_trans.h +++ b/fs/xfs/xfs_trans.h | |||
@@ -262,7 +262,7 @@ struct xfs_log_item_desc { | |||
262 | (128 * (ext + (ext * XFS_BM_MAXLEVELS(mp, XFS_ATTR_FORK))))) | 262 | (128 * (ext + (ext * XFS_BM_MAXLEVELS(mp, XFS_ATTR_FORK))))) |
263 | #define XFS_ATTRRM_LOG_RES(mp) ((mp)->m_reservations.tr_attrrm) | 263 | #define XFS_ATTRRM_LOG_RES(mp) ((mp)->m_reservations.tr_attrrm) |
264 | #define XFS_CLEAR_AGI_BUCKET_LOG_RES(mp) ((mp)->m_reservations.tr_clearagi) | 264 | #define XFS_CLEAR_AGI_BUCKET_LOG_RES(mp) ((mp)->m_reservations.tr_clearagi) |
265 | 265 | #define XFS_QM_SBCHANGE_LOG_RES(mp) ((mp)->m_reservations.tr_qm_sbchange) | |
266 | 266 | ||
267 | /* | 267 | /* |
268 | * Various log count values. | 268 | * Various log count values. |