diff options
author | Nathan Scott <nathans@sgi.com> | 2006-01-10 23:32:01 -0500 |
---|---|---|
committer | Nathan Scott <nathans@sgi.com> | 2006-01-10 23:32:01 -0500 |
commit | 13059ff04c5071c3f6f8a4bd9e51631849f63fa4 (patch) | |
tree | 5a038d985cefde848e52c7bc232a71df454f3e0e /fs/xfs/xfs_vfsops.c | |
parent | e13a73f02595c564e423bda5742fb8df4ebca455 (diff) |
[XFS] Reverse the sense of COMPAT_ATTR and ATTR2, keeps it simple and
consistent.
SGI-PV: 941645
SGI-Modid: xfs-linux-melb:xfs-kern:202961a
Signed-off-by: Nathan Scott <nathans@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_vfsops.c')
-rw-r--r-- | fs/xfs/xfs_vfsops.c | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/fs/xfs/xfs_vfsops.c b/fs/xfs/xfs_vfsops.c index dcdb0a8578e1..aef4ec441e0c 100644 --- a/fs/xfs/xfs_vfsops.c +++ b/fs/xfs/xfs_vfsops.c | |||
@@ -291,8 +291,8 @@ xfs_start_flags( | |||
291 | mp->m_flags |= XFS_MOUNT_IDELETE; | 291 | mp->m_flags |= XFS_MOUNT_IDELETE; |
292 | if (ap->flags & XFSMNT_DIRSYNC) | 292 | if (ap->flags & XFSMNT_DIRSYNC) |
293 | mp->m_flags |= XFS_MOUNT_DIRSYNC; | 293 | mp->m_flags |= XFS_MOUNT_DIRSYNC; |
294 | if (ap->flags & XFSMNT_COMPAT_ATTR) | 294 | if (ap->flags & XFSMNT_ATTR2) |
295 | mp->m_flags |= XFS_MOUNT_COMPAT_ATTR; | 295 | mp->m_flags |= XFS_MOUNT_ATTR2; |
296 | 296 | ||
297 | if (ap->flags2 & XFSMNT2_COMPAT_IOSIZE) | 297 | if (ap->flags2 & XFSMNT2_COMPAT_IOSIZE) |
298 | mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE; | 298 | mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE; |
@@ -350,6 +350,10 @@ xfs_finish_flags( | |||
350 | } | 350 | } |
351 | } | 351 | } |
352 | 352 | ||
353 | if (XFS_SB_VERSION_HASATTR2(&mp->m_sb)) { | ||
354 | mp->m_flags |= XFS_MOUNT_ATTR2; | ||
355 | } | ||
356 | |||
353 | /* | 357 | /* |
354 | * prohibit r/w mounts of read-only filesystems | 358 | * prohibit r/w mounts of read-only filesystems |
355 | */ | 359 | */ |
@@ -385,10 +389,6 @@ xfs_finish_flags( | |||
385 | return XFS_ERROR(EINVAL); | 389 | return XFS_ERROR(EINVAL); |
386 | } | 390 | } |
387 | 391 | ||
388 | if (XFS_SB_VERSION_HASATTR2(&mp->m_sb)) { | ||
389 | mp->m_flags &= ~XFS_MOUNT_COMPAT_ATTR; | ||
390 | } | ||
391 | |||
392 | return 0; | 392 | return 0; |
393 | } | 393 | } |
394 | 394 | ||
@@ -1690,7 +1690,6 @@ xfs_parseargs( | |||
1690 | int iosize; | 1690 | int iosize; |
1691 | 1691 | ||
1692 | args->flags2 |= XFSMNT2_COMPAT_IOSIZE; | 1692 | args->flags2 |= XFSMNT2_COMPAT_IOSIZE; |
1693 | args->flags |= XFSMNT_COMPAT_ATTR; | ||
1694 | args->flags |= XFSMNT_BARRIER; | 1693 | args->flags |= XFSMNT_BARRIER; |
1695 | 1694 | ||
1696 | #if 0 /* XXX: off by default, until some remaining issues ironed out */ | 1695 | #if 0 /* XXX: off by default, until some remaining issues ironed out */ |
@@ -1828,9 +1827,9 @@ xfs_parseargs( | |||
1828 | } else if (!strcmp(this_char, MNTOPT_NOLARGEIO)) { | 1827 | } else if (!strcmp(this_char, MNTOPT_NOLARGEIO)) { |
1829 | args->flags2 |= XFSMNT2_COMPAT_IOSIZE; | 1828 | args->flags2 |= XFSMNT2_COMPAT_IOSIZE; |
1830 | } else if (!strcmp(this_char, MNTOPT_ATTR2)) { | 1829 | } else if (!strcmp(this_char, MNTOPT_ATTR2)) { |
1831 | args->flags &= ~XFSMNT_COMPAT_ATTR; | 1830 | args->flags |= XFSMNT_ATTR2; |
1832 | } else if (!strcmp(this_char, MNTOPT_NOATTR2)) { | 1831 | } else if (!strcmp(this_char, MNTOPT_NOATTR2)) { |
1833 | args->flags |= XFSMNT_COMPAT_ATTR; | 1832 | args->flags &= ~XFSMNT_ATTR2; |
1834 | } else if (!strcmp(this_char, "osyncisdsync")) { | 1833 | } else if (!strcmp(this_char, "osyncisdsync")) { |
1835 | /* no-op, this is now the default */ | 1834 | /* no-op, this is now the default */ |
1836 | printk("XFS: osyncisdsync is now the default, option is deprecated.\n"); | 1835 | printk("XFS: osyncisdsync is now the default, option is deprecated.\n"); |
@@ -1941,8 +1940,6 @@ xfs_showargs( | |||
1941 | seq_printf(m, "," MNTOPT_SWIDTH "=%d", | 1940 | seq_printf(m, "," MNTOPT_SWIDTH "=%d", |
1942 | (int)XFS_FSB_TO_BB(mp, mp->m_swidth)); | 1941 | (int)XFS_FSB_TO_BB(mp, mp->m_swidth)); |
1943 | 1942 | ||
1944 | if (!(mp->m_flags & XFS_MOUNT_COMPAT_ATTR)) | ||
1945 | seq_printf(m, "," MNTOPT_ATTR2); | ||
1946 | if (!(mp->m_flags & XFS_MOUNT_COMPAT_IOSIZE)) | 1943 | if (!(mp->m_flags & XFS_MOUNT_COMPAT_IOSIZE)) |
1947 | seq_printf(m, "," MNTOPT_LARGEIO); | 1944 | seq_printf(m, "," MNTOPT_LARGEIO); |
1948 | if (!(mp->m_flags & XFS_MOUNT_BARRIER)) | 1945 | if (!(mp->m_flags & XFS_MOUNT_BARRIER)) |