xfs: clean up xfs_ioerror_alert

Instead of passing the block number and mount structure explicitly
get them off the bp and fix make the argument order more natural.

Also move it to xfs_buf.c and stop printing the device name given
that we already get the fs name as part of xfs_alert, and we know
what device is operates on because of the caller that gets printed,
finally rename it to xfs_buf_ioerror_alert and pass __func__ as
argument where it makes sense.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>

1 files changed, 3 insertions, 6 deletions

diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c
index 5bab5980a6f9..475a4ded4f41 100644
--- a/fs/xfs/xfs_trans_buf.c
+++ b/fs/xfs/xfs_trans_buf.c
@@ -296,8 +296,7 @@ xfs_trans_read_buf(
 
                 if (bp->b_error) {
                         error = bp->b_error;
-                        xfs_ioerror_alert("xfs_trans_read_buf", mp,
-                                          bp, blkno);
+                        xfs_buf_ioerror_alert(bp, __func__);
                         xfs_buf_relse(bp);
                         return error;
                 }
@@ -339,8 +338,7 @@ xfs_trans_read_buf(
                         xfsbdstrat(tp->t_mountp, bp);
                         error = xfs_buf_iowait(bp);
                         if (error) {
-                                xfs_ioerror_alert("xfs_trans_read_buf", mp,
-                                                  bp, blkno);
+                                xfs_buf_ioerror_alert(bp, __func__);
                                 xfs_buf_relse(bp);
                                 /*
                                  * We can gracefully recover from most read
@@ -391,8 +389,7 @@ xfs_trans_read_buf(
                 error = bp->b_error;
                 xfs_buf_stale(bp);
                 XFS_BUF_DONE(bp);
-                xfs_ioerror_alert("xfs_trans_read_buf", mp,
-                                  bp, blkno);
+                xfs_buf_ioerror_alert(bp, __func__);
                 if (tp->t_flags & XFS_TRANS_DIRTY)
                         xfs_force_shutdown(tp->t_mountp, SHUTDOWN_META_IO_ERROR);
                 xfs_buf_relse(bp);