[XFS] Propagate errors from xfs_trans_commit().

xfs_trans_commit() can return errors when there are problems in the
transaction subsystem. They are indicative that the entire transaction may
be incomplete, and hence the error should be propagated as there is a good
possibility that there is something fatally wrong in the filesystem. Catch
and propagate or warn about commit errors in the places where they are
currently ignored.

SGI-PV: 980084
SGI-Modid: xfs-linux-melb:xfs-kern:30795a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

1 files changed, 23 insertions, 15 deletions

diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index 9cd6471cd60f..a0dc6e5bc5b9 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -124,14 +124,14 @@ xfs_growfs_rt_alloc(
                                 XFS_GROWRTALLOC_LOG_RES(mp), 0,
                                 XFS_TRANS_PERM_LOG_RES,
                                 XFS_DEFAULT_PERM_LOG_COUNT)))
-                        goto error_exit;
+                        goto error_cancel;
                 cancelflags = XFS_TRANS_RELEASE_LOG_RES;
                 /*
                  * Lock the inode.
                  */
                 if ((error = xfs_trans_iget(mp, tp, ino, 0,
                                                 XFS_ILOCK_EXCL, &ip)))
-                        goto error_exit;
+                        goto error_cancel;
                 XFS_BMAP_INIT(&flist, &firstblock);
                 /*
                  * Allocate blocks to the bitmap file.
@@ -144,14 +144,16 @@ xfs_growfs_rt_alloc(
                 if (!error && nmap < 1)
                         error = XFS_ERROR(ENOSPC);
                 if (error)
-                        goto error_exit;
+                        goto error_cancel;
                 /*
                  * Free any blocks freed up in the transaction, then commit.
                  */
                 error = xfs_bmap_finish(&tp, &flist, &committed);
                 if (error)
-                        goto error_exit;
-                xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES);
+                        goto error_cancel;
+                error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES);
+                if (error)
+                        goto error;
                 /*
                  * Now we need to clear the allocated blocks.
                  * Do this one block per transaction, to keep it simple.
@@ -166,13 +168,13 @@ xfs_growfs_rt_alloc(
                          */
                         if ((error = xfs_trans_reserve(tp, 0,
                                         XFS_GROWRTZERO_LOG_RES(mp), 0, 0, 0)))
-                                goto error_exit;
+                                goto error_cancel;
                         /*
                          * Lock the bitmap inode.
                          */
                         if ((error = xfs_trans_iget(mp, tp, ino, 0,
                                                         XFS_ILOCK_EXCL, &ip)))
-                                goto error_exit;
+                                goto error_cancel;
                         /*
                          * Get a buffer for the block.
                          */
@@ -181,14 +183,16 @@ xfs_growfs_rt_alloc(
                                 mp->m_bsize, 0);
                         if (bp == NULL) {
                                 error = XFS_ERROR(EIO);
-                                goto error_exit;
+                                goto error_cancel;
                         }
                         memset(XFS_BUF_PTR(bp), 0, mp->m_sb.sb_blocksize);
                         xfs_trans_log_buf(tp, bp, 0, mp->m_sb.sb_blocksize - 1);
                         /*
                          * Commit the transaction.
                          */
-                        xfs_trans_commit(tp, 0);
+                        error = xfs_trans_commit(tp, 0);
+                        if (error)
+                                goto error;
                 }
                 /*
                  * Go on to the next extent, if any.
@@ -196,8 +200,9 @@ xfs_growfs_rt_alloc(
                 oblocks = map.br_startoff + map.br_blockcount;
         }
         return 0;
-error_exit:
+error_cancel:
         xfs_trans_cancel(tp, cancelflags);
+error:
         return error;
 }
 
@@ -1876,6 +1881,7 @@ xfs_growfs_rt(
         xfs_trans_t     *tp;            /* transaction pointer */
 
         sbp = &mp->m_sb;
+        cancelflags = 0;
         /*
          * Initial error checking.
          */
@@ -2042,13 +2048,15 @@ xfs_growfs_rt(
                  */
                 mp->m_rsumlevels = nrsumlevels;
                 mp->m_rsumsize = nrsumsize;
-                /*
-                 * Commit the transaction.
-                 */
-                xfs_trans_commit(tp, 0);
+
+                error = xfs_trans_commit(tp, 0);
+                if (error) {
+                        tp = NULL;
+                        break;
+                }
         }
 
-        if (error)
+        if (error && tp)
                 xfs_trans_cancel(tp, cancelflags);
 
         /*