diff options
author | Christoph Hellwig <hch@infradead.org> | 2008-03-27 03:01:08 -0400 |
---|---|---|
committer | Lachlan McIlroy <lachlan@redback.melbourne.sgi.com> | 2008-04-17 21:49:08 -0400 |
commit | 433550990e6c2e94995239bac6a52b4df454cae0 (patch) | |
tree | 4536c63306b8e6656b969dc71b099e1b2c149454 /fs/xfs/xfs_mount.c | |
parent | df26cfe849d8fd767b26fcd4bfebfff67bda9f3a (diff) |
[XFS] remove most calls to VN_RELE
Most VN_RELE calls either directly contain a XFS_ITOV or have the
corresponding xfs_inode already in scope. Use the IRELE helper instead of
VN_RELE to clarify the code. With a little more work we can kill VN_RELE
altogether and define IRELE in terms of iput directly.
SGI-PV: 976035
SGI-Modid: xfs-linux-melb:xfs-kern:30710a
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_mount.c')
-rw-r--r-- | fs/xfs/xfs_mount.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 41b690e6896c..c2aafeb8c6cb 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
@@ -43,6 +43,7 @@ | |||
43 | #include "xfs_rw.h" | 43 | #include "xfs_rw.h" |
44 | #include "xfs_quota.h" | 44 | #include "xfs_quota.h" |
45 | #include "xfs_fsops.h" | 45 | #include "xfs_fsops.h" |
46 | #include "xfs_utils.h" | ||
46 | 47 | ||
47 | STATIC void xfs_mount_log_sb(xfs_mount_t *, __int64_t); | 48 | STATIC void xfs_mount_log_sb(xfs_mount_t *, __int64_t); |
48 | STATIC int xfs_uuid_mount(xfs_mount_t *); | 49 | STATIC int xfs_uuid_mount(xfs_mount_t *); |
@@ -956,7 +957,6 @@ xfs_mountfs( | |||
956 | { | 957 | { |
957 | xfs_sb_t *sbp = &(mp->m_sb); | 958 | xfs_sb_t *sbp = &(mp->m_sb); |
958 | xfs_inode_t *rip; | 959 | xfs_inode_t *rip; |
959 | bhv_vnode_t *rvp = NULL; | ||
960 | __uint64_t resblks; | 960 | __uint64_t resblks; |
961 | __int64_t update_flags = 0LL; | 961 | __int64_t update_flags = 0LL; |
962 | uint quotamount, quotaflags; | 962 | uint quotamount, quotaflags; |
@@ -1158,7 +1158,6 @@ xfs_mountfs( | |||
1158 | } | 1158 | } |
1159 | 1159 | ||
1160 | ASSERT(rip != NULL); | 1160 | ASSERT(rip != NULL); |
1161 | rvp = XFS_ITOV(rip); | ||
1162 | 1161 | ||
1163 | if (unlikely((rip->i_d.di_mode & S_IFMT) != S_IFDIR)) { | 1162 | if (unlikely((rip->i_d.di_mode & S_IFMT) != S_IFDIR)) { |
1164 | cmn_err(CE_WARN, "XFS: corrupted root inode"); | 1163 | cmn_err(CE_WARN, "XFS: corrupted root inode"); |
@@ -1241,7 +1240,7 @@ xfs_mountfs( | |||
1241 | /* | 1240 | /* |
1242 | * Free up the root inode. | 1241 | * Free up the root inode. |
1243 | */ | 1242 | */ |
1244 | VN_RELE(rvp); | 1243 | IRELE(rip); |
1245 | error3: | 1244 | error3: |
1246 | xfs_log_unmount_dealloc(mp); | 1245 | xfs_log_unmount_dealloc(mp); |
1247 | error2: | 1246 | error2: |