xfs: global error sign conversion

Convert all the errors the core XFs code to negative error signs
like the rest of the kernel and remove all the sign conversion we
do in the interface layers.

Errors for conversion (and comparison) found via searches like:

$ git grep " E" fs/xfs
$ git grep "return E" fs/xfs
$ git grep " E[A-Z].*;$" fs/xfs

Negation points found via searches like:

$ git grep "= -[a-z,A-Z]" fs/xfs
$ git grep "return -[a-z,A-D,F-Z]" fs/xfs
$ git grep " -[a-z].*;" fs/xfs

[ with some bits I missed from Brian Foster ]

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

1 files changed, 35 insertions, 35 deletions

diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index b50ec92f9620..d5c44a6bdb5b 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -76,7 +76,7 @@ xfs_uuid_mount(
 
         if (uuid_is_nil(uuid)) {
                 xfs_warn(mp, "Filesystem has nil UUID - can't mount");
-                return EINVAL;
+                return -EINVAL;
         }
 
         mutex_lock(&xfs_uuid_table_mutex);
@@ -104,7 +104,7 @@ xfs_uuid_mount(
  out_duplicate:
         mutex_unlock(&xfs_uuid_table_mutex);
         xfs_warn(mp, "Filesystem has duplicate UUID %pU - can't mount", uuid);
-        return EINVAL;
+        return -EINVAL;
 }
 
 STATIC void
@@ -175,10 +175,10 @@ xfs_sb_validate_fsb_count(
 
 #if XFS_BIG_BLKNOS     /* Limited by ULONG_MAX of page cache index */
         if (nblocks >> (PAGE_CACHE_SHIFT - sbp->sb_blocklog) > ULONG_MAX)
-                return EFBIG;
+                return -EFBIG;
 #else                  /* Limited by UINT_MAX of sectors */
         if (nblocks << (sbp->sb_blocklog - BBSHIFT) > UINT_MAX)
-                return EFBIG;
+                return -EFBIG;
 #endif
         return 0;
 }
@@ -308,15 +308,15 @@ reread:
         if (!bp) {
                 if (loud)
                         xfs_warn(mp, "SB buffer read failed");
-                return EIO;
+                return -EIO;
         }
         if (bp->b_error) {
                 error = bp->b_error;
                 if (loud)
                         xfs_warn(mp, "SB validate failed with error %d.", error);
                 /* bad CRC means corrupted metadata */
-                if (error == EFSBADCRC)
-                        error = EFSCORRUPTED;
+                if (error == -EFSBADCRC)
+                        error = -EFSCORRUPTED;
                 goto release_buf;
         }
 
@@ -333,7 +333,7 @@ reread:
         if (sbp->sb_magicnum != XFS_SB_MAGIC) {
                 if (loud)
                         xfs_warn(mp, "Invalid superblock magic number");
-                error = EINVAL;
+                error = -EINVAL;
                 goto release_buf;
         }
 
@@ -344,7 +344,7 @@ reread:
                 if (loud)
                         xfs_warn(mp, "device supports %u byte sectors (not %u)",
                                 sector_size, sbp->sb_sectsize);
-                error = ENOSYS;
+                error = -ENOSYS;
                 goto release_buf;
         }
 
@@ -392,7 +392,7 @@ xfs_update_alignment(xfs_mount_t *mp)
                         xfs_warn(mp,
                 "alignment check failed: sunit/swidth vs. blocksize(%d)",
                                 sbp->sb_blocksize);
-                        return EINVAL;
+                        return -EINVAL;
                 } else {
                         /*
                          * Convert the stripe unit and width to FSBs.
@@ -402,14 +402,14 @@ xfs_update_alignment(xfs_mount_t *mp)
                                 xfs_warn(mp,
                         "alignment check failed: sunit/swidth vs. agsize(%d)",
                                          sbp->sb_agblocks);
-                                return EINVAL;
+                                return -EINVAL;
                         } else if (mp->m_dalign) {
                                 mp->m_swidth = XFS_BB_TO_FSBT(mp, mp->m_swidth);
                         } else {
                                 xfs_warn(mp,
                         "alignment check failed: sunit(%d) less than bsize(%d)",
                                          mp->m_dalign, sbp->sb_blocksize);
-                                return EINVAL;
+                                return -EINVAL;
                         }
                 }
 
@@ -429,7 +429,7 @@ xfs_update_alignment(xfs_mount_t *mp)
                 } else {
                         xfs_warn(mp,
         "cannot change alignment: superblock does not support data alignment");
-                        return EINVAL;
+                        return -EINVAL;
                 }
         } else if ((mp->m_flags & XFS_MOUNT_NOALIGN) != XFS_MOUNT_NOALIGN &&
                     xfs_sb_version_hasdalign(&mp->m_sb)) {
@@ -556,14 +556,14 @@ xfs_check_sizes(xfs_mount_t *mp)
         d = (xfs_daddr_t)XFS_FSB_TO_BB(mp, mp->m_sb.sb_dblocks);
         if (XFS_BB_TO_FSB(mp, d) != mp->m_sb.sb_dblocks) {
                 xfs_warn(mp, "filesystem size mismatch detected");
-                return EFBIG;
+                return -EFBIG;
         }
         bp = xfs_buf_read_uncached(mp->m_ddev_targp,
                                         d - XFS_FSS_TO_BB(mp, 1),
                                         XFS_FSS_TO_BB(mp, 1), 0, NULL);
         if (!bp) {
                 xfs_warn(mp, "last sector read failed");
-                return EIO;
+                return -EIO;
         }
         xfs_buf_relse(bp);
 
@@ -571,14 +571,14 @@ xfs_check_sizes(xfs_mount_t *mp)
                 d = (xfs_daddr_t)XFS_FSB_TO_BB(mp, mp->m_sb.sb_logblocks);
                 if (XFS_BB_TO_FSB(mp, d) != mp->m_sb.sb_logblocks) {
                         xfs_warn(mp, "log size mismatch detected");
-                        return EFBIG;
+                        return -EFBIG;
                 }
                 bp = xfs_buf_read_uncached(mp->m_logdev_targp,
                                         d - XFS_FSB_TO_BB(mp, 1),
                                         XFS_FSB_TO_BB(mp, 1), 0, NULL);
                 if (!bp) {
                         xfs_warn(mp, "log device read failed");
-                        return EIO;
+                        return -EIO;
                 }
                 xfs_buf_relse(bp);
         }
@@ -816,7 +816,7 @@ xfs_mountfs(
         if (!sbp->sb_logblocks) {
                 xfs_warn(mp, "no log defined");
                 XFS_ERROR_REPORT("xfs_mountfs", XFS_ERRLEVEL_LOW, mp);
-                error = EFSCORRUPTED;
+                error = -EFSCORRUPTED;
                 goto out_free_perag;
         }
 
@@ -876,7 +876,7 @@ xfs_mountfs(
                 xfs_iunlock(rip, XFS_ILOCK_EXCL);
                 XFS_ERROR_REPORT("xfs_mountfs_int(2)", XFS_ERRLEVEL_LOW,
                                  mp);
-                error = EFSCORRUPTED;
+                error = -EFSCORRUPTED;
                 goto out_rele_rip;
         }
         mp->m_rootip = rip;     /* save it */
@@ -1152,7 +1152,7 @@ xfs_mod_incore_sb_unlocked(
                 lcounter += delta;
                 if (lcounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_icount = lcounter;
                 return 0;
@@ -1161,7 +1161,7 @@ xfs_mod_incore_sb_unlocked(
                 lcounter += delta;
                 if (lcounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_ifree = lcounter;
                 return 0;
@@ -1191,7 +1191,7 @@ xfs_mod_incore_sb_unlocked(
                          * blocks if were allowed to.
                          */
                         if (!rsvd)
-                                return ENOSPC;
+                                return -ENOSPC;
 
                         lcounter = (long long)mp->m_resblks_avail + delta;
                         if (lcounter >= 0) {
@@ -1202,7 +1202,7 @@ xfs_mod_incore_sb_unlocked(
                                 "Filesystem \"%s\": reserve blocks depleted! "
                                 "Consider increasing reserve pool size.",
                                 mp->m_fsname);
-                        return ENOSPC;
+                        return -ENOSPC;
                 }
 
                 mp->m_sb.sb_fdblocks = lcounter + XFS_ALLOC_SET_ASIDE(mp);
@@ -1211,7 +1211,7 @@ xfs_mod_incore_sb_unlocked(
                 lcounter = (long long)mp->m_sb.sb_frextents;
                 lcounter += delta;
                 if (lcounter < 0) {
-                        return ENOSPC;
+                        return -ENOSPC;
                 }
                 mp->m_sb.sb_frextents = lcounter;
                 return 0;
@@ -1220,7 +1220,7 @@ xfs_mod_incore_sb_unlocked(
                 lcounter += delta;
                 if (lcounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_dblocks = lcounter;
                 return 0;
@@ -1229,7 +1229,7 @@ xfs_mod_incore_sb_unlocked(
                 scounter += delta;
                 if (scounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_agcount = scounter;
                 return 0;
@@ -1238,7 +1238,7 @@ xfs_mod_incore_sb_unlocked(
                 scounter += delta;
                 if (scounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_imax_pct = scounter;
                 return 0;
@@ -1247,7 +1247,7 @@ xfs_mod_incore_sb_unlocked(
                 scounter += delta;
                 if (scounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_rextsize = scounter;
                 return 0;
@@ -1256,7 +1256,7 @@ xfs_mod_incore_sb_unlocked(
                 scounter += delta;
                 if (scounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_rbmblocks = scounter;
                 return 0;
@@ -1265,7 +1265,7 @@ xfs_mod_incore_sb_unlocked(
                 lcounter += delta;
                 if (lcounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_rblocks = lcounter;
                 return 0;
@@ -1274,7 +1274,7 @@ xfs_mod_incore_sb_unlocked(
                 lcounter += delta;
                 if (lcounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_rextents = lcounter;
                 return 0;
@@ -1283,13 +1283,13 @@ xfs_mod_incore_sb_unlocked(
                 scounter += delta;
                 if (scounter < 0) {
                         ASSERT(0);
-                        return EINVAL;
+                        return -EINVAL;
                 }
                 mp->m_sb.sb_rextslog = scounter;
                 return 0;
         default:
                 ASSERT(0);
-                return EINVAL;
+                return -EINVAL;
         }
 }
 
@@ -1452,7 +1452,7 @@ xfs_dev_is_read_only(
             (mp->m_rtdev_targp && xfs_readonly_buftarg(mp->m_rtdev_targp))) {
                 xfs_notice(mp, "%s required on read-only device.", message);
                 xfs_notice(mp, "write access unavailable, cannot proceed.");
-                return EROFS;
+                return -EROFS;
         }
         return 0;
 }
@@ -1995,7 +1995,7 @@ slow_path:
          * (e.g. lots of space just got freed). After that
          * we are done.
          */
-        if (ret != ENOSPC)
+        if (ret != -ENOSPC)
                 xfs_icsb_balance_counter(mp, field, 0);
         xfs_icsb_unlock(mp);
         return ret;