diff options
| author | David Chinner <dgc@sgi.com> | 2008-04-09 22:22:17 -0400 |
|---|---|---|
| committer | Lachlan McIlroy <lachlan@redback.melbourne.sgi.com> | 2008-04-17 22:00:24 -0400 |
| commit | d64e31a2f53cdcb2f95b782196faacb0995ca0c0 (patch) | |
| tree | d13230aeeb739f263305c686168823e161bdf619 /fs/xfs/xfs_mount.c | |
| parent | 556b8b166c9514b5f940047a41dad8fe8cd9a778 (diff) | |
[XFS] Ensure errors from xfs_bdstrat() are correctly checked.
xfsbdstrat() is declared to return an error. That is never checked because
the error is propagated by the xfs_buf_t that is passed through the
function.
Mark xfsbdstrat() as returning void and comment the prototype on the
methods needed for error checking.
SGI-PV: 980084
SGI-Modid: xfs-linux-melb:xfs-kern:30823a
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_mount.c')
| -rw-r--r-- | fs/xfs/xfs_mount.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index 2d03fe194c2c..2fec452afbcc 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
| @@ -1470,7 +1470,6 @@ xfs_unmountfs_writesb(xfs_mount_t *mp) | |||
| 1470 | XFS_BUF_UNASYNC(sbp); | 1470 | XFS_BUF_UNASYNC(sbp); |
| 1471 | ASSERT(XFS_BUF_TARGET(sbp) == mp->m_ddev_targp); | 1471 | ASSERT(XFS_BUF_TARGET(sbp) == mp->m_ddev_targp); |
| 1472 | xfsbdstrat(mp, sbp); | 1472 | xfsbdstrat(mp, sbp); |
| 1473 | /* Nevermind errors we might get here. */ | ||
| 1474 | error = xfs_iowait(sbp); | 1473 | error = xfs_iowait(sbp); |
| 1475 | if (error) | 1474 | if (error) |
| 1476 | xfs_ioerror_alert("xfs_unmountfs_writesb", | 1475 | xfs_ioerror_alert("xfs_unmountfs_writesb", |