diff options
author | David Sterba <dsterba@suse.cz> | 2011-04-13 18:03:28 -0400 |
---|---|---|
committer | Alex Elder <aelder@sgi.com> | 2011-04-28 14:25:29 -0400 |
commit | 45c51b99943c4c74165b19dc2f96e8ba93bdecb9 (patch) | |
tree | 4f0beaf22aaa7e931540f3a40a722ab4cfaefafe /fs/xfs/xfs_mount.c | |
parent | 8a072a4d4c6a5b6ec32836c467d2996393c76c6f (diff) |
xfs: cleanup duplicate initializations
follow these guidelines:
- leave initialization in the declaration block if it fits the line
- move to the code where it's more suitable ('for' init block)
The last chunk was modified from David's original to be a correct
fix for what appeared to be a duplicate initialization.
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'fs/xfs/xfs_mount.c')
-rw-r--r-- | fs/xfs/xfs_mount.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c index bb3f9a7b24ed..b49b82363d20 100644 --- a/fs/xfs/xfs_mount.c +++ b/fs/xfs/xfs_mount.c | |||
@@ -1900,7 +1900,7 @@ xfs_mod_incore_sb_batch( | |||
1900 | uint nmsb, | 1900 | uint nmsb, |
1901 | int rsvd) | 1901 | int rsvd) |
1902 | { | 1902 | { |
1903 | xfs_mod_sb_t *msbp = &msb[0]; | 1903 | xfs_mod_sb_t *msbp; |
1904 | int error = 0; | 1904 | int error = 0; |
1905 | 1905 | ||
1906 | /* | 1906 | /* |
@@ -1910,7 +1910,7 @@ xfs_mod_incore_sb_batch( | |||
1910 | * changes will be atomic. | 1910 | * changes will be atomic. |
1911 | */ | 1911 | */ |
1912 | spin_lock(&mp->m_sb_lock); | 1912 | spin_lock(&mp->m_sb_lock); |
1913 | for (msbp = &msbp[0]; msbp < (msb + nmsb); msbp++) { | 1913 | for (msbp = msb; msbp < (msb + nmsb); msbp++) { |
1914 | ASSERT(msbp->msb_field < XFS_SBS_ICOUNT || | 1914 | ASSERT(msbp->msb_field < XFS_SBS_ICOUNT || |
1915 | msbp->msb_field > XFS_SBS_FDBLOCKS); | 1915 | msbp->msb_field > XFS_SBS_FDBLOCKS); |
1916 | 1916 | ||