xfs: introduce xfs_buf_submit[_wait]

There is a lot of cookie-cutter code that looks like:

	if (shutdown)
		handle buffer error
	xfs_buf_iorequest(bp)
	error = xfs_buf_iowait(bp)
	if (error)
		handle buffer error

spread through XFS. There's significant complexity now in
xfs_buf_iorequest() to specifically handle this sort of synchronous
IO pattern, but there's all sorts of nasty surprises in different
error handling code dependent on who owns the buffer references and
the locks.

Pull this pattern into a single helper, where we can hide all the
synchronous IO warts and hence make the error handling for all the
callers much saner. This removes the need for a special extra
reference to protect IO completion processing, as we can now hold a
single reference across dispatch and waiting, simplifying the sync
IO smeantics and error handling.

In doing this, also rename xfs_buf_iorequest to xfs_buf_submit and
make it explicitly handle on asynchronous IO. This forces all users
to be switched specifically to one interface or the other and
removes any ambiguity between how the interfaces are to be used. It
also means that xfs_buf_iowait() goes away.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

1 files changed, 12 insertions, 18 deletions

diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index 4ba19bf7da1f..980e2968b907 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -193,12 +193,8 @@ xlog_bread_noalign(
         bp->b_io_length = nbblks;
         bp->b_error = 0;
 
-        if (XFS_FORCED_SHUTDOWN(log->l_mp))
-                return -EIO;
-
-        xfs_buf_iorequest(bp);
-        error = xfs_buf_iowait(bp);
-        if (error)
+        error = xfs_buf_submit_wait(bp);
+        if (error && !XFS_FORCED_SHUTDOWN(log->l_mp))
                 xfs_buf_ioerror_alert(bp, __func__);
         return error;
 }
@@ -378,9 +374,11 @@ xlog_recover_iodone(
                  * We're not going to bother about retrying
                  * this during recovery. One strike!
                  */
-                xfs_buf_ioerror_alert(bp, __func__);
-                xfs_force_shutdown(bp->b_target->bt_mount,
-                                        SHUTDOWN_META_IO_ERROR);
+                if (!XFS_FORCED_SHUTDOWN(bp->b_target->bt_mount)) {
+                        xfs_buf_ioerror_alert(bp, __func__);
+                        xfs_force_shutdown(bp->b_target->bt_mount,
+                                                SHUTDOWN_META_IO_ERROR);
+                }
         }
         bp->b_iodone = NULL;
         xfs_buf_ioend(bp);
@@ -4427,16 +4425,12 @@ xlog_do_recover(
         XFS_BUF_UNASYNC(bp);
         bp->b_ops = &xfs_sb_buf_ops;
 
-        if (XFS_FORCED_SHUTDOWN(log->l_mp)) {
-                xfs_buf_relse(bp);
-                return -EIO;
-        }
-
-        xfs_buf_iorequest(bp);
-        error = xfs_buf_iowait(bp);
+        error = xfs_buf_submit_wait(bp);
         if (error) {
-                xfs_buf_ioerror_alert(bp, __func__);
-                ASSERT(0);
+                if (!XFS_FORCED_SHUTDOWN(log->l_mp)) {
+                        xfs_buf_ioerror_alert(bp, __func__);
+                        ASSERT(0);
+                }
                 xfs_buf_relse(bp);
                 return error;
         }