[XFS] dinode endianess annotations

Biggest bit is duplicating the dinode structure so we have one annotated for
native endianess and one for disk endianess. The other significant change
is that xfs_xlate_dinode_core is split into one helper per direction to
allow for proper annotations, everything else is trivial.

As a sidenode splitting out the incore dinode means we can move it into
xfs_inode.h in a later patch and severely improving on the include hell in
xfs.

SGI-PV: 968563
SGI-Modid: xfs-linux-melb:xfs-kern:29476a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Tim Shimmin <tes@sgi.com>

1 files changed, 11 insertions, 14 deletions

diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index 8ae6e8e5f3db..758543443b66 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -2245,7 +2245,7 @@ xlog_recover_do_inode_trans(
         int                     error;
         int                     attr_index;
         uint                    fields;
-        xfs_dinode_core_t       *dicp;
+        xfs_icdinode_t          *dicp;
         int                     need_free = 0;
 
         if (pass == XLOG_RECOVER_PASS1) {
@@ -2309,7 +2309,7 @@ xlog_recover_do_inode_trans(
          * Make sure the place we're flushing out to really looks
          * like an inode!
          */
-        if (unlikely(INT_GET(dip->di_core.di_magic, ARCH_CONVERT) != XFS_DINODE_MAGIC)) {
+        if (unlikely(be16_to_cpu(dip->di_core.di_magic) != XFS_DINODE_MAGIC)) {
                 xfs_buf_relse(bp);
                 xfs_fs_cmn_err(CE_ALERT, mp,
                         "xfs_inode_recover: Bad inode magic number, dino ptr = 0x%p, dino bp = 0x%p, ino = %Ld",
@@ -2319,7 +2319,7 @@ xlog_recover_do_inode_trans(
                 error = EFSCORRUPTED;
                 goto error;
         }
-        dicp = (xfs_dinode_core_t*)(item->ri_buf[1].i_addr);
+        dicp = (xfs_icdinode_t *)(item->ri_buf[1].i_addr);
         if (unlikely(dicp->di_magic != XFS_DINODE_MAGIC)) {
                 xfs_buf_relse(bp);
                 xfs_fs_cmn_err(CE_ALERT, mp,
@@ -2332,15 +2332,13 @@ xlog_recover_do_inode_trans(
         }
 
         /* Skip replay when the on disk inode is newer than the log one */
-        if (dicp->di_flushiter <
-            INT_GET(dip->di_core.di_flushiter, ARCH_CONVERT)) {
+        if (dicp->di_flushiter < be16_to_cpu(dip->di_core.di_flushiter)) {
                 /*
                  * Deal with the wrap case, DI_MAX_FLUSH is less
                  * than smaller numbers
                  */
-                if ((INT_GET(dip->di_core.di_flushiter, ARCH_CONVERT)
-                                                        == DI_MAX_FLUSH) &&
-                    (dicp->di_flushiter < (DI_MAX_FLUSH>>1))) {
+                if (be16_to_cpu(dip->di_core.di_flushiter) == DI_MAX_FLUSH &&
+                    dicp->di_flushiter < (DI_MAX_FLUSH >> 1)) {
                         /* do nothing */
                 } else {
                         xfs_buf_relse(bp);
@@ -2411,8 +2409,8 @@ xlog_recover_do_inode_trans(
         }
 
         /* The core is in in-core format */
-        xfs_xlate_dinode_core((xfs_caddr_t)&dip->di_core,
-                              (xfs_dinode_core_t*)item->ri_buf[1].i_addr, -1);
+        xfs_dinode_to_disk(&dip->di_core,
+                (xfs_icdinode_t *)item->ri_buf[1].i_addr);
 
         /* the rest is in on-disk format */
         if (item->ri_buf[1].i_len > sizeof(xfs_dinode_core_t)) {
@@ -2424,8 +2422,7 @@ xlog_recover_do_inode_trans(
         fields = in_f->ilf_fields;
         switch (fields & (XFS_ILOG_DEV | XFS_ILOG_UUID)) {
         case XFS_ILOG_DEV:
-                INT_SET(dip->di_u.di_dev, ARCH_CONVERT, in_f->ilf_u.ilfu_rdev);
-
+                dip->di_u.di_dev = cpu_to_be32(in_f->ilf_u.ilfu_rdev);
                 break;
         case XFS_ILOG_UUID:
                 dip->di_u.di_muuid = in_f->ilf_u.ilfu_uuid;
@@ -3234,8 +3231,8 @@ xlog_recover_process_iunlinks(
                                         ASSERT(ip->i_d.di_nlink == 0);
 
                                         /* setup for the next pass */
-                                        agino = INT_GET(dip->di_next_unlinked,
-                                                        ARCH_CONVERT);
+                                        agino = be32_to_cpu(
+                                                        dip->di_next_unlinked);
                                         xfs_buf_relse(ibp);
                                         /*
                                          * Prevent any DMAPI event from