xfs: global error sign conversion

Convert all the errors the core XFs code to negative error signs
like the rest of the kernel and remove all the sign conversion we
do in the interface layers.

Errors for conversion (and comparison) found via searches like:

$ git grep " E" fs/xfs
$ git grep "return E" fs/xfs
$ git grep " E[A-Z].*;$" fs/xfs

Negation points found via searches like:

$ git grep "= -[a-z,A-Z]" fs/xfs
$ git grep "return -[a-z,A-D,F-Z]" fs/xfs
$ git grep " -[a-z].*;" fs/xfs

[ with some bits I missed from Brian Foster ]

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

1 files changed, 6 insertions, 6 deletions

diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index c6d603080e5b..923c044bd26f 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -110,7 +110,7 @@ xfs_alert_fsblock_zero(
                 (unsigned long long)imap->br_startoff,
                 (unsigned long long)imap->br_blockcount,
                 imap->br_state);
-        return EFSCORRUPTED;
+        return -EFSCORRUPTED;
 }
 
 int
@@ -225,7 +225,7 @@ xfs_iomap_write_direct(
          * Copy any maps to caller's array and return any error.
          */
         if (nimaps == 0) {
-                error = ENOSPC;
+                error = -ENOSPC;
                 goto out_unlock;
         }
 
@@ -596,8 +596,8 @@ retry:
                                 imap, &nimaps, XFS_BMAPI_ENTIRE);
         switch (error) {
         case 0:
-        case ENOSPC:
-        case EDQUOT:
+        case -ENOSPC:
+        case -EDQUOT:
                 break;
         default:
                 return error;
@@ -614,7 +614,7 @@ retry:
                         error = 0;
                         goto retry;
                 }
-                return error ? error : ENOSPC;
+                return error ? error : -ENOSPC;
         }
 
         if (!(imap[0].br_startblock || XFS_IS_REALTIME_INODE(ip)))
@@ -739,7 +739,7 @@ xfs_iomap_write_allocate(
                         if ((map_start_fsb + count_fsb) > last_block) {
                                 count_fsb = last_block - map_start_fsb;
                                 if (count_fsb == 0) {
-                                        error = EAGAIN;
+                                        error = -EAGAIN;
                                         goto trans_cancel;
                                 }
                         }