aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_inode_item.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2010-03-07 19:26:03 -0500
committerAlex Elder <aelder@sgi.com>2010-05-19 10:58:08 -0400
commit8e123850863366b738d6dfb9a84045018ff038fc (patch)
treeffa0185553c55d235b920e5ff384310be33034c6 /fs/xfs/xfs_inode_item.c
parent4aaf15d1aa9673dd2cc45c48957c946cb4aa2694 (diff)
xfs: remove stale parameter from ->iop_unpin method
The staleness of a object being unpinned can be directly derived from the object itself - there is no need to extract it from the object then pass it as a parameter into IOP_UNPIN(). This means we can kill the XFS_LID_BUF_STALE flag - it is set, checked and cleared in the same places XFS_BLI_STALE flag in the xfs_buf_log_item so it is now redundant and hence safe to remove. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_inode_item.c')
-rw-r--r--fs/xfs/xfs_inode_item.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c
index 03471757bc88..cf8249a60004 100644
--- a/fs/xfs/xfs_inode_item.c
+++ b/fs/xfs/xfs_inode_item.c
@@ -557,8 +557,7 @@ xfs_inode_item_pin(
557/* ARGSUSED */ 557/* ARGSUSED */
558STATIC void 558STATIC void
559xfs_inode_item_unpin( 559xfs_inode_item_unpin(
560 xfs_inode_log_item_t *iip, 560 xfs_inode_log_item_t *iip)
561 int stale)
562{ 561{
563 struct xfs_inode *ip = iip->ili_inode; 562 struct xfs_inode *ip = iip->ili_inode;
564 563
@@ -574,7 +573,7 @@ xfs_inode_item_unpin_remove(
574 xfs_inode_log_item_t *iip, 573 xfs_inode_log_item_t *iip,
575 xfs_trans_t *tp) 574 xfs_trans_t *tp)
576{ 575{
577 xfs_inode_item_unpin(iip, 0); 576 xfs_inode_item_unpin(iip);
578} 577}
579 578
580/* 579/*
@@ -840,7 +839,7 @@ static struct xfs_item_ops xfs_inode_item_ops = {
840 .iop_format = (void(*)(xfs_log_item_t*, xfs_log_iovec_t*)) 839 .iop_format = (void(*)(xfs_log_item_t*, xfs_log_iovec_t*))
841 xfs_inode_item_format, 840 xfs_inode_item_format,
842 .iop_pin = (void(*)(xfs_log_item_t*))xfs_inode_item_pin, 841 .iop_pin = (void(*)(xfs_log_item_t*))xfs_inode_item_pin,
843 .iop_unpin = (void(*)(xfs_log_item_t*, int))xfs_inode_item_unpin, 842 .iop_unpin = (void(*)(xfs_log_item_t*))xfs_inode_item_unpin,
844 .iop_unpin_remove = (void(*)(xfs_log_item_t*, xfs_trans_t*)) 843 .iop_unpin_remove = (void(*)(xfs_log_item_t*, xfs_trans_t*))
845 xfs_inode_item_unpin_remove, 844 xfs_inode_item_unpin_remove,
846 .iop_trylock = (uint(*)(xfs_log_item_t*))xfs_inode_item_trylock, 845 .iop_trylock = (uint(*)(xfs_log_item_t*))xfs_inode_item_trylock,