diff options
author | David Chinner <dgc@sgi.com> | 2007-11-23 00:29:18 -0500 |
---|---|---|
committer | Lachlan McIlroy <lachlan@redback.melbourne.sgi.com> | 2008-02-07 02:16:07 -0500 |
commit | 5d51eff4538bdfeb9b7a2ec030ee3b0980b067d2 (patch) | |
tree | 27606a34eab830ccc9a066f14f598af0c0c9027c /fs/xfs/xfs_inode.h | |
parent | e4143a1cf5973e3443c0650fc4c35292d3b7baa8 (diff) |
[XFS] Fix inode allocation latency
The log force added in xfs_iget_core() has been a performance issue since
it was introduced for tight loops that allocate then unlink a single file.
under heavy writeback, this can introduce unnecessary latency due tothe
log I/o getting stuck behind bulk data writes.
Fix this latency problem by avoinding the need for the log force by moving
the place we mark linux inode dirty to the transaction commit rather than
on transaction completion.
This also closes a potential hole in the sync code where a linux inode is
not dirty between the time it is modified and the time the log buffer has
been written to disk.
SGI-PV: 972753
SGI-Modid: xfs-linux-melb:xfs-kern:30007a
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_inode.h')
-rw-r--r-- | fs/xfs/xfs_inode.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index d8ed51e28cbb..bc869fd2f6ef 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h | |||
@@ -532,6 +532,7 @@ xfs_fsize_t xfs_file_last_byte(xfs_inode_t *); | |||
532 | void xfs_lock_inodes(xfs_inode_t **, int, int, uint); | 532 | void xfs_lock_inodes(xfs_inode_t **, int, int, uint); |
533 | 533 | ||
534 | void xfs_synchronize_atime(xfs_inode_t *); | 534 | void xfs_synchronize_atime(xfs_inode_t *); |
535 | void xfs_mark_inode_dirty_sync(xfs_inode_t *); | ||
535 | 536 | ||
536 | xfs_bmbt_rec_host_t *xfs_iext_get_ext(xfs_ifork_t *, xfs_extnum_t); | 537 | xfs_bmbt_rec_host_t *xfs_iext_get_ext(xfs_ifork_t *, xfs_extnum_t); |
537 | void xfs_iext_insert(xfs_ifork_t *, xfs_extnum_t, xfs_extnum_t, | 538 | void xfs_iext_insert(xfs_ifork_t *, xfs_extnum_t, xfs_extnum_t, |