[XFS] Fix inode allocation latency

The log force added in xfs_iget_core() has been a performance issue since
it was introduced for tight loops that allocate then unlink a single file.
under heavy writeback, this can introduce unnecessary latency due tothe
log I/o getting stuck behind bulk data writes.

Fix this latency problem by avoinding the need for the log force by moving
the place we mark linux inode dirty to the transaction commit rather than
on transaction completion.

This also closes a potential hole in the sync code where a linux inode is
not dirty between the time it is modified and the time the log buffer has
been written to disk.

SGI-PV: 972753
SGI-Modid: xfs-linux-melb:xfs-kern:30007a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

1 files changed, 0 insertions, 18 deletions

diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
index eecc33d3751f..f01b07687faf 100644
--- a/fs/xfs/xfs_iget.c
+++ b/fs/xfs/xfs_iget.c
@@ -140,27 +140,9 @@ again:
                                 return ENOENT;
                         }
 
-                        /*
-                         * There may be transactions sitting in the
-                         * incore log buffers or being flushed to disk
-                         * at this time.  We can't clear the
-                         * XFS_IRECLAIMABLE flag until these
-                         * transactions have hit the disk, otherwise we
-                         * will void the guarantee the flag provides
-                         * xfs_iunpin()
-                         */
-                        if (xfs_ipincount(ip)) {
-                                read_unlock(&pag->pag_ici_lock);
-                                xfs_log_force(mp, 0,
-                                        XFS_LOG_FORCE|XFS_LOG_SYNC);
-                                XFS_STATS_INC(xs_ig_frecycle);
-                                goto again;
-                        }
-
                         xfs_itrace_exit_tag(ip, "xfs_iget.alloc");
 
                         XFS_STATS_INC(xs_ig_found);
-
                         xfs_iflags_clear(ip, XFS_IRECLAIMABLE);
                         read_unlock(&pag->pag_ici_lock);