xfs: don't cache inodes read through bulkstat

When we read inodes via bulkstat, we generally only read them once
and then throw them away - they never get used again. If we retain
them in cache, then it simply causes the working set of inodes and
other cached items to be reclaimed just so the inode cache can grow.

Avoid this problem by marking inodes read by bulkstat not to be
cached and check this flag in .drop_inode to determine whether the
inode should be added to the VFS LRU or not. If the inode lookup
hits an already cached inode, then don't set the flag. If the inode
lookup hits an inode marked with no cache flag, remove the flag and
allow it to be cached once the current reference goes away.

Inodes marked as not cached will get cleaned up by the background
inode reclaim or via memory pressure, so they will still generate
some short term cache pressure. They will, however, be reclaimed
much sooner and in preference to cache hot inodes.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>

1 files changed, 6 insertions, 2 deletions

diff --git a/fs/xfs/xfs_iget.c b/fs/xfs/xfs_iget.c
index a98cb4524e6c..bcc6c249b2c7 100644
--- a/fs/xfs/xfs_iget.c
+++ b/fs/xfs/xfs_iget.c
@@ -289,7 +289,7 @@ xfs_iget_cache_hit(
         if (lock_flags != 0)
                 xfs_ilock(ip, lock_flags);
 
-        xfs_iflags_clear(ip, XFS_ISTALE);
+        xfs_iflags_clear(ip, XFS_ISTALE | XFS_IDONTCACHE);
         XFS_STATS_INC(xs_ig_found);
 
         return 0;
@@ -314,6 +314,7 @@ xfs_iget_cache_miss(
         struct xfs_inode        *ip;
         int                     error;
         xfs_agino_t             agino = XFS_INO_TO_AGINO(mp, ino);
+        int                     iflags;
 
         ip = xfs_inode_alloc(mp, ino);
         if (!ip)
@@ -358,8 +359,11 @@ xfs_iget_cache_miss(
          * memory barrier that ensures this detection works correctly at lookup
          * time.
          */
+        iflags = XFS_INEW;
+        if (flags & XFS_IGET_DONTCACHE)
+                iflags |= XFS_IDONTCACHE;
         ip->i_udquot = ip->i_gdquot = NULL;
-        xfs_iflags_set(ip, XFS_INEW);
+        xfs_iflags_set(ip, iflags);
 
         /* insert the new inode */
         spin_lock(&pag->pag_ici_lock);