aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_fsops.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2012-04-23 01:58:49 -0400
committerBen Myers <bpm@sgi.com>2012-05-14 17:20:45 -0400
commite70b73f84f474cc594a39bd8ff083974e6d69aea (patch)
tree0d365698ca2b6542aab8ca92c8e1f23b9c43da55 /fs/xfs/xfs_fsops.c
parentbf813cdddfb3a5bc88e1612e8f62a12367871213 (diff)
xfs: clean up buffer get/read call API
The xfs_buf_get/read API is not consistent in the units it uses, and does not use appropriate or consistent units/types for the variables. Convert the API to use disk addresses and block counts for all buffer get and read calls. Use consistent naming for all the functions and their declarations, and convert the internal functions to use disk addresses and block counts to avoid need to convert them from one type to another and back again. Fix all the callers to use disk addresses and block counts. In many cases, this removes an additional conversion from the function call as the callers already have a block count. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mark Tinguely <tinguely@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_fsops.c')
-rw-r--r--fs/xfs/xfs_fsops.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
index 1c6fdeb702ff..019ba5c52a49 100644
--- a/fs/xfs/xfs_fsops.c
+++ b/fs/xfs/xfs_fsops.c
@@ -147,9 +147,9 @@ xfs_growfs_data_private(
147 if ((error = xfs_sb_validate_fsb_count(&mp->m_sb, nb))) 147 if ((error = xfs_sb_validate_fsb_count(&mp->m_sb, nb)))
148 return error; 148 return error;
149 dpct = pct - mp->m_sb.sb_imax_pct; 149 dpct = pct - mp->m_sb.sb_imax_pct;
150 bp = xfs_buf_read_uncached(mp, mp->m_ddev_targp, 150 bp = xfs_buf_read_uncached(mp->m_ddev_targp,
151 XFS_FSB_TO_BB(mp, nb) - XFS_FSS_TO_BB(mp, 1), 151 XFS_FSB_TO_BB(mp, nb) - XFS_FSS_TO_BB(mp, 1),
152 BBTOB(XFS_FSS_TO_BB(mp, 1)), 0); 152 XFS_FSS_TO_BB(mp, 1), 0);
153 if (!bp) 153 if (!bp)
154 return EIO; 154 return EIO;
155 xfs_buf_relse(bp); 155 xfs_buf_relse(bp);