[XFS] endianess annotations for xfs_da_blkinfo_t

SGI-PV: 943272
SGI-Modid: xfs-linux-melb:xfs-kern:25495a

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nathan Scott <nathans@sgi.com>

1 files changed, 99 insertions, 107 deletions

diff --git a/fs/xfs/xfs_da_btree.c b/fs/xfs/xfs_da_btree.c
index 31796c7faba0..4f3bb1cb9615 100644
--- a/fs/xfs/xfs_da_btree.c
+++ b/fs/xfs/xfs_da_btree.c
@@ -126,7 +126,7 @@ xfs_da_node_create(xfs_da_args_t *args, xfs_dablk_t blkno, int level,
         node = bp->data;
         node->hdr.info.forw = 0;
         node->hdr.info.back = 0;
-        INT_SET(node->hdr.info.magic, ARCH_CONVERT, XFS_DA_NODE_MAGIC);
+        node->hdr.info.magic = cpu_to_be16(XFS_DA_NODE_MAGIC);
         node->hdr.info.pad = 0;
         node->hdr.count = 0;
         INT_SET(node->hdr.level, ARCH_CONVERT, level);
@@ -290,28 +290,28 @@ xfs_da_split(xfs_da_state_t *state)
 
         node = oldblk->bp->data;
         if (node->hdr.info.forw) {
-                if (INT_GET(node->hdr.info.forw, ARCH_CONVERT) == addblk->blkno) {
+                if (be32_to_cpu(node->hdr.info.forw) == addblk->blkno) {
                         bp = addblk->bp;
                 } else {
                         ASSERT(state->extravalid);
                         bp = state->extrablk.bp;
                 }
                 node = bp->data;
-                INT_SET(node->hdr.info.back, ARCH_CONVERT, oldblk->blkno);
+                node->hdr.info.back = cpu_to_be32(oldblk->blkno);
                 xfs_da_log_buf(state->args->trans, bp,
                     XFS_DA_LOGRANGE(node, &node->hdr.info,
                     sizeof(node->hdr.info)));
         }
         node = oldblk->bp->data;
-        if (INT_GET(node->hdr.info.back, ARCH_CONVERT)) {
-                if (INT_GET(node->hdr.info.back, ARCH_CONVERT) == addblk->blkno) {
+        if (node->hdr.info.back) {
+                if (be32_to_cpu(node->hdr.info.back) == addblk->blkno) {
                         bp = addblk->bp;
                 } else {
                         ASSERT(state->extravalid);
                         bp = state->extrablk.bp;
                 }
                 node = bp->data;
-                INT_SET(node->hdr.info.forw, ARCH_CONVERT, oldblk->blkno);
+                node->hdr.info.forw = cpu_to_be32(oldblk->blkno);
                 xfs_da_log_buf(state->args->trans, bp,
                     XFS_DA_LOGRANGE(node, &node->hdr.info,
                     sizeof(node->hdr.info)));
@@ -359,12 +359,12 @@ xfs_da_root_split(xfs_da_state_t *state, xfs_da_state_blk_t *blk1,
         ASSERT(bp != NULL);
         node = bp->data;
         oldroot = blk1->bp->data;
-        if (INT_GET(oldroot->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC) {
+        if (be16_to_cpu(oldroot->hdr.info.magic) == XFS_DA_NODE_MAGIC) {
                 size = (int)((char *)&oldroot->btree[INT_GET(oldroot->hdr.count, ARCH_CONVERT)] -
                              (char *)oldroot);
         } else {
                 ASSERT(XFS_DIR_IS_V2(mp));
-                ASSERT(INT_GET(oldroot->hdr.info.magic, ARCH_CONVERT) == XFS_DIR2_LEAFN_MAGIC);
+                ASSERT(be16_to_cpu(oldroot->hdr.info.magic) == XFS_DIR2_LEAFN_MAGIC);
                 leaf = (xfs_dir2_leaf_t *)oldroot;
                 size = (int)((char *)&leaf->ents[be16_to_cpu(leaf->hdr.count)] -
                              (char *)leaf);
@@ -392,7 +392,7 @@ xfs_da_root_split(xfs_da_state_t *state, xfs_da_state_blk_t *blk1,
         INT_SET(node->hdr.count, ARCH_CONVERT, 2);
 
 #ifdef DEBUG
-        if (INT_GET(oldroot->hdr.info.magic, ARCH_CONVERT) == XFS_DIR2_LEAFN_MAGIC) {
+        if (be16_to_cpu(oldroot->hdr.info.magic) == XFS_DIR2_LEAFN_MAGIC) {
                 ASSERT(blk1->blkno >= mp->m_dirleafblk &&
                        blk1->blkno < mp->m_dirfreeblk);
                 ASSERT(blk2->blkno >= mp->m_dirleafblk &&
@@ -424,7 +424,7 @@ xfs_da_node_split(xfs_da_state_t *state, xfs_da_state_blk_t *oldblk,
         int useextra;
 
         node = oldblk->bp->data;
-        ASSERT(INT_GET(node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
 
         /*
          * With V2 the extra block is data or freespace.
@@ -524,8 +524,8 @@ xfs_da_node_rebalance(xfs_da_state_t *state, xfs_da_state_blk_t *blk1,
                 node1 = node2;
                 node2 = tmpnode;
         }
-        ASSERT(INT_GET(node1->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
-        ASSERT(INT_GET(node2->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(node1->hdr.info.magic) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(node2->hdr.info.magic) == XFS_DA_NODE_MAGIC);
         count = (INT_GET(node1->hdr.count, ARCH_CONVERT) - INT_GET(node2->hdr.count, ARCH_CONVERT)) / 2;
         if (count == 0)
                 return;
@@ -622,7 +622,7 @@ xfs_da_node_add(xfs_da_state_t *state, xfs_da_state_blk_t *oldblk,
 
         node = oldblk->bp->data;
         mp = state->mp;
-        ASSERT(INT_GET(node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
         ASSERT((oldblk->index >= 0) && (oldblk->index <= INT_GET(node->hdr.count, ARCH_CONVERT)));
         ASSERT(newblk->blkno != 0);
         if (state->args->whichfork == XFS_DATA_FORK && XFS_DIR_IS_V2(mp))
@@ -768,7 +768,7 @@ xfs_da_root_join(xfs_da_state_t *state, xfs_da_state_blk_t *root_blk)
         ASSERT(args != NULL);
         ASSERT(root_blk->magic == XFS_DA_NODE_MAGIC);
         oldroot = root_blk->bp->data;
-        ASSERT(INT_GET(oldroot->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(oldroot->hdr.info.magic) == XFS_DA_NODE_MAGIC);
         ASSERT(!oldroot->hdr.info.forw);
         ASSERT(!oldroot->hdr.info.back);
 
@@ -791,10 +791,10 @@ xfs_da_root_join(xfs_da_state_t *state, xfs_da_state_blk_t *root_blk)
         ASSERT(bp != NULL);
         blkinfo = bp->data;
         if (INT_GET(oldroot->hdr.level, ARCH_CONVERT) == 1) {
-                ASSERT(INT_GET(blkinfo->magic, ARCH_CONVERT) == XFS_DIRX_LEAF_MAGIC(state->mp) ||
-                       INT_GET(blkinfo->magic, ARCH_CONVERT) == XFS_ATTR_LEAF_MAGIC);
+                ASSERT(be16_to_cpu(blkinfo->magic) == XFS_DIRX_LEAF_MAGIC(state->mp) ||
+                       be16_to_cpu(blkinfo->magic) == XFS_ATTR_LEAF_MAGIC);
         } else {
-                ASSERT(INT_GET(blkinfo->magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+                ASSERT(be16_to_cpu(blkinfo->magic) == XFS_DA_NODE_MAGIC);
         }
         ASSERT(!blkinfo->forw);
         ASSERT(!blkinfo->back);
@@ -830,7 +830,7 @@ xfs_da_node_toosmall(xfs_da_state_t *state, int *action)
          */
         blk = &state->path.blk[ state->path.active-1 ];
         info = blk->bp->data;
-        ASSERT(INT_GET(info->magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(info->magic) == XFS_DA_NODE_MAGIC);
         node = (xfs_da_intnode_t *)info;
         count = INT_GET(node->hdr.count, ARCH_CONVERT);
         if (count > (state->node_ents >> 1)) {
@@ -849,7 +849,7 @@ xfs_da_node_toosmall(xfs_da_state_t *state, int *action)
                  * Make altpath point to the block we want to keep and
                  * path point to the block we want to drop (this one).
                  */
-                forward = info->forw;
+                forward = (info->forw != 0);
                 memcpy(&state->altpath, &state->path, sizeof(state->path));
                 error = xfs_da_path_shift(state, &state->altpath, forward,
                                                  0, &retval);
@@ -871,13 +871,12 @@ xfs_da_node_toosmall(xfs_da_state_t *state, int *action)
          * to shrink a directory over time.
          */
         /* start with smaller blk num */
-        forward = (INT_GET(info->forw, ARCH_CONVERT)
-                                < INT_GET(info->back, ARCH_CONVERT));
+        forward = (be32_to_cpu(info->forw) < be32_to_cpu(info->back));
         for (i = 0; i < 2; forward = !forward, i++) {
                 if (forward)
-                        blkno = INT_GET(info->forw, ARCH_CONVERT);
+                        blkno = be32_to_cpu(info->forw);
                 else
-                        blkno = INT_GET(info->back, ARCH_CONVERT);
+                        blkno = be32_to_cpu(info->back);
                 if (blkno == 0)
                         continue;
                 error = xfs_da_read_buf(state->args->trans, state->args->dp,
@@ -891,7 +890,7 @@ xfs_da_node_toosmall(xfs_da_state_t *state, int *action)
                 count -= state->node_ents >> 2;
                 count -= INT_GET(node->hdr.count, ARCH_CONVERT);
                 node = bp->data;
-                ASSERT(INT_GET(node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+                ASSERT(be16_to_cpu(node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
                 count -= INT_GET(node->hdr.count, ARCH_CONVERT);
                 xfs_da_brelse(state->args->trans, bp);
                 if (count >= 0)
@@ -973,7 +972,7 @@ xfs_da_fixhashpath(xfs_da_state_t *state, xfs_da_state_path_t *path)
         }
         for (blk--, level--; level >= 0; blk--, level--) {
                 node = blk->bp->data;
-                ASSERT(INT_GET(node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+                ASSERT(be16_to_cpu(node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
                 btree = &node->btree[ blk->index ];
                 if (INT_GET(btree->hashval, ARCH_CONVERT) == lasthash)
                         break;
@@ -1041,8 +1040,8 @@ xfs_da_node_unbalance(xfs_da_state_t *state, xfs_da_state_blk_t *drop_blk,
 
         drop_node = drop_blk->bp->data;
         save_node = save_blk->bp->data;
-        ASSERT(INT_GET(drop_node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
-        ASSERT(INT_GET(save_node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(drop_node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(save_node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
         tp = state->args->trans;
 
         /*
@@ -1138,15 +1137,15 @@ xfs_da_node_lookup_int(xfs_da_state_t *state, int *result)
                         return(error);
                 }
                 curr = blk->bp->data;
-                ASSERT(INT_GET(curr->magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC ||
-                       INT_GET(curr->magic, ARCH_CONVERT) == XFS_DIRX_LEAF_MAGIC(state->mp) ||
-                       INT_GET(curr->magic, ARCH_CONVERT) == XFS_ATTR_LEAF_MAGIC);
+                ASSERT(be16_to_cpu(curr->magic) == XFS_DA_NODE_MAGIC ||
+                       be16_to_cpu(curr->magic) == XFS_DIRX_LEAF_MAGIC(state->mp) ||
+                       be16_to_cpu(curr->magic) == XFS_ATTR_LEAF_MAGIC);
 
                 /*
                  * Search an intermediate node for a match.
                  */
-                blk->magic = INT_GET(curr->magic, ARCH_CONVERT);
-                if (INT_GET(curr->magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC) {
+                blk->magic = be16_to_cpu(curr->magic);
+                if (blk->magic == XFS_DA_NODE_MAGIC) {
                         node = blk->bp->data;
                         blk->hashval = INT_GET(node->btree[ INT_GET(node->hdr.count, ARCH_CONVERT)-1 ].hashval, ARCH_CONVERT);
 
@@ -1193,15 +1192,15 @@ xfs_da_node_lookup_int(xfs_da_state_t *state, int *result)
                                 blkno = INT_GET(btree->before, ARCH_CONVERT);
                         }
                 }
-                else if (INT_GET(curr->magic, ARCH_CONVERT) == XFS_ATTR_LEAF_MAGIC) {
+                else if (be16_to_cpu(curr->magic) == XFS_ATTR_LEAF_MAGIC) {
                         blk->hashval = xfs_attr_leaf_lasthash(blk->bp, NULL);
                         break;
                 }
-                else if (INT_GET(curr->magic, ARCH_CONVERT) == XFS_DIR_LEAF_MAGIC) {
+                else if (be16_to_cpu(curr->magic) == XFS_DIR_LEAF_MAGIC) {
                         blk->hashval = xfs_dir_leaf_lasthash(blk->bp, NULL);
                         break;
                 }
-                else if (INT_GET(curr->magic, ARCH_CONVERT) == XFS_DIR2_LEAFN_MAGIC) {
+                else if (be16_to_cpu(curr->magic) == XFS_DIR2_LEAFN_MAGIC) {
                         blk->hashval = xfs_dir2_leafn_lasthash(blk->bp, NULL);
                         break;
                 }
@@ -1274,8 +1273,8 @@ xfs_da_blk_link(xfs_da_state_t *state, xfs_da_state_blk_t *old_blk,
         ASSERT(old_blk->magic == XFS_DA_NODE_MAGIC ||
                old_blk->magic == XFS_DIRX_LEAF_MAGIC(state->mp) ||
                old_blk->magic == XFS_ATTR_LEAF_MAGIC);
-        ASSERT(old_blk->magic == INT_GET(old_info->magic, ARCH_CONVERT));
-        ASSERT(new_blk->magic == INT_GET(new_info->magic, ARCH_CONVERT));
+        ASSERT(old_blk->magic == be16_to_cpu(old_info->magic));
+        ASSERT(new_blk->magic == be16_to_cpu(new_info->magic));
         ASSERT(old_blk->magic == new_blk->magic);
 
         switch (old_blk->magic) {
@@ -1302,47 +1301,44 @@ xfs_da_blk_link(xfs_da_state_t *state, xfs_da_state_blk_t *old_blk,
                 /*
                  * Link new block in before existing block.
                  */
-                INT_SET(new_info->forw, ARCH_CONVERT, old_blk->blkno);
-                new_info->back = old_info->back; /* INT_: direct copy */
-                if (INT_GET(old_info->back, ARCH_CONVERT)) {
+                new_info->forw = cpu_to_be32(old_blk->blkno);
+                new_info->back = old_info->back;
+                if (old_info->back) {
                         error = xfs_da_read_buf(args->trans, args->dp,
-                                                INT_GET(old_info->back,
-                                                        ARCH_CONVERT), -1, &bp,
-                                                args->whichfork);
+                                                be32_to_cpu(old_info->back),
+                                                -1, &bp, args->whichfork);
                         if (error)
                                 return(error);
                         ASSERT(bp != NULL);
                         tmp_info = bp->data;
-                        ASSERT(INT_GET(tmp_info->magic, ARCH_CONVERT) == INT_GET(old_info->magic, ARCH_CONVERT));
-                        ASSERT(INT_GET(tmp_info->forw, ARCH_CONVERT) == old_blk->blkno);
-                        INT_SET(tmp_info->forw, ARCH_CONVERT, new_blk->blkno);
+                        ASSERT(be16_to_cpu(tmp_info->magic) == be16_to_cpu(old_info->magic));
+                        ASSERT(be32_to_cpu(tmp_info->forw) == old_blk->blkno);
+                        tmp_info->forw = cpu_to_be32(new_blk->blkno);
                         xfs_da_log_buf(args->trans, bp, 0, sizeof(*tmp_info)-1);
                         xfs_da_buf_done(bp);
                 }
-                INT_SET(old_info->back, ARCH_CONVERT, new_blk->blkno);
+                old_info->back = cpu_to_be32(new_blk->blkno);
         } else {
                 /*
                  * Link new block in after existing block.
                  */
-                new_info->forw = old_info->forw; /* INT_: direct copy */
-                INT_SET(new_info->back, ARCH_CONVERT, old_blk->blkno);
-                if (INT_GET(old_info->forw, ARCH_CONVERT)) {
+                new_info->forw = old_info->forw;
+                new_info->back = cpu_to_be32(old_blk->blkno);
+                if (old_info->forw) {
                         error = xfs_da_read_buf(args->trans, args->dp,
-                                                INT_GET(old_info->forw, ARCH_CONVERT), -1, &bp,
-                                                args->whichfork);
+                                                be32_to_cpu(old_info->forw),
+                                                -1, &bp, args->whichfork);
                         if (error)
                                 return(error);
                         ASSERT(bp != NULL);
                         tmp_info = bp->data;
-                        ASSERT(INT_GET(tmp_info->magic, ARCH_CONVERT)
-                                    == INT_GET(old_info->magic, ARCH_CONVERT));
-                        ASSERT(INT_GET(tmp_info->back, ARCH_CONVERT)
-                                    == old_blk->blkno);
-                        INT_SET(tmp_info->back, ARCH_CONVERT, new_blk->blkno);
+                        ASSERT(tmp_info->magic == old_info->magic);
+                        ASSERT(be32_to_cpu(tmp_info->back) == old_blk->blkno);
+                        tmp_info->back = cpu_to_be32(new_blk->blkno);
                         xfs_da_log_buf(args->trans, bp, 0, sizeof(*tmp_info)-1);
                         xfs_da_buf_done(bp);
                 }
-                INT_SET(old_info->forw, ARCH_CONVERT, new_blk->blkno);
+                old_info->forw = cpu_to_be32(new_blk->blkno);
         }
 
         xfs_da_log_buf(args->trans, old_blk->bp, 0, sizeof(*tmp_info) - 1);
@@ -1360,8 +1356,8 @@ xfs_da_node_order(xfs_dabuf_t *node1_bp, xfs_dabuf_t *node2_bp)
 
         node1 = node1_bp->data;
         node2 = node2_bp->data;
-        ASSERT((INT_GET(node1->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC) &&
-               (INT_GET(node2->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC));
+        ASSERT((be16_to_cpu(node1->hdr.info.magic) == XFS_DA_NODE_MAGIC) &&
+               (be16_to_cpu(node2->hdr.info.magic) == XFS_DA_NODE_MAGIC));
         if ((INT_GET(node1->hdr.count, ARCH_CONVERT) > 0) && (INT_GET(node2->hdr.count, ARCH_CONVERT) > 0) &&
             ((INT_GET(node2->btree[ 0 ].hashval, ARCH_CONVERT) <
               INT_GET(node1->btree[ 0 ].hashval, ARCH_CONVERT)) ||
@@ -1381,7 +1377,7 @@ xfs_da_node_lasthash(xfs_dabuf_t *bp, int *count)
         xfs_da_intnode_t *node;
 
         node = bp->data;
-        ASSERT(INT_GET(node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+        ASSERT(be16_to_cpu(node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
         if (count)
                 *count = INT_GET(node->hdr.count, ARCH_CONVERT);
         if (!node->hdr.count)
@@ -1411,50 +1407,47 @@ xfs_da_blk_unlink(xfs_da_state_t *state, xfs_da_state_blk_t *drop_blk,
         ASSERT(save_blk->magic == XFS_DA_NODE_MAGIC ||
                save_blk->magic == XFS_DIRX_LEAF_MAGIC(state->mp) ||
                save_blk->magic == XFS_ATTR_LEAF_MAGIC);
-        ASSERT(save_blk->magic == INT_GET(save_info->magic, ARCH_CONVERT));
-        ASSERT(drop_blk->magic == INT_GET(drop_info->magic, ARCH_CONVERT));
+        ASSERT(save_blk->magic == be16_to_cpu(save_info->magic));
+        ASSERT(drop_blk->magic == be16_to_cpu(drop_info->magic));
         ASSERT(save_blk->magic == drop_blk->magic);
-        ASSERT((INT_GET(save_info->forw, ARCH_CONVERT) == drop_blk->blkno) ||
-               (INT_GET(save_info->back, ARCH_CONVERT) == drop_blk->blkno));
-        ASSERT((INT_GET(drop_info->forw, ARCH_CONVERT) == save_blk->blkno) ||
-               (INT_GET(drop_info->back, ARCH_CONVERT) == save_blk->blkno));
+        ASSERT((be32_to_cpu(save_info->forw) == drop_blk->blkno) ||
+               (be32_to_cpu(save_info->back) == drop_blk->blkno));
+        ASSERT((be32_to_cpu(drop_info->forw) == save_blk->blkno) ||
+               (be32_to_cpu(drop_info->back) == save_blk->blkno));
 
         /*
          * Unlink the leaf block from the doubly linked chain of leaves.
          */
-        if (INT_GET(save_info->back, ARCH_CONVERT) == drop_blk->blkno) {
-                save_info->back = drop_info->back; /* INT_: direct copy */
-                if (INT_GET(drop_info->back, ARCH_CONVERT)) {
+        if (be32_to_cpu(save_info->back) == drop_blk->blkno) {
+                save_info->back = drop_info->back;
+                if (drop_info->back) {
                         error = xfs_da_read_buf(args->trans, args->dp,
-                                                INT_GET(drop_info->back,
-                                                        ARCH_CONVERT), -1, &bp,
-                                                args->whichfork);
+                                                be32_to_cpu(drop_info->back),
+                                                -1, &bp, args->whichfork);
                         if (error)
                                 return(error);
                         ASSERT(bp != NULL);
                         tmp_info = bp->data;
-                        ASSERT(INT_GET(tmp_info->magic, ARCH_CONVERT) == INT_GET(save_info->magic, ARCH_CONVERT));
-                        ASSERT(INT_GET(tmp_info->forw, ARCH_CONVERT) == drop_blk->blkno);
-                        INT_SET(tmp_info->forw, ARCH_CONVERT, save_blk->blkno);
+                        ASSERT(tmp_info->magic == save_info->magic);
+                        ASSERT(be32_to_cpu(tmp_info->forw) == drop_blk->blkno);
+                        tmp_info->forw = cpu_to_be32(save_blk->blkno);
                         xfs_da_log_buf(args->trans, bp, 0,
                                                     sizeof(*tmp_info) - 1);
                         xfs_da_buf_done(bp);
                 }
         } else {
-                save_info->forw = drop_info->forw; /* INT_: direct copy */
-                if (INT_GET(drop_info->forw, ARCH_CONVERT)) {
+                save_info->forw = drop_info->forw;
+                if (drop_info->forw) {
                         error = xfs_da_read_buf(args->trans, args->dp,
-                                                INT_GET(drop_info->forw, ARCH_CONVERT), -1, &bp,
-                                                args->whichfork);
+                                                be32_to_cpu(drop_info->forw),
+                                                -1, &bp, args->whichfork);
                         if (error)
                                 return(error);
                         ASSERT(bp != NULL);
                         tmp_info = bp->data;
-                        ASSERT(INT_GET(tmp_info->magic, ARCH_CONVERT)
-                                    == INT_GET(save_info->magic, ARCH_CONVERT));
-                        ASSERT(INT_GET(tmp_info->back, ARCH_CONVERT)
-                                    == drop_blk->blkno);
-                        INT_SET(tmp_info->back, ARCH_CONVERT, save_blk->blkno);
+                        ASSERT(tmp_info->magic == save_info->magic);
+                        ASSERT(be32_to_cpu(tmp_info->back) == drop_blk->blkno);
+                        tmp_info->back = cpu_to_be32(save_blk->blkno);
                         xfs_da_log_buf(args->trans, bp, 0,
                                                     sizeof(*tmp_info) - 1);
                         xfs_da_buf_done(bp);
@@ -1497,7 +1490,7 @@ xfs_da_path_shift(xfs_da_state_t *state, xfs_da_state_path_t *path,
         for (blk = &path->blk[level]; level >= 0; blk--, level--) {
                 ASSERT(blk->bp != NULL);
                 node = blk->bp->data;
-                ASSERT(INT_GET(node->hdr.info.magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+                ASSERT(be16_to_cpu(node->hdr.info.magic) == XFS_DA_NODE_MAGIC);
                 if (forward && (blk->index < INT_GET(node->hdr.count, ARCH_CONVERT)-1)) {
                         blk->index++;
                         blkno = INT_GET(node->btree[ blk->index ].before, ARCH_CONVERT);
@@ -1536,11 +1529,11 @@ xfs_da_path_shift(xfs_da_state_t *state, xfs_da_state_path_t *path,
                         return(error);
                 ASSERT(blk->bp != NULL);
                 info = blk->bp->data;
-                ASSERT(INT_GET(info->magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC ||
-                       INT_GET(info->magic, ARCH_CONVERT) == XFS_DIRX_LEAF_MAGIC(state->mp) ||
-                       INT_GET(info->magic, ARCH_CONVERT) == XFS_ATTR_LEAF_MAGIC);
-                blk->magic = INT_GET(info->magic, ARCH_CONVERT);
-                if (INT_GET(info->magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC) {
+                ASSERT(be16_to_cpu(info->magic) == XFS_DA_NODE_MAGIC ||
+                       be16_to_cpu(info->magic) == XFS_DIRX_LEAF_MAGIC(state->mp) ||
+                       be16_to_cpu(info->magic) == XFS_ATTR_LEAF_MAGIC);
+                blk->magic = be16_to_cpu(info->magic);
+                if (blk->magic == XFS_DA_NODE_MAGIC) {
                         node = (xfs_da_intnode_t *)info;
                         blk->hashval = INT_GET(node->btree[ INT_GET(node->hdr.count, ARCH_CONVERT)-1 ].hashval, ARCH_CONVERT);
                         if (forward)
@@ -1788,19 +1781,19 @@ xfs_da_swap_lastblock(xfs_da_args_t *args, xfs_dablk_t *dead_blknop,
         /*
          * Get values from the moved block.
          */
-        if (INT_GET(dead_info->magic, ARCH_CONVERT) == XFS_DIR_LEAF_MAGIC) {
+        if (be16_to_cpu(dead_info->magic) == XFS_DIR_LEAF_MAGIC) {
                 ASSERT(XFS_DIR_IS_V1(mp));
                 dead_leaf = (xfs_dir_leafblock_t *)dead_info;
                 dead_level = 0;
                 dead_hash =
                         INT_GET(dead_leaf->entries[INT_GET(dead_leaf->hdr.count, ARCH_CONVERT) - 1].hashval, ARCH_CONVERT);
-        } else if (INT_GET(dead_info->magic, ARCH_CONVERT) == XFS_DIR2_LEAFN_MAGIC) {
+        } else if (be16_to_cpu(dead_info->magic) == XFS_DIR2_LEAFN_MAGIC) {
                 ASSERT(XFS_DIR_IS_V2(mp));
                 dead_leaf2 = (xfs_dir2_leaf_t *)dead_info;
                 dead_level = 0;
                 dead_hash = be32_to_cpu(dead_leaf2->ents[be16_to_cpu(dead_leaf2->hdr.count) - 1].hashval);
         } else {
-                ASSERT(INT_GET(dead_info->magic, ARCH_CONVERT) == XFS_DA_NODE_MAGIC);
+                ASSERT(be16_to_cpu(dead_info->magic) == XFS_DA_NODE_MAGIC);
                 dead_node = (xfs_da_intnode_t *)dead_info;
                 dead_level = INT_GET(dead_node->hdr.level, ARCH_CONVERT);
                 dead_hash = INT_GET(dead_node->btree[INT_GET(dead_node->hdr.count, ARCH_CONVERT) - 1].hashval, ARCH_CONVERT);
@@ -1809,19 +1802,19 @@ xfs_da_swap_lastblock(xfs_da_args_t *args, xfs_dablk_t *dead_blknop,
         /*
          * If the moved block has a left sibling, fix up the pointers.
          */
-        if ((sib_blkno = INT_GET(dead_info->back, ARCH_CONVERT))) {
+        if ((sib_blkno = be32_to_cpu(dead_info->back))) {
                 if ((error = xfs_da_read_buf(tp, ip, sib_blkno, -1, &sib_buf, w)))
                         goto done;
                 sib_info = sib_buf->data;
                 if (unlikely(
-                    INT_GET(sib_info->forw, ARCH_CONVERT) != last_blkno ||
-                    INT_GET(sib_info->magic, ARCH_CONVERT) != INT_GET(dead_info->magic, ARCH_CONVERT))) {
+                    be32_to_cpu(sib_info->forw) != last_blkno ||
+                    sib_info->magic != dead_info->magic)) {
                         XFS_ERROR_REPORT("xfs_da_swap_lastblock(2)",
                                          XFS_ERRLEVEL_LOW, mp);
                         error = XFS_ERROR(EFSCORRUPTED);
                         goto done;
                 }
-                INT_SET(sib_info->forw, ARCH_CONVERT, dead_blkno);
+                sib_info->forw = cpu_to_be32(dead_blkno);
                 xfs_da_log_buf(tp, sib_buf,
                         XFS_DA_LOGRANGE(sib_info, &sib_info->forw,
                                         sizeof(sib_info->forw)));
@@ -1831,20 +1824,19 @@ xfs_da_swap_lastblock(xfs_da_args_t *args, xfs_dablk_t *dead_blknop,
         /*
          * If the moved block has a right sibling, fix up the pointers.
          */
-        if ((sib_blkno = INT_GET(dead_info->forw, ARCH_CONVERT))) {
+        if ((sib_blkno = be32_to_cpu(dead_info->forw))) {
                 if ((error = xfs_da_read_buf(tp, ip, sib_blkno, -1, &sib_buf, w)))
                         goto done;
                 sib_info = sib_buf->data;
                 if (unlikely(
-                       INT_GET(sib_info->back, ARCH_CONVERT) != last_blkno
-                    || INT_GET(sib_info->magic, ARCH_CONVERT)
-                                != INT_GET(dead_info->magic, ARCH_CONVERT))) {
+                       be32_to_cpu(sib_info->back) != last_blkno ||
+                       sib_info->magic != dead_info->magic)) {
                         XFS_ERROR_REPORT("xfs_da_swap_lastblock(3)",
                                          XFS_ERRLEVEL_LOW, mp);
                         error = XFS_ERROR(EFSCORRUPTED);
                         goto done;
                 }
-                INT_SET(sib_info->back, ARCH_CONVERT, dead_blkno);
+                sib_info->back = cpu_to_be32(dead_blkno);
                 xfs_da_log_buf(tp, sib_buf,
                         XFS_DA_LOGRANGE(sib_info, &sib_info->back,
                                         sizeof(sib_info->back)));
@@ -1861,7 +1853,7 @@ xfs_da_swap_lastblock(xfs_da_args_t *args, xfs_dablk_t *dead_blknop,
                         goto done;
                 par_node = par_buf->data;
                 if (unlikely(
-                    INT_GET(par_node->hdr.info.magic, ARCH_CONVERT) != XFS_DA_NODE_MAGIC ||
+                    be16_to_cpu(par_node->hdr.info.magic) != XFS_DA_NODE_MAGIC ||
                     (level >= 0 && level != INT_GET(par_node->hdr.level, ARCH_CONVERT) + 1))) {
                         XFS_ERROR_REPORT("xfs_da_swap_lastblock(4)",
                                          XFS_ERRLEVEL_LOW, mp);
@@ -1898,7 +1890,7 @@ xfs_da_swap_lastblock(xfs_da_args_t *args, xfs_dablk_t *dead_blknop,
                         continue;
                 if (entno < INT_GET(par_node->hdr.count, ARCH_CONVERT))
                         break;
-                par_blkno = INT_GET(par_node->hdr.info.forw, ARCH_CONVERT);
+                par_blkno = be32_to_cpu(par_node->hdr.info.forw);
                 xfs_da_brelse(tp, par_buf);
                 par_buf = NULL;
                 if (unlikely(par_blkno == 0)) {
@@ -1912,7 +1904,7 @@ xfs_da_swap_lastblock(xfs_da_args_t *args, xfs_dablk_t *dead_blknop,
                 par_node = par_buf->data;
                 if (unlikely(
                     INT_GET(par_node->hdr.level, ARCH_CONVERT) != level ||
-                    INT_GET(par_node->hdr.info.magic, ARCH_CONVERT) != XFS_DA_NODE_MAGIC)) {
+                    be16_to_cpu(par_node->hdr.info.magic) != XFS_DA_NODE_MAGIC)) {
                         XFS_ERROR_REPORT("xfs_da_swap_lastblock(7)",
                                          XFS_ERRLEVEL_LOW, mp);
                         error = XFS_ERROR(EFSCORRUPTED);
@@ -2203,7 +2195,7 @@ xfs_da_do_buf(
                 info = rbp->data;
                 data = rbp->data;
                 free = rbp->data;
-                magic = INT_GET(info->magic, ARCH_CONVERT);
+                magic = be16_to_cpu(info->magic);
                 magic1 = be32_to_cpu(data->hdr.magic);
                 if (unlikely(
                     XFS_TEST_ERROR((magic != XFS_DA_NODE_MAGIC) &&