diff options
author | Christoph Hellwig <hch@infradead.org> | 2011-08-23 04:28:03 -0400 |
---|---|---|
committer | Alex Elder <aelder@sgi.com> | 2011-10-11 22:14:59 -0400 |
commit | 375ec69d2ef6e0797f19f5823e36e249765c3d41 (patch) | |
tree | 5c41cec41a3f8e852bb55500be6ed22efa30290c /fs/xfs/xfs_buf.c | |
parent | 7271d243f9d1b4106289e4cf876c8b1203de59ab (diff) |
xfs: remove delwri buffer handling from xfs_buf_iorequest
We cannot ever reach xfs_buf_iorequest for a buffer with XBF_DELWRI set,
given that all write handlers make sure that the buffer is remove from
the delwri queue before, and we never do reads with the XBF_DELWRI flag
set (which the code would not handle correctly anyway).
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_buf.c')
-rw-r--r-- | fs/xfs/xfs_buf.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index c57836dc778f..2e71a26da22e 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c | |||
@@ -1275,15 +1275,10 @@ xfs_buf_iorequest( | |||
1275 | { | 1275 | { |
1276 | trace_xfs_buf_iorequest(bp, _RET_IP_); | 1276 | trace_xfs_buf_iorequest(bp, _RET_IP_); |
1277 | 1277 | ||
1278 | if (bp->b_flags & XBF_DELWRI) { | 1278 | ASSERT(!(bp->b_flags & XBF_DELWRI)); |
1279 | xfs_buf_delwri_queue(bp, 1); | ||
1280 | return 0; | ||
1281 | } | ||
1282 | 1279 | ||
1283 | if (bp->b_flags & XBF_WRITE) { | 1280 | if (bp->b_flags & XBF_WRITE) |
1284 | xfs_buf_wait_unpin(bp); | 1281 | xfs_buf_wait_unpin(bp); |
1285 | } | ||
1286 | |||
1287 | xfs_buf_hold(bp); | 1282 | xfs_buf_hold(bp); |
1288 | 1283 | ||
1289 | /* Set the count to 1 initially, this will stop an I/O | 1284 | /* Set the count to 1 initially, this will stop an I/O |