diff options
author | Christoph Hellwig <hch@infradead.org> | 2011-08-23 04:28:07 -0400 |
---|---|---|
committer | Alex Elder <aelder@sgi.com> | 2011-10-11 22:15:00 -0400 |
commit | c2b006c1da1602551def200e4661535f02b82488 (patch) | |
tree | 6801f459bb218ed062d30e31eb92d3867ce8166a /fs/xfs/xfs_attr.c | |
parent | 61551f1ee536289084a4a8f1c4f187e2f371c440 (diff) |
xfs: let xfs_bwrite callers handle the xfs_buf_relse
Remove the xfs_buf_relse from xfs_bwrite and let the caller handle it to
mirror the delwri and read paths.
Also remove the mount pointer passed to xfs_bwrite, which is superflous now
that we have a mount pointer in the buftarg.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_attr.c')
-rw-r--r-- | fs/xfs/xfs_attr.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/xfs/xfs_attr.c b/fs/xfs/xfs_attr.c index b097fd5a2b3f..8f0f65833500 100644 --- a/fs/xfs/xfs_attr.c +++ b/fs/xfs/xfs_attr.c | |||
@@ -2128,9 +2128,10 @@ xfs_attr_rmtval_set(xfs_da_args_t *args) | |||
2128 | xfs_buf_iomove(bp, 0, tmp, src, XBRW_WRITE); | 2128 | xfs_buf_iomove(bp, 0, tmp, src, XBRW_WRITE); |
2129 | if (tmp < XFS_BUF_SIZE(bp)) | 2129 | if (tmp < XFS_BUF_SIZE(bp)) |
2130 | xfs_buf_zero(bp, tmp, XFS_BUF_SIZE(bp) - tmp); | 2130 | xfs_buf_zero(bp, tmp, XFS_BUF_SIZE(bp) - tmp); |
2131 | if ((error = xfs_bwrite(mp, bp))) {/* GROT: NOTE: synchronous write */ | 2131 | error = xfs_bwrite(bp); /* GROT: NOTE: synchronous write */ |
2132 | return (error); | 2132 | xfs_buf_relse(bp); |
2133 | } | 2133 | if (error) |
2134 | return error; | ||
2134 | src += tmp; | 2135 | src += tmp; |
2135 | valuelen -= tmp; | 2136 | valuelen -= tmp; |
2136 | 2137 | ||