xfs: return is not a function

return is not a function.  "return(EIO);" is silly;
"return (EIO);" moreso.  return is not a function.
Nuke the pointless parens.

[dchinner: catch a couple of extra cases in xfs_attr_list.c,
xfs_acl.c and xfs_linux.h.]

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

1 files changed, 23 insertions, 23 deletions

diff --git a/fs/xfs/xfs_attr.c b/fs/xfs/xfs_attr.c
index bfe36fc2cdc2..4cd541891a60 100644
--- a/fs/xfs/xfs_attr.c
+++ b/fs/xfs/xfs_attr.c
@@ -535,27 +535,27 @@ xfs_attr_shortform_addname(xfs_da_args_t *args)
 
         retval = xfs_attr_shortform_lookup(args);
         if ((args->flags & ATTR_REPLACE) && (retval == ENOATTR)) {
-                return(retval);
+                return retval;
         } else if (retval == EEXIST) {
                 if (args->flags & ATTR_CREATE)
-                        return(retval);
+                        return retval;
                 retval = xfs_attr_shortform_remove(args);
                 ASSERT(retval == 0);
         }
 
         if (args->namelen >= XFS_ATTR_SF_ENTSIZE_MAX ||
             args->valuelen >= XFS_ATTR_SF_ENTSIZE_MAX)
-                return(XFS_ERROR(ENOSPC));
+                return XFS_ERROR(ENOSPC);
 
         newsize = XFS_ATTR_SF_TOTSIZE(args->dp);
         newsize += XFS_ATTR_SF_ENTSIZE_BYNAME(args->namelen, args->valuelen);
 
         forkoff = xfs_attr_shortform_bytesfit(args->dp, newsize);
         if (!forkoff)
-                return(XFS_ERROR(ENOSPC));
+                return XFS_ERROR(ENOSPC);
 
         xfs_attr_shortform_add(args, forkoff);
-        return(0);
+        return 0;
 }
 
 
@@ -642,7 +642,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
                         ASSERT(committed);
                         args->trans = NULL;
                         xfs_bmap_cancel(args->flist);
-                        return(error);
+                        return error;
                 }
 
                 /*
@@ -658,13 +658,13 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
                  */
                 error = xfs_trans_roll(&args->trans, dp);
                 if (error)
-                        return (error);
+                        return error;
 
                 /*
                  * Fob the whole rest of the problem off on the Btree code.
                  */
                 error = xfs_attr_node_addname(args);
-                return(error);
+                return error;
         }
 
         /*
@@ -673,7 +673,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
          */
         error = xfs_trans_roll(&args->trans, dp);
         if (error)
-                return (error);
+                return error;
 
         /*
          * If there was an out-of-line value, allocate the blocks we
@@ -684,7 +684,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
         if (args->rmtblkno > 0) {
                 error = xfs_attr_rmtval_set(args);
                 if (error)
-                        return(error);
+                        return error;
         }
 
         /*
@@ -700,7 +700,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
                  */
                 error = xfs_attr3_leaf_flipflags(args);
                 if (error)
-                        return(error);
+                        return error;
 
                 /*
                  * Dismantle the "old" attribute/value pair by removing
@@ -714,7 +714,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
                 if (args->rmtblkno) {
                         error = xfs_attr_rmtval_remove(args);
                         if (error)
-                                return(error);
+                                return error;
                 }
 
                 /*
@@ -744,7 +744,7 @@ xfs_attr_leaf_addname(xfs_da_args_t *args)
                                 ASSERT(committed);
                                 args->trans = NULL;
                                 xfs_bmap_cancel(args->flist);
-                                return(error);
+                                return error;
                         }
 
                         /*
@@ -1031,7 +1031,7 @@ restart:
         if (args->rmtblkno > 0) {
                 error = xfs_attr_rmtval_set(args);
                 if (error)
-                        return(error);
+                        return error;
         }
 
         /*
@@ -1061,7 +1061,7 @@ restart:
                 if (args->rmtblkno) {
                         error = xfs_attr_rmtval_remove(args);
                         if (error)
-                                return(error);
+                                return error;
                 }
 
                 /*
@@ -1134,8 +1134,8 @@ out:
         if (state)
                 xfs_da_state_free(state);
         if (error)
-                return(error);
-        return(retval);
+                return error;
+        return retval;
 }
 
 /*
@@ -1297,7 +1297,7 @@ xfs_attr_node_removename(xfs_da_args_t *args)
 
 out:
         xfs_da_state_free(state);
-        return(error);
+        return error;
 }
 
 /*
@@ -1345,7 +1345,7 @@ xfs_attr_fillstate(xfs_da_state_t *state)
                 }
         }
 
-        return(0);
+        return 0;
 }
 
 /*
@@ -1376,7 +1376,7 @@ xfs_attr_refillstate(xfs_da_state_t *state)
                                                 blk->blkno, blk->disk_blkno,
                                                 &blk->bp, XFS_ATTR_FORK);
                         if (error)
-                                return(error);
+                                return error;
                 } else {
                         blk->bp = NULL;
                 }
@@ -1395,13 +1395,13 @@ xfs_attr_refillstate(xfs_da_state_t *state)
                                                 blk->blkno, blk->disk_blkno,
                                                 &blk->bp, XFS_ATTR_FORK);
                         if (error)
-                                return(error);
+                                return error;
                 } else {
                         blk->bp = NULL;
                 }
         }
 
-        return(0);
+        return 0;
 }
 
 /*
@@ -1455,5 +1455,5 @@ xfs_attr_node_get(xfs_da_args_t *args)
         }
 
         xfs_da_state_free(state);
-        return(retval);
+        return retval;
 }