diff options
author | Dave Chinner <dchinner@redhat.com> | 2011-03-06 18:05:35 -0500 |
---|---|---|
committer | Dave Chinner <david@fromorbit.com> | 2011-03-06 18:05:35 -0500 |
commit | 5348778699bba92bf28b79863e09e7181d8cf95c (patch) | |
tree | 77f5349bc85bf4d35b73a9a66de304535e507bf4 /fs/xfs/quota | |
parent | af34e09da42801c97f39f768c715f5511d914b52 (diff) |
xfs: convert xfs_fs_cmn_err to new error logging API
Continue to clean up the error logging code by converting all the
callers of xfs_fs_cmn_err() to the new API. Once done, remove the
unused old API function.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/quota')
-rw-r--r-- | fs/xfs/quota/xfs_dquot.c | 4 | ||||
-rw-r--r-- | fs/xfs/quota/xfs_dquot_item.c | 5 | ||||
-rw-r--r-- | fs/xfs/quota/xfs_qm.c | 13 |
3 files changed, 10 insertions, 12 deletions
diff --git a/fs/xfs/quota/xfs_dquot.c b/fs/xfs/quota/xfs_dquot.c index 773adc80d6b4..e1ff7e507670 100644 --- a/fs/xfs/quota/xfs_dquot.c +++ b/fs/xfs/quota/xfs_dquot.c | |||
@@ -1393,8 +1393,8 @@ xfs_qm_dqpurge( | |||
1393 | */ | 1393 | */ |
1394 | error = xfs_qm_dqflush(dqp, SYNC_WAIT); | 1394 | error = xfs_qm_dqflush(dqp, SYNC_WAIT); |
1395 | if (error) | 1395 | if (error) |
1396 | xfs_fs_cmn_err(CE_WARN, mp, | 1396 | xfs_warn(mp, "%s: dquot %p flush failed", |
1397 | "xfs_qm_dqpurge: dquot %p flush failed", dqp); | 1397 | __func__, dqp); |
1398 | xfs_dqflock(dqp); | 1398 | xfs_dqflock(dqp); |
1399 | } | 1399 | } |
1400 | ASSERT(atomic_read(&dqp->q_pincount) == 0); | 1400 | ASSERT(atomic_read(&dqp->q_pincount) == 0); |
diff --git a/fs/xfs/quota/xfs_dquot_item.c b/fs/xfs/quota/xfs_dquot_item.c index 2a1f3dc10a02..9e0e2fa3f2c8 100644 --- a/fs/xfs/quota/xfs_dquot_item.c +++ b/fs/xfs/quota/xfs_dquot_item.c | |||
@@ -136,9 +136,8 @@ xfs_qm_dquot_logitem_push( | |||
136 | */ | 136 | */ |
137 | error = xfs_qm_dqflush(dqp, 0); | 137 | error = xfs_qm_dqflush(dqp, 0); |
138 | if (error) | 138 | if (error) |
139 | xfs_fs_cmn_err(CE_WARN, dqp->q_mount, | 139 | xfs_warn(dqp->q_mount, "%s: push error %d on dqp %p", |
140 | "xfs_qm_dquot_logitem_push: push error %d on dqp %p", | 140 | __func__, error, dqp); |
141 | error, dqp); | ||
142 | xfs_dqunlock(dqp); | 141 | xfs_dqunlock(dqp); |
143 | } | 142 | } |
144 | 143 | ||
diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c index dd5cc5738a2c..e34dce1ce542 100644 --- a/fs/xfs/quota/xfs_qm.c +++ b/fs/xfs/quota/xfs_qm.c | |||
@@ -402,14 +402,13 @@ xfs_qm_mount_quotas( | |||
402 | * off, but the on disk superblock doesn't know that ! | 402 | * off, but the on disk superblock doesn't know that ! |
403 | */ | 403 | */ |
404 | ASSERT(!(XFS_IS_QUOTA_RUNNING(mp))); | 404 | ASSERT(!(XFS_IS_QUOTA_RUNNING(mp))); |
405 | xfs_fs_cmn_err(CE_ALERT, mp, | 405 | xfs_alert(mp, "%s: Superblock update failed!", |
406 | "XFS mount_quotas: Superblock update failed!"); | 406 | __func__); |
407 | } | 407 | } |
408 | } | 408 | } |
409 | 409 | ||
410 | if (error) { | 410 | if (error) { |
411 | xfs_fs_cmn_err(CE_WARN, mp, | 411 | xfs_warn(mp, "Failed to initialize disk quotas."); |
412 | "Failed to initialize disk quotas."); | ||
413 | return; | 412 | return; |
414 | } | 413 | } |
415 | 414 | ||
@@ -1257,7 +1256,7 @@ xfs_qm_qino_alloc( | |||
1257 | xfs_mod_sb(tp, sbfields); | 1256 | xfs_mod_sb(tp, sbfields); |
1258 | 1257 | ||
1259 | if ((error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES))) { | 1258 | if ((error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES))) { |
1260 | xfs_fs_cmn_err(CE_ALERT, mp, "XFS qino_alloc failed!"); | 1259 | xfs_alert(mp, "%s failed (error %d)!", __func__, error); |
1261 | return error; | 1260 | return error; |
1262 | } | 1261 | } |
1263 | return 0; | 1262 | return 0; |
@@ -1930,8 +1929,8 @@ again: | |||
1930 | */ | 1929 | */ |
1931 | error = xfs_qm_dqflush(dqp, 0); | 1930 | error = xfs_qm_dqflush(dqp, 0); |
1932 | if (error) { | 1931 | if (error) { |
1933 | xfs_fs_cmn_err(CE_WARN, mp, | 1932 | xfs_warn(mp, "%s: dquot %p flush failed", |
1934 | "xfs_qm_dqreclaim: dquot %p flush failed", dqp); | 1933 | __func__, dqp); |
1935 | } | 1934 | } |
1936 | goto dqunlock; | 1935 | goto dqunlock; |
1937 | } | 1936 | } |