[XFS] Check for dquot flush errors

xfs_qm_dqflush() can fail, but the return is not checked anywhere. Hence
we never know if we've failed to flush a dquot to disk. Propagate the
error and warn to the syslog if a flush ever fails.

SGI-PV: 980084
SGI-Modid: xfs-linux-melb:xfs-kern:30787a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Niv Sardi <xaiki@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

1 files changed, 12 insertions, 2 deletions

diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
index 04b29c672141..0ed3c8277fcd 100644
--- a/fs/xfs/quota/xfs_qm.c
+++ b/fs/xfs/quota/xfs_qm.c
@@ -2094,12 +2094,17 @@ xfs_qm_shake_freelist(
                  * dirty dquots.
                  */
                 if (XFS_DQ_IS_DIRTY(dqp)) {
+                        int     error;
                         xfs_dqtrace_entry(dqp, "DQSHAKE: DQDIRTY");
                         /*
                          * We flush it delayed write, so don't bother
                          * releasing the mplock.
                          */
-                        (void) xfs_qm_dqflush(dqp, XFS_QMOPT_DELWRI);
+                        error = xfs_qm_dqflush(dqp, XFS_QMOPT_DELWRI);
+                        if (error) {
+                                xfs_fs_cmn_err(CE_WARN, dqp->q_mount,
+                        "xfs_qm_dqflush_all: dquot %p flush failed", dqp);
+                        }
                         xfs_dqunlock(dqp); /* dqflush unlocks dqflock */
                         dqp = dqp->dq_flnext;
                         continue;
@@ -2266,12 +2271,17 @@ xfs_qm_dqreclaim_one(void)
                  * dirty dquots.
                  */
                 if (XFS_DQ_IS_DIRTY(dqp)) {
+                        int     error;
                         xfs_dqtrace_entry(dqp, "DQRECLAIM: DQDIRTY");
                         /*
                          * We flush it delayed write, so don't bother
                          * releasing the freelist lock.
                          */
-                        (void) xfs_qm_dqflush(dqp, XFS_QMOPT_DELWRI);
+                        error = xfs_qm_dqflush(dqp, XFS_QMOPT_DELWRI);
+                        if (error) {
+                                xfs_fs_cmn_err(CE_WARN, dqp->q_mount,
+                        "xfs_qm_dqreclaim: dquot %p flush failed", dqp);
+                        }
                         xfs_dqunlock(dqp); /* dqflush unlocks dqflock */
                         continue;
                 }