xfs: lockless per-ag lookups

When we start taking a reference to the per-ag for every cached
buffer in the system, kernel lockstat profiling on an 8-way create
workload shows the mp->m_perag_lock has higher acquisition rates
than the inode lock and has significantly more contention. That is,
it becomes the highest contended lock in the system.

The perag lookup is trivial to convert to lock-less RCU lookups
because perag structures never go away. Hence the only thing we need
to protect against is tree structure changes during a grow. This can
be done simply by replacing the locking in xfs_perag_get() with RCU
read locking. This removes the mp->m_perag_lock completely from this
path.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
index 81976ffed7d6..3a1d229b4784 100644
--- a/fs/xfs/linux-2.6/xfs_sync.c
+++ b/fs/xfs/linux-2.6/xfs_sync.c
@@ -150,17 +150,17 @@ xfs_inode_ag_iter_next_pag(
                 int found;
                 int ref;
 
-                spin_lock(&mp->m_perag_lock);
+                rcu_read_lock();
                 found = radix_tree_gang_lookup_tag(&mp->m_perag_tree,
                                 (void **)&pag, *first, 1, tag);
                 if (found <= 0) {
-                        spin_unlock(&mp->m_perag_lock);
+                        rcu_read_unlock();
                         return NULL;
                 }
                 *first = pag->pag_agno + 1;
                 /* open coded pag reference increment */
                 ref = atomic_inc_return(&pag->pag_ref);
-                spin_unlock(&mp->m_perag_lock);
+                rcu_read_unlock();
                 trace_xfs_perag_get_reclaim(mp, pag->pag_agno, ref, _RET_IP_);
         } else {
                 pag = xfs_perag_get(mp, *first);