aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/linux-2.6/xfs_super.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2010-06-23 21:45:34 -0400
committerAlex Elder <aelder@sgi.com>2010-07-26 14:16:42 -0400
commit64c86149410bc62d9ac27a0594b3402a2aca03d8 (patch)
tree58ba57bd091ad80c1c7592bdd7539b10c3e3f6b8 /fs/xfs/linux-2.6/xfs_super.c
parentf2bde9b89b4d67c9bc3b963cb996f449ddcd27a4 (diff)
xfs: remove explicit xfs_sync_data/xfs_sync_attr calls on umount
On the final put of a superblock the VFS already calls sync_filesystem for us to write out all data and wait for it. No need to start another asynchronous writeback inside ->put_super. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'fs/xfs/linux-2.6/xfs_super.c')
-rw-r--r--fs/xfs/linux-2.6/xfs_super.c12
1 files changed, 0 insertions, 12 deletions
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index 9a72c05b6177..0ac1df74341f 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -1146,18 +1146,6 @@ xfs_fs_put_super(
1146 1146
1147 xfs_syncd_stop(mp); 1147 xfs_syncd_stop(mp);
1148 1148
1149 if (!(sb->s_flags & MS_RDONLY)) {
1150 /*
1151 * XXX(hch): this should be SYNC_WAIT.
1152 *
1153 * Or more likely not needed at all because the VFS is already
1154 * calling ->sync_fs after shutting down all filestem
1155 * operations and just before calling ->put_super.
1156 */
1157 xfs_sync_data(mp, 0);
1158 xfs_sync_attr(mp, 0);
1159 }
1160
1161 /* 1149 /*
1162 * Blow away any referenced inode in the filestreams cache. 1150 * Blow away any referenced inode in the filestreams cache.
1163 * This can and will cause log traffic as inodes go inactive 1151 * This can and will cause log traffic as inodes go inactive