diff options
author | Christoph Hellwig <hch@infradead.org> | 2010-06-23 21:51:19 -0400 |
---|---|---|
committer | Alex Elder <aelder@sgi.com> | 2010-07-26 14:16:44 -0400 |
commit | ef35e9255d4ed12522e836fbcec861e7306d794a (patch) | |
tree | 4ae5b2aef3f8dac9dd44490f6952e359239aa117 /fs/xfs/linux-2.6/xfs_export.c | |
parent | d2e078c33c24f97411b0fdd7cd2173e68125e7e3 (diff) |
xfs: remove xfs_iput_new
We never get an i_mode of 0 or a locked VFS inode until we pass in the
XFS_IGET_CREATE flag to xfs_iget, which makes xfs_iput_new equivalent to
xfs_iput for the only caller. In addition to that xfs_nfs_get_inode
does not even need to lock the inode given that the generation never changes
for a life inode, so just pass a 0 lock_flags to xfs_iget and release
the inode using IRELE in the error path.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to 'fs/xfs/linux-2.6/xfs_export.c')
-rw-r--r-- | fs/xfs/linux-2.6/xfs_export.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/fs/xfs/linux-2.6/xfs_export.c b/fs/xfs/linux-2.6/xfs_export.c index 09c91325f727..3764d74790ec 100644 --- a/fs/xfs/linux-2.6/xfs_export.c +++ b/fs/xfs/linux-2.6/xfs_export.c | |||
@@ -29,6 +29,7 @@ | |||
29 | #include "xfs_bmap_btree.h" | 29 | #include "xfs_bmap_btree.h" |
30 | #include "xfs_inode.h" | 30 | #include "xfs_inode.h" |
31 | #include "xfs_inode_item.h" | 31 | #include "xfs_inode_item.h" |
32 | #include "xfs_trace.h" | ||
32 | 33 | ||
33 | /* | 34 | /* |
34 | * Note that we only accept fileids which are long enough rather than allow | 35 | * Note that we only accept fileids which are long enough rather than allow |
@@ -131,8 +132,7 @@ xfs_nfs_get_inode( | |||
131 | * fine and not an indication of a corrupted filesystem as clients can | 132 | * fine and not an indication of a corrupted filesystem as clients can |
132 | * send invalid file handles and we have to handle it gracefully.. | 133 | * send invalid file handles and we have to handle it gracefully.. |
133 | */ | 134 | */ |
134 | error = xfs_iget(mp, NULL, ino, XFS_IGET_UNTRUSTED, | 135 | error = xfs_iget(mp, NULL, ino, XFS_IGET_UNTRUSTED, 0, &ip); |
135 | XFS_ILOCK_SHARED, &ip); | ||
136 | if (error) { | 136 | if (error) { |
137 | /* | 137 | /* |
138 | * EINVAL means the inode cluster doesn't exist anymore. | 138 | * EINVAL means the inode cluster doesn't exist anymore. |
@@ -147,11 +147,10 @@ xfs_nfs_get_inode( | |||
147 | } | 147 | } |
148 | 148 | ||
149 | if (ip->i_d.di_gen != generation) { | 149 | if (ip->i_d.di_gen != generation) { |
150 | xfs_iput_new(ip, XFS_ILOCK_SHARED); | 150 | IRELE(ip); |
151 | return ERR_PTR(-ENOENT); | 151 | return ERR_PTR(-ENOENT); |
152 | } | 152 | } |
153 | 153 | ||
154 | xfs_iunlock(ip, XFS_ILOCK_SHARED); | ||
155 | return VFS_I(ip); | 154 | return VFS_I(ip); |
156 | } | 155 | } |
157 | 156 | ||