aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/linux-2.6/xfs_buf.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2008-05-19 21:31:13 -0400
committerNiv Sardi <xaiki@debian.org>2008-07-28 02:58:25 -0400
commit19f354d4c3f4c48bf6b2a86227d8e3050e5f7d50 (patch)
treea45bf7262dcac3a5f87a3db1d42e2e9a43577cd2 /fs/xfs/linux-2.6/xfs_buf.c
parentaf15b8953a60d336aade96a2c162abffdba75ec9 (diff)
[XFS] sort out opening and closing of the block devices
Currently closing the rt/log block device is done in the wrong spot, and far too early. So revampt it: - xfs_blkdev_put moved out of xfs_free_buftarg into the caller so that it is done after tearing down the buftarg completely. - call to xfs_unmountfs_close moved from xfs_mountfs into caller so that it's done after tearing down the filesystem completely. - xfs_unmountfs_close is renamed to xfs_close_devices and made static in xfs_super.c - opening of the block devices is split into a helper xfs_open_devices that is symetric in use to xfs_close_devices - xfs_unmountfs can now lose struct cred - error handling around device opening sanitized in xfs_fs_fill_super SGI-PV: 981951 SGI-Modid: xfs-linux-melb:xfs-kern:31193a Signed-off-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: David Chinner <dgc@sgi.com> Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
Diffstat (limited to 'fs/xfs/linux-2.6/xfs_buf.c')
-rw-r--r--fs/xfs/linux-2.6/xfs_buf.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c
index ed03c6d3c9c1..9cc8f0213095 100644
--- a/fs/xfs/linux-2.6/xfs_buf.c
+++ b/fs/xfs/linux-2.6/xfs_buf.c
@@ -1427,13 +1427,10 @@ xfs_unregister_buftarg(
1427 1427
1428void 1428void
1429xfs_free_buftarg( 1429xfs_free_buftarg(
1430 xfs_buftarg_t *btp, 1430 xfs_buftarg_t *btp)
1431 int external)
1432{ 1431{
1433 xfs_flush_buftarg(btp, 1); 1432 xfs_flush_buftarg(btp, 1);
1434 xfs_blkdev_issue_flush(btp); 1433 xfs_blkdev_issue_flush(btp);
1435 if (external)
1436 xfs_blkdev_put(btp->bt_bdev);
1437 xfs_free_bufhash(btp); 1434 xfs_free_bufhash(btp);
1438 iput(btp->bt_mapping->host); 1435 iput(btp->bt_mapping->host);
1439 1436