diff options
author | Robert Love <rml@novell.com> | 2005-07-12 17:06:03 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-07-12 23:38:38 -0400 |
commit | 0eeca28300df110bd6ed54b31193c83b87921443 (patch) | |
tree | 7db42d8a18d80eca538f5b7d25e0532b8fa38b85 /fs/xattr.c | |
parent | bd4c625c061c2a38568d0add3478f59172455159 (diff) |
[PATCH] inotify
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user interface:
* dnotify requires the opening of one fd per each directory
that you intend to watch. This quickly results in too many
open files and pins removable media, preventing unmount.
* dnotify is directory-based. You only learn about changes to
directories. Sure, a change to a file in a directory affects
the directory, but you are then forced to keep a cache of
stat structures.
* dnotify's interface to user-space is awful. Signals?
inotify provides a more usable, simple, powerful solution to file change
notification:
* inotify's interface is a system call that returns a fd, not SIGIO.
You get a single fd, which is select()-able.
* inotify has an event that says "the filesystem that the item
you were watching is on was unmounted."
* inotify can watch directories or files.
Inotify is currently used by Beagle (a desktop search infrastructure),
Gamin (a FAM replacement), and other projects.
See Documentation/filesystems/inotify.txt.
Signed-off-by: Robert Love <rml@novell.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/xattr.c')
-rw-r--r-- | fs/xattr.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/xattr.c b/fs/xattr.c index 93dee70a1dbe..6acd5c63da91 100644 --- a/fs/xattr.c +++ b/fs/xattr.c | |||
@@ -16,6 +16,7 @@ | |||
16 | #include <linux/security.h> | 16 | #include <linux/security.h> |
17 | #include <linux/syscalls.h> | 17 | #include <linux/syscalls.h> |
18 | #include <linux/module.h> | 18 | #include <linux/module.h> |
19 | #include <linux/fsnotify.h> | ||
19 | #include <asm/uaccess.h> | 20 | #include <asm/uaccess.h> |
20 | 21 | ||
21 | /* | 22 | /* |
@@ -57,8 +58,10 @@ setxattr(struct dentry *d, char __user *name, void __user *value, | |||
57 | if (error) | 58 | if (error) |
58 | goto out; | 59 | goto out; |
59 | error = d->d_inode->i_op->setxattr(d, kname, kvalue, size, flags); | 60 | error = d->d_inode->i_op->setxattr(d, kname, kvalue, size, flags); |
60 | if (!error) | 61 | if (!error) { |
62 | fsnotify_xattr(d); | ||
61 | security_inode_post_setxattr(d, kname, kvalue, size, flags); | 63 | security_inode_post_setxattr(d, kname, kvalue, size, flags); |
64 | } | ||
62 | out: | 65 | out: |
63 | up(&d->d_inode->i_sem); | 66 | up(&d->d_inode->i_sem); |
64 | } | 67 | } |