diff options
author | Dan Carpenter <error27@gmail.com> | 2011-05-26 19:25:12 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-26 20:12:33 -0400 |
commit | 1d5827235de48e829d5d4a03c3688ef6f2b15562 (patch) | |
tree | 96d63baddd6fe6d764557f8be7d4f1e829059792 /fs/ufs | |
parent | 9796cc964daf7f18b4cd84c86975b3bc3804ca5a (diff) |
ufs: fix truncated values handling 64 bit metadata
Originally i_lastfrag was 32 bits but then we added support for handling
64 bit metadata and it became a 64 bit variable. That was during 2007, in
54fb996ac15c "[PATCH] ufs2 write: block allocation update". Unfortunately
these casts got left behind so the value got truncated to 32 bit again.
[akpm@linux-foundation.org: remove now-unneeded min_t/max_t casting]
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Evgeniy Dushistov <dushistov@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ufs')
-rw-r--r-- | fs/ufs/balloc.c | 9 | ||||
-rw-r--r-- | fs/ufs/truncate.c | 2 |
2 files changed, 6 insertions, 5 deletions
diff --git a/fs/ufs/balloc.c b/fs/ufs/balloc.c index 46f7a807bbc1..42694e11c23d 100644 --- a/fs/ufs/balloc.c +++ b/fs/ufs/balloc.c | |||
@@ -424,8 +424,7 @@ u64 ufs_new_fragments(struct inode *inode, void *p, u64 fragment, | |||
424 | ufs_cpu_to_data_ptr(sb, p, result); | 424 | ufs_cpu_to_data_ptr(sb, p, result); |
425 | *err = 0; | 425 | *err = 0; |
426 | UFS_I(inode)->i_lastfrag = | 426 | UFS_I(inode)->i_lastfrag = |
427 | max_t(u32, UFS_I(inode)->i_lastfrag, | 427 | max(UFS_I(inode)->i_lastfrag, fragment + count); |
428 | fragment + count); | ||
429 | ufs_clear_frags(inode, result + oldcount, | 428 | ufs_clear_frags(inode, result + oldcount, |
430 | newcount - oldcount, locked_page != NULL); | 429 | newcount - oldcount, locked_page != NULL); |
431 | } | 430 | } |
@@ -440,7 +439,8 @@ u64 ufs_new_fragments(struct inode *inode, void *p, u64 fragment, | |||
440 | result = ufs_add_fragments (inode, tmp, oldcount, newcount, err); | 439 | result = ufs_add_fragments (inode, tmp, oldcount, newcount, err); |
441 | if (result) { | 440 | if (result) { |
442 | *err = 0; | 441 | *err = 0; |
443 | UFS_I(inode)->i_lastfrag = max_t(u32, UFS_I(inode)->i_lastfrag, fragment + count); | 442 | UFS_I(inode)->i_lastfrag = max(UFS_I(inode)->i_lastfrag, |
443 | fragment + count); | ||
444 | ufs_clear_frags(inode, result + oldcount, newcount - oldcount, | 444 | ufs_clear_frags(inode, result + oldcount, newcount - oldcount, |
445 | locked_page != NULL); | 445 | locked_page != NULL); |
446 | unlock_super(sb); | 446 | unlock_super(sb); |
@@ -479,7 +479,8 @@ u64 ufs_new_fragments(struct inode *inode, void *p, u64 fragment, | |||
479 | uspi->s_sbbase + result, locked_page); | 479 | uspi->s_sbbase + result, locked_page); |
480 | ufs_cpu_to_data_ptr(sb, p, result); | 480 | ufs_cpu_to_data_ptr(sb, p, result); |
481 | *err = 0; | 481 | *err = 0; |
482 | UFS_I(inode)->i_lastfrag = max_t(u32, UFS_I(inode)->i_lastfrag, fragment + count); | 482 | UFS_I(inode)->i_lastfrag = max(UFS_I(inode)->i_lastfrag, |
483 | fragment + count); | ||
483 | unlock_super(sb); | 484 | unlock_super(sb); |
484 | if (newcount < request) | 485 | if (newcount < request) |
485 | ufs_free_fragments (inode, result + newcount, request - newcount); | 486 | ufs_free_fragments (inode, result + newcount, request - newcount); |
diff --git a/fs/ufs/truncate.c b/fs/ufs/truncate.c index 5f821dbc0579..f04f89fbd4d9 100644 --- a/fs/ufs/truncate.c +++ b/fs/ufs/truncate.c | |||
@@ -84,7 +84,7 @@ static int ufs_trunc_direct(struct inode *inode) | |||
84 | retry = 0; | 84 | retry = 0; |
85 | 85 | ||
86 | frag1 = DIRECT_FRAGMENT; | 86 | frag1 = DIRECT_FRAGMENT; |
87 | frag4 = min_t(u32, UFS_NDIR_FRAGMENT, ufsi->i_lastfrag); | 87 | frag4 = min_t(u64, UFS_NDIR_FRAGMENT, ufsi->i_lastfrag); |
88 | frag2 = ((frag1 & uspi->s_fpbmask) ? ((frag1 | uspi->s_fpbmask) + 1) : frag1); | 88 | frag2 = ((frag1 & uspi->s_fpbmask) ? ((frag1 | uspi->s_fpbmask) + 1) : frag1); |
89 | frag3 = frag4 & ~uspi->s_fpbmask; | 89 | frag3 = frag4 & ~uspi->s_fpbmask; |
90 | block1 = block2 = 0; | 90 | block1 = block2 = 0; |