diff options
author | Christoph Hellwig <hch@lst.de> | 2010-05-26 11:53:41 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2010-05-27 22:06:06 -0400 |
commit | 1b061d9247f71cd15edc4c4c4600191a903642c0 (patch) | |
tree | 30d92ca82d8286e7a45fba108230ecd23e61673b /fs/ufs | |
parent | 7ea8085910ef3dd4f3cad6845aaa2b580d39b115 (diff) |
rename the generic fsync implementations
We don't name our generic fsync implementations very well currently.
The no-op implementation for in-memory filesystems currently is called
simple_sync_file which doesn't make too much sense to start with,
the the generic one for simple filesystems is called simple_fsync
which can lead to some confusion.
This patch renames the generic file fsync method to generic_file_fsync
to match the other generic_file_* routines it is supposed to be used
with, and the no-op implementation to noop_fsync to make it obvious
what to expect. In addition add some documentation for both methods.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ufs')
-rw-r--r-- | fs/ufs/dir.c | 2 | ||||
-rw-r--r-- | fs/ufs/file.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index 317a0d444f6b..ec784756dc65 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c | |||
@@ -666,6 +666,6 @@ not_empty: | |||
666 | const struct file_operations ufs_dir_operations = { | 666 | const struct file_operations ufs_dir_operations = { |
667 | .read = generic_read_dir, | 667 | .read = generic_read_dir, |
668 | .readdir = ufs_readdir, | 668 | .readdir = ufs_readdir, |
669 | .fsync = simple_fsync, | 669 | .fsync = generic_file_fsync, |
670 | .llseek = generic_file_llseek, | 670 | .llseek = generic_file_llseek, |
671 | }; | 671 | }; |
diff --git a/fs/ufs/file.c b/fs/ufs/file.c index a8962cecde5b..d4c30d1bef86 100644 --- a/fs/ufs/file.c +++ b/fs/ufs/file.c | |||
@@ -42,6 +42,6 @@ const struct file_operations ufs_file_operations = { | |||
42 | .aio_write = generic_file_aio_write, | 42 | .aio_write = generic_file_aio_write, |
43 | .mmap = generic_file_mmap, | 43 | .mmap = generic_file_mmap, |
44 | .open = dquot_file_open, | 44 | .open = dquot_file_open, |
45 | .fsync = simple_fsync, | 45 | .fsync = generic_file_fsync, |
46 | .splice_read = generic_file_splice_read, | 46 | .splice_read = generic_file_splice_read, |
47 | }; | 47 | }; |