diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/ufs | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ufs')
-rw-r--r-- | fs/ufs/super.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/ufs/super.c b/fs/ufs/super.c index 74afb9fbf58e..2b4d2b6234df 100644 --- a/fs/ufs/super.c +++ b/fs/ufs/super.c | |||
@@ -594,6 +594,9 @@ static void ufs_put_super_internal(struct super_block *sb) | |||
594 | 594 | ||
595 | 595 | ||
596 | UFSD("ENTER\n"); | 596 | UFSD("ENTER\n"); |
597 | |||
598 | lock_kernel(); | ||
599 | |||
597 | ufs_put_cstotal(sb); | 600 | ufs_put_cstotal(sb); |
598 | size = uspi->s_cssize; | 601 | size = uspi->s_cssize; |
599 | blks = (size + uspi->s_fsize - 1) >> uspi->s_fshift; | 602 | blks = (size + uspi->s_fsize - 1) >> uspi->s_fshift; |
@@ -621,6 +624,9 @@ static void ufs_put_super_internal(struct super_block *sb) | |||
621 | brelse (sbi->s_ucg[i]); | 624 | brelse (sbi->s_ucg[i]); |
622 | kfree (sbi->s_ucg); | 625 | kfree (sbi->s_ucg); |
623 | kfree (base); | 626 | kfree (base); |
627 | |||
628 | unlock_kernel(); | ||
629 | |||
624 | UFSD("EXIT\n"); | 630 | UFSD("EXIT\n"); |
625 | } | 631 | } |
626 | 632 | ||