aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ufs/super.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2009-05-11 17:35:03 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2009-06-11 21:36:09 -0400
commitebc1ac164560a241d9bf1b7519062910c3f90a01 (patch)
treedb17fd3043b15f8269cce2c2d00213814022fc30 /fs/ufs/super.c
parent01ba687577647beef6c5f2ea59bfb56fac9fcde2 (diff)
->write_super lock_super pushdown
Push down lock_super into ->write_super instances and remove it from the caller. Following filesystem don't need ->s_lock in ->write_super and are skipped: * bfs, nilfs2 - no other uses of s_lock and have internal locks in ->write_super * ext2 - uses BKL in ext2_write_super and has internal calls without s_lock * reiserfs - no other uses of s_lock as has reiserfs_write_lock (BKL) in ->write_super * xfs - no other uses of s_lock and uses internal lock (buffer lock on superblock buffer) to serialize ->write_super. Also xfs_fs_write_super is superflous and will go away in the next merge window Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/ufs/super.c')
-rw-r--r--fs/ufs/super.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ufs/super.c b/fs/ufs/super.c
index a5ecabfdc976..c97210ee0670 100644
--- a/fs/ufs/super.c
+++ b/fs/ufs/super.c
@@ -1131,6 +1131,7 @@ static void ufs_write_super(struct super_block *sb)
1131 struct ufs_super_block_third * usb3; 1131 struct ufs_super_block_third * usb3;
1132 unsigned flags; 1132 unsigned flags;
1133 1133
1134 lock_super(sb);
1134 lock_kernel(); 1135 lock_kernel();
1135 UFSD("ENTER\n"); 1136 UFSD("ENTER\n");
1136 flags = UFS_SB(sb)->s_flags; 1137 flags = UFS_SB(sb)->s_flags;
@@ -1150,6 +1151,7 @@ static void ufs_write_super(struct super_block *sb)
1150 sb->s_dirt = 0; 1151 sb->s_dirt = 0;
1151 UFSD("EXIT\n"); 1152 UFSD("EXIT\n");
1152 unlock_kernel(); 1153 unlock_kernel();
1154 unlock_super(sb);
1153} 1155}
1154 1156
1155static void ufs_put_super(struct super_block *sb) 1157static void ufs_put_super(struct super_block *sb)