aboutsummaryrefslogtreecommitdiffstats
path: root/fs/udf
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-18 11:17:46 -0500
committerJan Kara <jack@suse.cz>2014-11-19 15:55:45 -0500
commit0d454e4a443178863f858cdafac870ceb1989407 (patch)
tree7dfb38bffe7efbbf049d13eeee861da425e1e221 /fs/udf
parent11cc9f56a18d371634d07b1be7e8772f6f7dcec5 (diff)
udf: Deletion of unnecessary checks before the function call "iput"
The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/udf')
-rw-r--r--fs/udf/super.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/udf/super.c b/fs/udf/super.c
index e229315bbf7a..f93c65d6c7d9 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -2237,8 +2237,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
2237 return 0; 2237 return 0;
2238 2238
2239error_out: 2239error_out:
2240 if (sbi->s_vat_inode) 2240 iput(sbi->s_vat_inode);
2241 iput(sbi->s_vat_inode);
2242#ifdef CONFIG_UDF_NLS 2241#ifdef CONFIG_UDF_NLS
2243 if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) 2242 if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
2244 unload_nls(sbi->s_nls_map); 2243 unload_nls(sbi->s_nls_map);
@@ -2291,8 +2290,7 @@ static void udf_put_super(struct super_block *sb)
2291 2290
2292 sbi = UDF_SB(sb); 2291 sbi = UDF_SB(sb);
2293 2292
2294 if (sbi->s_vat_inode) 2293 iput(sbi->s_vat_inode);
2295 iput(sbi->s_vat_inode);
2296#ifdef CONFIG_UDF_NLS 2294#ifdef CONFIG_UDF_NLS
2297 if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP)) 2295 if (UDF_QUERY_FLAG(sb, UDF_FLAG_NLS_MAP))
2298 unload_nls(sbi->s_nls_map); 2296 unload_nls(sbi->s_nls_map);