aboutsummaryrefslogtreecommitdiffstats
path: root/fs/udf/super.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2009-05-05 09:40:36 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2009-06-11 21:36:07 -0400
commit6cfd0148425e528b859b26e436b01f23f6926224 (patch)
tree60e3257053554ff198fe5825e6f12a00c3b4422a /fs/udf/super.c
parenta9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff)
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of filesystems had trivial enough ->put_super (only kfree and NULLing of s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs, hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most of them probably don't need it, but I'd rather sort that out individually. Preferably after all the other BKL pushdowns in that area. [AV: original used to move lock_super() down as well; these changes are removed since we don't do lock_super() at all in generic_shutdown_super() now] [AV: fuse, btrfs and xfs are known to need no damn BKL, exempt] Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/udf/super.c')
-rw-r--r--fs/udf/super.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/udf/super.c b/fs/udf/super.c
index 0ba44107d8f1..04802cc39b18 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -2062,6 +2062,9 @@ static void udf_put_super(struct super_block *sb)
2062 struct udf_sb_info *sbi; 2062 struct udf_sb_info *sbi;
2063 2063
2064 sbi = UDF_SB(sb); 2064 sbi = UDF_SB(sb);
2065
2066 lock_kernel();
2067
2065 if (sbi->s_vat_inode) 2068 if (sbi->s_vat_inode)
2066 iput(sbi->s_vat_inode); 2069 iput(sbi->s_vat_inode);
2067 if (sbi->s_partitions) 2070 if (sbi->s_partitions)
@@ -2077,6 +2080,8 @@ static void udf_put_super(struct super_block *sb)
2077 kfree(sbi->s_partmaps); 2080 kfree(sbi->s_partmaps);
2078 kfree(sb->s_fs_info); 2081 kfree(sb->s_fs_info);
2079 sb->s_fs_info = NULL; 2082 sb->s_fs_info = NULL;
2083
2084 unlock_kernel();
2080} 2085}
2081 2086
2082static int udf_sync_fs(struct super_block *sb, int wait) 2087static int udf_sync_fs(struct super_block *sb, int wait)