aboutsummaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorJulien Brunel <brunel@diku.dk>2008-08-29 05:08:32 -0400
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2008-09-30 04:12:56 -0400
commita70948b564e9f6cb81115c606d46f5b74a77b7c2 (patch)
treee1a75ccf9580746d22409430b346436fd148dab7 /fs/ubifs
parent746103aca2ae2b044e32a6ab06a6536652124c99 (diff)
UBIFS: use an IS_ERR test rather than a NULL test
In case of error, the function kthread_create returns an ERR pointer, but never returns a NULL pointer. So a NULL test that comes before an IS_ERR test should be deleted. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @match_bad_null_test@ expression x, E; statement S1,S2; @@ x = kthread_create(...) ... when != x = E * if (x == NULL) S1 else S2 // </smpl> Signed-off-by: Julien Brunel <brunel@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/super.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 667c72d8a5cc..d87b0cf5f661 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1032,8 +1032,6 @@ static int mount_ubifs(struct ubifs_info *c)
1032 1032
1033 /* Create background thread */ 1033 /* Create background thread */
1034 c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name); 1034 c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name);
1035 if (!c->bgt)
1036 c->bgt = ERR_PTR(-EINVAL);
1037 if (IS_ERR(c->bgt)) { 1035 if (IS_ERR(c->bgt)) {
1038 err = PTR_ERR(c->bgt); 1036 err = PTR_ERR(c->bgt);
1039 c->bgt = NULL; 1037 c->bgt = NULL;
@@ -1347,8 +1345,6 @@ static int ubifs_remount_rw(struct ubifs_info *c)
1347 1345
1348 /* Create background thread */ 1346 /* Create background thread */
1349 c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name); 1347 c->bgt = kthread_create(ubifs_bg_thread, c, c->bgt_name);
1350 if (!c->bgt)
1351 c->bgt = ERR_PTR(-EINVAL);
1352 if (IS_ERR(c->bgt)) { 1348 if (IS_ERR(c->bgt)) {
1353 err = PTR_ERR(c->bgt); 1349 err = PTR_ERR(c->bgt);
1354 c->bgt = NULL; 1350 c->bgt = NULL;