aboutsummaryrefslogtreecommitdiffstats
path: root/fs/sysv
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2009-05-11 17:35:03 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2009-06-11 21:36:09 -0400
commitebc1ac164560a241d9bf1b7519062910c3f90a01 (patch)
treedb17fd3043b15f8269cce2c2d00213814022fc30 /fs/sysv
parent01ba687577647beef6c5f2ea59bfb56fac9fcde2 (diff)
->write_super lock_super pushdown
Push down lock_super into ->write_super instances and remove it from the caller. Following filesystem don't need ->s_lock in ->write_super and are skipped: * bfs, nilfs2 - no other uses of s_lock and have internal locks in ->write_super * ext2 - uses BKL in ext2_write_super and has internal calls without s_lock * reiserfs - no other uses of s_lock as has reiserfs_write_lock (BKL) in ->write_super * xfs - no other uses of s_lock and uses internal lock (buffer lock on superblock buffer) to serialize ->write_super. Also xfs_fs_write_super is superflous and will go away in the next merge window Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/sysv')
-rw-r--r--fs/sysv/inode.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
index e0a39f1fb88e..a3f45fc626a1 100644
--- a/fs/sysv/inode.c
+++ b/fs/sysv/inode.c
@@ -37,6 +37,7 @@ static void sysv_write_super(struct super_block *sb)
37 struct sysv_sb_info *sbi = SYSV_SB(sb); 37 struct sysv_sb_info *sbi = SYSV_SB(sb);
38 unsigned long time = get_seconds(), old_time; 38 unsigned long time = get_seconds(), old_time;
39 39
40 lock_super(sb);
40 lock_kernel(); 41 lock_kernel();
41 if (sb->s_flags & MS_RDONLY) 42 if (sb->s_flags & MS_RDONLY)
42 goto clean; 43 goto clean;
@@ -56,6 +57,7 @@ static void sysv_write_super(struct super_block *sb)
56clean: 57clean:
57 sb->s_dirt = 0; 58 sb->s_dirt = 0;
58 unlock_kernel(); 59 unlock_kernel();
60 unlock_super(sb);
59} 61}
60 62
61static int sysv_remount(struct super_block *sb, int *flags, char *data) 63static int sysv_remount(struct super_block *sb, int *flags, char *data)