diff options
author | Christoph Hellwig <hch@lst.de> | 2009-05-05 09:40:36 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2009-06-11 21:36:07 -0400 |
commit | 6cfd0148425e528b859b26e436b01f23f6926224 (patch) | |
tree | 60e3257053554ff198fe5825e6f12a00c3b4422a /fs/sysv/inode.c | |
parent | a9e220f8322e2b0e0b8903fe00265461cffad3f0 (diff) |
push BKL down into ->put_super
Move BKL into ->put_super from the only caller. A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment. Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.
[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/sysv/inode.c')
-rw-r--r-- | fs/sysv/inode.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c index cd80316302cc..a8189864c241 100644 --- a/fs/sysv/inode.c +++ b/fs/sysv/inode.c | |||
@@ -72,6 +72,8 @@ static void sysv_put_super(struct super_block *sb) | |||
72 | { | 72 | { |
73 | struct sysv_sb_info *sbi = SYSV_SB(sb); | 73 | struct sysv_sb_info *sbi = SYSV_SB(sb); |
74 | 74 | ||
75 | lock_kernel(); | ||
76 | |||
75 | if (sb->s_dirt) | 77 | if (sb->s_dirt) |
76 | sysv_write_super(sb); | 78 | sysv_write_super(sb); |
77 | 79 | ||
@@ -87,6 +89,8 @@ static void sysv_put_super(struct super_block *sb) | |||
87 | brelse(sbi->s_bh2); | 89 | brelse(sbi->s_bh2); |
88 | 90 | ||
89 | kfree(sbi); | 91 | kfree(sbi); |
92 | |||
93 | unlock_kernel(); | ||
90 | } | 94 | } |
91 | 95 | ||
92 | static int sysv_statfs(struct dentry *dentry, struct kstatfs *buf) | 96 | static int sysv_statfs(struct dentry *dentry, struct kstatfs *buf) |