diff options
author | Arjan van de Ven <arjan@linux.intel.com> | 2008-07-25 22:45:41 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-26 15:00:07 -0400 |
commit | 99fcd77d15357e8ba51005c25cc750b9c28b2688 (patch) | |
tree | 403293819dc7bcd854c50d8c486a1fdbbf9711a2 /fs/sysfs/group.c | |
parent | 5c752ad9f35910ff1912b3f3ae82878178ddc432 (diff) |
Use WARN() in fs/sysfs
Use WARN() instead of a printk+WARN_ON() pair; this way the message becomes
part of the warning section for better reporting/collection. Also, with this,
one fo the if() sections collapses entirely into the WARN().
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/sysfs/group.c')
-rw-r--r-- | fs/sysfs/group.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index eeba38417b1d..fe611949a7f7 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c | |||
@@ -134,9 +134,8 @@ void sysfs_remove_group(struct kobject * kobj, | |||
134 | if (grp->name) { | 134 | if (grp->name) { |
135 | sd = sysfs_get_dirent(dir_sd, grp->name); | 135 | sd = sysfs_get_dirent(dir_sd, grp->name); |
136 | if (!sd) { | 136 | if (!sd) { |
137 | printk(KERN_WARNING "sysfs group %p not found for " | 137 | WARN(!sd, KERN_WARNING "sysfs group %p not found for " |
138 | "kobject '%s'\n", grp, kobject_name(kobj)); | 138 | "kobject '%s'\n", grp, kobject_name(kobj)); |
139 | WARN_ON(!sd); | ||
140 | return; | 139 | return; |
141 | } | 140 | } |
142 | } else | 141 | } else |