sysfs: kill unnecessary sysfs_get() in open paths

There's no reason to get an extra reference to sysfs_dirent for an
open file.  Open file has a reference to the dentry which in turn has
a reference to sysfs_dirent.  This is fairly obvious as otherwise open
itself won't be able to access the sysfs_dirent.  Kill the extra
sysfs_get() and matching sysfs_put().

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 1 insertions, 3 deletions

diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c
index a819a7e8d74d..e93fe5e2fa41 100644
--- a/fs/sysfs/bin.c
+++ b/fs/sysfs/bin.c
@@ -193,9 +193,8 @@ static int open(struct inode * inode, struct file * file)
         mutex_init(&bb->mutex);
         file->private_data = bb;
 
-        /* open succeeded, put active reference and pin attr_sd */
+        /* open succeeded, put active reference */
         sysfs_put_active(attr_sd);
-        sysfs_get(attr_sd);
         return 0;
 
  err_out:
@@ -211,7 +210,6 @@ static int release(struct inode * inode, struct file * file)
 
         if (bb->mmapped)
                 sysfs_put_active_two(attr_sd);
-        sysfs_put(attr_sd);
         kfree(bb->buffer);
         kfree(bb);
         return 0;