diff options
author | Phillip Lougher <phillip@lougher.demon.co.uk> | 2011-05-23 23:15:21 -0400 |
---|---|---|
committer | Phillip Lougher <phillip@lougher.demon.co.uk> | 2011-05-25 13:21:32 -0400 |
commit | ac51a0a7139aa93bf1176b701c86fa3d2bdf6106 (patch) | |
tree | 776d75b5cd1712d43feecc698b855173ed6ee57f /fs/squashfs/super.c | |
parent | 37986f63c81bf23c856f65fc5e4830550e7f3d5b (diff) |
Squashfs: add sanity checks to lookup table reading at mount time
Fsfuzzer generates corrupted filesystems which throw a warn_on in
kmalloc. One of these is due to a corrupted superblock inodes field.
Fix this by checking that the number of bytes to be read (and allocated)
does not extend into the next filesystem structure.
Also add a couple of other sanity checks of the mount-time lookup table
structures.
Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk>
Diffstat (limited to 'fs/squashfs/super.c')
-rw-r--r-- | fs/squashfs/super.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/squashfs/super.c b/fs/squashfs/super.c index 8f5f2781a60e..80a7119870a6 100644 --- a/fs/squashfs/super.c +++ b/fs/squashfs/super.c | |||
@@ -245,6 +245,7 @@ allocate_id_index_table: | |||
245 | msblk->id_table = NULL; | 245 | msblk->id_table = NULL; |
246 | goto failed_mount; | 246 | goto failed_mount; |
247 | } | 247 | } |
248 | next_table = msblk->id_table[0]; | ||
248 | 249 | ||
249 | /* Handle inode lookup table */ | 250 | /* Handle inode lookup table */ |
250 | lookup_table_start = le64_to_cpu(sblk->lookup_table_start); | 251 | lookup_table_start = le64_to_cpu(sblk->lookup_table_start); |
@@ -253,7 +254,7 @@ allocate_id_index_table: | |||
253 | 254 | ||
254 | /* Allocate and read inode lookup table */ | 255 | /* Allocate and read inode lookup table */ |
255 | msblk->inode_lookup_table = squashfs_read_inode_lookup_table(sb, | 256 | msblk->inode_lookup_table = squashfs_read_inode_lookup_table(sb, |
256 | lookup_table_start, msblk->inodes); | 257 | lookup_table_start, next_table, msblk->inodes); |
257 | if (IS_ERR(msblk->inode_lookup_table)) { | 258 | if (IS_ERR(msblk->inode_lookup_table)) { |
258 | ERROR("unable to read inode lookup table\n"); | 259 | ERROR("unable to read inode lookup table\n"); |
259 | err = PTR_ERR(msblk->inode_lookup_table); | 260 | err = PTR_ERR(msblk->inode_lookup_table); |