diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-09-27 04:49:40 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:10 -0400 |
commit | 1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b (patch) | |
tree | fade83955f75e718e39153d6f81d221403338bed /fs/smbfs | |
parent | f52720ca5f48574e347dff35ffe6b389ace61537 (diff) |
[PATCH] Really ignore kmem_cache_destroy return value
* Rougly half of callers already do it by not checking return value
* Code in drivers/acpi/osl.c does the following to be sure:
(void)kmem_cache_destroy(cache);
* Those who check it printk something, however, slab_error already printed
the name of failed cache.
* XFS BUGs on failed kmem_cache_destroy which is not the decision
low-level filesystem driver should make. Converted to ignore.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/smbfs')
-rw-r--r-- | fs/smbfs/inode.c | 3 | ||||
-rw-r--r-- | fs/smbfs/request.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/fs/smbfs/inode.c b/fs/smbfs/inode.c index a1ed657c3c84..92cf60aa6121 100644 --- a/fs/smbfs/inode.c +++ b/fs/smbfs/inode.c | |||
@@ -89,8 +89,7 @@ static int init_inodecache(void) | |||
89 | 89 | ||
90 | static void destroy_inodecache(void) | 90 | static void destroy_inodecache(void) |
91 | { | 91 | { |
92 | if (kmem_cache_destroy(smb_inode_cachep)) | 92 | kmem_cache_destroy(smb_inode_cachep); |
93 | printk(KERN_INFO "smb_inode_cache: not all structures were freed\n"); | ||
94 | } | 93 | } |
95 | 94 | ||
96 | static int smb_remount(struct super_block *sb, int *flags, char *data) | 95 | static int smb_remount(struct super_block *sb, int *flags, char *data) |
diff --git a/fs/smbfs/request.c b/fs/smbfs/request.c index c8e96195b96e..0fb74697abc4 100644 --- a/fs/smbfs/request.c +++ b/fs/smbfs/request.c | |||
@@ -49,8 +49,7 @@ int smb_init_request_cache(void) | |||
49 | 49 | ||
50 | void smb_destroy_request_cache(void) | 50 | void smb_destroy_request_cache(void) |
51 | { | 51 | { |
52 | if (kmem_cache_destroy(req_cachep)) | 52 | kmem_cache_destroy(req_cachep); |
53 | printk(KERN_INFO "smb_destroy_request_cache: not all structures were freed\n"); | ||
54 | } | 53 | } |
55 | 54 | ||
56 | /* | 55 | /* |