diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2008-08-12 18:09:02 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-08-12 19:07:30 -0400 |
commit | 50ac2d694f2dd1658341cf97bcf2ffb836d772cb (patch) | |
tree | c4466ecb7c5211ee9423380783f00027411d5d5a /fs/seq_file.c | |
parent | dd763460eb628b57814251a15a39f8d75c044d76 (diff) |
seq_file: add seq_cpumask(), seq_nodemask()
Short enough reads from /proc/irq/*/smp_affinity return -EINVAL for no
good reason.
This became noticed with NR_CPUS=4096 patches, when length of printed
representation of cpumask becase 1152, but cat(1) continued to read with
1024-byte chunks. bitmap_scnprintf() in good faith fills buffer, returns
1023, check returns -EINVAL.
Fix it by switching to seq_file, so handler will just fill buffer and
doesn't care about offsets, length, filling EOF and all this crap.
For that add seq_bitmap(), and wrappers around it -- seq_cpumask() and
seq_nodemask().
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Reviewed-by: Paul Jackson <pj@sgi.com>
Cc: Mike Travis <travis@sgi.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/seq_file.c')
-rw-r--r-- | fs/seq_file.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/fs/seq_file.c b/fs/seq_file.c index 3f54dbd6c49b..5d54205e486b 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c | |||
@@ -443,6 +443,20 @@ int seq_dentry(struct seq_file *m, struct dentry *dentry, char *esc) | |||
443 | return -1; | 443 | return -1; |
444 | } | 444 | } |
445 | 445 | ||
446 | int seq_bitmap(struct seq_file *m, unsigned long *bits, unsigned int nr_bits) | ||
447 | { | ||
448 | size_t len = bitmap_scnprintf_len(nr_bits); | ||
449 | |||
450 | if (m->count + len < m->size) { | ||
451 | bitmap_scnprintf(m->buf + m->count, m->size - m->count, | ||
452 | bits, nr_bits); | ||
453 | m->count += len; | ||
454 | return 0; | ||
455 | } | ||
456 | m->count = m->size; | ||
457 | return -1; | ||
458 | } | ||
459 | |||
446 | static void *single_start(struct seq_file *p, loff_t *pos) | 460 | static void *single_start(struct seq_file *p, loff_t *pos) |
447 | { | 461 | { |
448 | return NULL + (*pos == 0); | 462 | return NULL + (*pos == 0); |