VFS: normal filesystems (and lustre): d_inode() annotations

that's the bulk of filesystem drivers dealing with inodes of their own

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

9 files changed, 87 insertions, 87 deletions

diff --git a/fs/reiserfs/dir.c b/fs/reiserfs/dir.c
index 0a7dc941aaf4..4a024e2ceb9f 100644
--- a/fs/reiserfs/dir.c
+++ b/fs/reiserfs/dir.c
@@ -53,8 +53,8 @@ static int reiserfs_dir_fsync(struct file *filp, loff_t start, loff_t end,
 static inline bool is_privroot_deh(struct inode *dir, struct reiserfs_de_head *deh)
 {
         struct dentry *privroot = REISERFS_SB(dir->i_sb)->priv_root;
-        return (privroot->d_inode &&
-                deh->deh_objectid == INODE_PKEY(privroot->d_inode)->k_objectid);
+        return (d_really_is_positive(privroot) &&
+                deh->deh_objectid == INODE_PKEY(d_inode(privroot))->k_objectid);
 }
 
 int reiserfs_readdir_inode(struct inode *inode, struct dir_context *ctx)
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
index 742242b60972..f6f2fbad9777 100644
--- a/fs/reiserfs/inode.c
+++ b/fs/reiserfs/inode.c
@@ -3308,7 +3308,7 @@ static ssize_t reiserfs_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
 
 int reiserfs_setattr(struct dentry *dentry, struct iattr *attr)
 {
-        struct inode *inode = dentry->d_inode;
+        struct inode *inode = d_inode(dentry);
         unsigned int ia_valid;
         int error;
 
diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c
index cd11358b10c7..b55a074653d7 100644
--- a/fs/reiserfs/namei.c
+++ b/fs/reiserfs/namei.c
@@ -400,7 +400,7 @@ struct dentry *reiserfs_get_parent(struct dentry *child)
         struct inode *inode = NULL;
         struct reiserfs_dir_entry de;
         INITIALIZE_PATH(path_to_entry);
-        struct inode *dir = child->d_inode;
+        struct inode *dir = d_inode(child);
 
         if (dir->i_nlink == 0) {
                 return ERR_PTR(-ENOENT);
@@ -917,7 +917,7 @@ static int reiserfs_rmdir(struct inode *dir, struct dentry *dentry)
                 goto end_rmdir;
         }
 
-        inode = dentry->d_inode;
+        inode = d_inode(dentry);
 
         reiserfs_update_inode_transaction(inode);
         reiserfs_update_inode_transaction(dir);
@@ -987,7 +987,7 @@ static int reiserfs_unlink(struct inode *dir, struct dentry *dentry)
 
         dquot_initialize(dir);
 
-        inode = dentry->d_inode;
+        inode = d_inode(dentry);
 
         /*
          * in this transaction we can be doing at max two balancings and
@@ -1174,7 +1174,7 @@ static int reiserfs_link(struct dentry *old_dentry, struct inode *dir,
                          struct dentry *dentry)
 {
         int retval;
-        struct inode *inode = old_dentry->d_inode;
+        struct inode *inode = d_inode(old_dentry);
         struct reiserfs_transaction_handle th;
         /*
          * We need blocks for transaction + update of quotas for
@@ -1311,8 +1311,8 @@ static int reiserfs_rename(struct inode *old_dir, struct dentry *old_dentry,
         dquot_initialize(old_dir);
         dquot_initialize(new_dir);
 
-        old_inode = old_dentry->d_inode;
-        new_dentry_inode = new_dentry->d_inode;
+        old_inode = d_inode(old_dentry);
+        new_dentry_inode = d_inode(new_dentry);
 
         /*
          * make sure that oldname still exists and points to an object we
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 71fbbe3e2dab..558ef2ce1bdd 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -1687,7 +1687,7 @@ static __u32 find_hash_out(struct super_block *s)
         __u32 hash = DEFAULT_HASH;
         __u32 deh_hashval, teahash, r5hash, yurahash;
 
-        inode = s->s_root->d_inode;
+        inode = d_inode(s->s_root);
 
         make_cpu_key(&key, inode, ~0, TYPE_DIRENTRY, 3);
         retval = search_by_entry_key(s, &key, &path, &de);
@@ -2347,7 +2347,7 @@ static int reiserfs_quota_on(struct super_block *sb, int type, int format_id,
                 err = -EXDEV;
                 goto out;
         }
-        inode = path->dentry->d_inode;
+        inode = d_inode(path->dentry);
         /*
          * We must not pack tails for quota files on reiserfs for quota
          * IO to work
diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c
index 4e781e697c90..e87f9b52bf06 100644
--- a/fs/reiserfs/xattr.c
+++ b/fs/reiserfs/xattr.c
@@ -87,9 +87,9 @@ static int xattr_unlink(struct inode *dir, struct dentry *dentry)
 
         BUG_ON(!mutex_is_locked(&dir->i_mutex));
 
-        mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_CHILD);
+        mutex_lock_nested(&d_inode(dentry)->i_mutex, I_MUTEX_CHILD);
         error = dir->i_op->unlink(dir, dentry);
-        mutex_unlock(&dentry->d_inode->i_mutex);
+        mutex_unlock(&d_inode(dentry)->i_mutex);
 
         if (!error)
                 d_delete(dentry);
@@ -102,11 +102,11 @@ static int xattr_rmdir(struct inode *dir, struct dentry *dentry)
 
         BUG_ON(!mutex_is_locked(&dir->i_mutex));
 
-        mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_CHILD);
+        mutex_lock_nested(&d_inode(dentry)->i_mutex, I_MUTEX_CHILD);
         error = dir->i_op->rmdir(dir, dentry);
         if (!error)
-                dentry->d_inode->i_flags |= S_DEAD;
-        mutex_unlock(&dentry->d_inode->i_mutex);
+                d_inode(dentry)->i_flags |= S_DEAD;
+        mutex_unlock(&d_inode(dentry)->i_mutex);
         if (!error)
                 d_delete(dentry);
 
@@ -120,26 +120,26 @@ static struct dentry *open_xa_root(struct super_block *sb, int flags)
         struct dentry *privroot = REISERFS_SB(sb)->priv_root;
         struct dentry *xaroot;
 
-        if (!privroot->d_inode)
+        if (d_really_is_negative(privroot))
                 return ERR_PTR(-ENODATA);
 
-        mutex_lock_nested(&privroot->d_inode->i_mutex, I_MUTEX_XATTR);
+        mutex_lock_nested(&d_inode(privroot)->i_mutex, I_MUTEX_XATTR);
 
         xaroot = dget(REISERFS_SB(sb)->xattr_root);
         if (!xaroot)
                 xaroot = ERR_PTR(-ENODATA);
-        else if (!xaroot->d_inode) {
+        else if (d_really_is_negative(xaroot)) {
                 int err = -ENODATA;
 
                 if (xattr_may_create(flags))
-                        err = xattr_mkdir(privroot->d_inode, xaroot, 0700);
+                        err = xattr_mkdir(d_inode(privroot), xaroot, 0700);
                 if (err) {
                         dput(xaroot);
                         xaroot = ERR_PTR(err);
                 }
         }
 
-        mutex_unlock(&privroot->d_inode->i_mutex);
+        mutex_unlock(&d_inode(privroot)->i_mutex);
         return xaroot;
 }
 
@@ -156,21 +156,21 @@ static struct dentry *open_xa_dir(const struct inode *inode, int flags)
                  le32_to_cpu(INODE_PKEY(inode)->k_objectid),
                  inode->i_generation);
 
-        mutex_lock_nested(&xaroot->d_inode->i_mutex, I_MUTEX_XATTR);
+        mutex_lock_nested(&d_inode(xaroot)->i_mutex, I_MUTEX_XATTR);
 
         xadir = lookup_one_len(namebuf, xaroot, strlen(namebuf));
-        if (!IS_ERR(xadir) && !xadir->d_inode) {
+        if (!IS_ERR(xadir) && d_really_is_negative(xadir)) {
                 int err = -ENODATA;
 
                 if (xattr_may_create(flags))
-                        err = xattr_mkdir(xaroot->d_inode, xadir, 0700);
+                        err = xattr_mkdir(d_inode(xaroot), xadir, 0700);
                 if (err) {
                         dput(xadir);
                         xadir = ERR_PTR(err);
                 }
         }
 
-        mutex_unlock(&xaroot->d_inode->i_mutex);
+        mutex_unlock(&d_inode(xaroot)->i_mutex);
         dput(xaroot);
         return xadir;
 }
@@ -195,7 +195,7 @@ fill_with_dentries(struct dir_context *ctx, const char *name, int namelen,
                 container_of(ctx, struct reiserfs_dentry_buf, ctx);
         struct dentry *dentry;
 
-        WARN_ON_ONCE(!mutex_is_locked(&dbuf->xadir->d_inode->i_mutex));
+        WARN_ON_ONCE(!mutex_is_locked(&d_inode(dbuf->xadir)->i_mutex));
 
         if (dbuf->count == ARRAY_SIZE(dbuf->dentries))
                 return -ENOSPC;
@@ -207,7 +207,7 @@ fill_with_dentries(struct dir_context *ctx, const char *name, int namelen,
         dentry = lookup_one_len(name, dbuf->xadir, namelen);
         if (IS_ERR(dentry)) {
                 return PTR_ERR(dentry);
-        } else if (!dentry->d_inode) {
+        } else if (d_really_is_negative(dentry)) {
                 /* A directory entry exists, but no file? */
                 reiserfs_error(dentry->d_sb, "xattr-20003",
                                "Corrupted directory: xattr %pd listed but "
@@ -249,16 +249,16 @@ static int reiserfs_for_each_xattr(struct inode *inode,
         if (IS_ERR(dir)) {
                 err = PTR_ERR(dir);
                 goto out;
-        } else if (!dir->d_inode) {
+        } else if (d_really_is_negative(dir)) {
                 err = 0;
                 goto out_dir;
         }
 
-        mutex_lock_nested(&dir->d_inode->i_mutex, I_MUTEX_XATTR);
+        mutex_lock_nested(&d_inode(dir)->i_mutex, I_MUTEX_XATTR);
 
         buf.xadir = dir;
         while (1) {
-                err = reiserfs_readdir_inode(dir->d_inode, &buf.ctx);
+                err = reiserfs_readdir_inode(d_inode(dir), &buf.ctx);
                 if (err)
                         break;
                 if (!buf.count)
@@ -276,7 +276,7 @@ static int reiserfs_for_each_xattr(struct inode *inode,
                         break;
                 buf.count = 0;
         }
-        mutex_unlock(&dir->d_inode->i_mutex);
+        mutex_unlock(&d_inode(dir)->i_mutex);
 
         cleanup_dentry_buf(&buf);
 
@@ -298,13 +298,13 @@ static int reiserfs_for_each_xattr(struct inode *inode,
                 if (!err) {
                         int jerror;
 
-                        mutex_lock_nested(&dir->d_parent->d_inode->i_mutex,
+                        mutex_lock_nested(&d_inode(dir->d_parent)->i_mutex,
                                           I_MUTEX_XATTR);
                         err = action(dir, data);
                         reiserfs_write_lock(inode->i_sb);
                         jerror = journal_end(&th);
                         reiserfs_write_unlock(inode->i_sb);
-                        mutex_unlock(&dir->d_parent->d_inode->i_mutex);
+                        mutex_unlock(&d_inode(dir->d_parent)->i_mutex);
                         err = jerror ?: err;
                 }
         }
@@ -319,7 +319,7 @@ out:
 
 static int delete_one_xattr(struct dentry *dentry, void *data)
 {
-        struct inode *dir = dentry->d_parent->d_inode;
+        struct inode *dir = d_inode(dentry->d_parent);
 
         /* This is the xattr dir, handle specially. */
         if (d_is_dir(dentry))
@@ -384,27 +384,27 @@ static struct dentry *xattr_lookup(struct inode *inode, const char *name,
         if (IS_ERR(xadir))
                 return ERR_CAST(xadir);
 
-        mutex_lock_nested(&xadir->d_inode->i_mutex, I_MUTEX_XATTR);
+        mutex_lock_nested(&d_inode(xadir)->i_mutex, I_MUTEX_XATTR);
         xafile = lookup_one_len(name, xadir, strlen(name));
         if (IS_ERR(xafile)) {
                 err = PTR_ERR(xafile);
                 goto out;
         }
 
-        if (xafile->d_inode && (flags & XATTR_CREATE))
+        if (d_really_is_positive(xafile) && (flags & XATTR_CREATE))
                 err = -EEXIST;
 
-        if (!xafile->d_inode) {
+        if (d_really_is_negative(xafile)) {
                 err = -ENODATA;
                 if (xattr_may_create(flags))
-                        err = xattr_create(xadir->d_inode, xafile,
+                        err = xattr_create(d_inode(xadir), xafile,
                                               0700|S_IFREG);
         }
 
         if (err)
                 dput(xafile);
 out:
-        mutex_unlock(&xadir->d_inode->i_mutex);
+        mutex_unlock(&d_inode(xadir)->i_mutex);
         dput(xadir);
         if (err)
                 return ERR_PTR(err);
@@ -469,21 +469,21 @@ static int lookup_and_delete_xattr(struct inode *inode, const char *name)
         if (IS_ERR(xadir))
                 return PTR_ERR(xadir);
 
-        mutex_lock_nested(&xadir->d_inode->i_mutex, I_MUTEX_XATTR);
+        mutex_lock_nested(&d_inode(xadir)->i_mutex, I_MUTEX_XATTR);
         dentry = lookup_one_len(name, xadir, strlen(name));
         if (IS_ERR(dentry)) {
                 err = PTR_ERR(dentry);
                 goto out_dput;
         }
 
-        if (dentry->d_inode) {
-                err = xattr_unlink(xadir->d_inode, dentry);
+        if (d_really_is_positive(dentry)) {
+                err = xattr_unlink(d_inode(xadir), dentry);
                 update_ctime(inode);
         }
 
         dput(dentry);
 out_dput:
-        mutex_unlock(&xadir->d_inode->i_mutex);
+        mutex_unlock(&d_inode(xadir)->i_mutex);
         dput(xadir);
         return err;
 }
@@ -533,7 +533,7 @@ reiserfs_xattr_set_handle(struct reiserfs_transaction_handle *th,
                 else
                         chunk = buffer_size - buffer_pos;
 
-                page = reiserfs_get_page(dentry->d_inode, file_pos);
+                page = reiserfs_get_page(d_inode(dentry), file_pos);
                 if (IS_ERR(page)) {
                         err = PTR_ERR(page);
                         goto out_unlock;
@@ -573,18 +573,18 @@ reiserfs_xattr_set_handle(struct reiserfs_transaction_handle *th,
         }
 
         new_size = buffer_size + sizeof(struct reiserfs_xattr_header);
-        if (!err && new_size < i_size_read(dentry->d_inode)) {
+        if (!err && new_size < i_size_read(d_inode(dentry))) {
                 struct iattr newattrs = {
                         .ia_ctime = current_fs_time(inode->i_sb),
                         .ia_size = new_size,
                         .ia_valid = ATTR_SIZE | ATTR_CTIME,
                 };
 
-                mutex_lock_nested(&dentry->d_inode->i_mutex, I_MUTEX_XATTR);
-                inode_dio_wait(dentry->d_inode);
+                mutex_lock_nested(&d_inode(dentry)->i_mutex, I_MUTEX_XATTR);
+                inode_dio_wait(d_inode(dentry));
 
                 err = reiserfs_setattr(dentry, &newattrs);
-                mutex_unlock(&dentry->d_inode->i_mutex);
+                mutex_unlock(&d_inode(dentry)->i_mutex);
         } else
                 update_ctime(inode);
 out_unlock:
@@ -657,7 +657,7 @@ reiserfs_xattr_get(struct inode *inode, const char *name, void *buffer,
 
         down_read(&REISERFS_I(inode)->i_xattr_sem);
 
-        isize = i_size_read(dentry->d_inode);
+        isize = i_size_read(d_inode(dentry));
 
         /* Just return the size needed */
         if (buffer == NULL) {
@@ -680,7 +680,7 @@ reiserfs_xattr_get(struct inode *inode, const char *name, void *buffer,
                 else
                         chunk = isize - file_pos;
 
-                page = reiserfs_get_page(dentry->d_inode, file_pos);
+                page = reiserfs_get_page(d_inode(dentry), file_pos);
                 if (IS_ERR(page)) {
                         err = PTR_ERR(page);
                         goto out_unlock;
@@ -775,7 +775,7 @@ reiserfs_getxattr(struct dentry * dentry, const char *name, void *buffer,
 
         handler = find_xattr_handler_prefix(dentry->d_sb->s_xattr, name);
 
-        if (!handler || get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
+        if (!handler || get_inode_sd_version(d_inode(dentry)) == STAT_DATA_V1)
                 return -EOPNOTSUPP;
 
         return handler->get(dentry, name, buffer, size, handler->flags);
@@ -784,7 +784,7 @@ reiserfs_getxattr(struct dentry * dentry, const char *name, void *buffer,
 /*
  * Inode operation setxattr()
  *
- * dentry->d_inode->i_mutex down
+ * d_inode(dentry)->i_mutex down
  */
 int
 reiserfs_setxattr(struct dentry *dentry, const char *name, const void *value,
@@ -794,7 +794,7 @@ reiserfs_setxattr(struct dentry *dentry, const char *name, const void *value,
 
         handler = find_xattr_handler_prefix(dentry->d_sb->s_xattr, name);
 
-        if (!handler || get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
+        if (!handler || get_inode_sd_version(d_inode(dentry)) == STAT_DATA_V1)
                 return -EOPNOTSUPP;
 
         return handler->set(dentry, name, value, size, flags, handler->flags);
@@ -803,7 +803,7 @@ reiserfs_setxattr(struct dentry *dentry, const char *name, const void *value,
 /*
  * Inode operation removexattr()
  *
- * dentry->d_inode->i_mutex down
+ * d_inode(dentry)->i_mutex down
  */
 int reiserfs_removexattr(struct dentry *dentry, const char *name)
 {
@@ -811,7 +811,7 @@ int reiserfs_removexattr(struct dentry *dentry, const char *name)
 
         handler = find_xattr_handler_prefix(dentry->d_sb->s_xattr, name);
 
-        if (!handler || get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
+        if (!handler || get_inode_sd_version(d_inode(dentry)) == STAT_DATA_V1)
                 return -EOPNOTSUPP;
 
         return handler->set(dentry, name, NULL, 0, XATTR_REPLACE, handler->flags);
@@ -875,14 +875,14 @@ ssize_t reiserfs_listxattr(struct dentry * dentry, char *buffer, size_t size)
                 .size = buffer ? size : 0,
         };
 
-        if (!dentry->d_inode)
+        if (d_really_is_negative(dentry))
                 return -EINVAL;
 
         if (!dentry->d_sb->s_xattr ||
-            get_inode_sd_version(dentry->d_inode) == STAT_DATA_V1)
+            get_inode_sd_version(d_inode(dentry)) == STAT_DATA_V1)
                 return -EOPNOTSUPP;
 
-        dir = open_xa_dir(dentry->d_inode, XATTR_REPLACE);
+        dir = open_xa_dir(d_inode(dentry), XATTR_REPLACE);
         if (IS_ERR(dir)) {
                 err = PTR_ERR(dir);
                 if (err == -ENODATA)
@@ -890,9 +890,9 @@ ssize_t reiserfs_listxattr(struct dentry * dentry, char *buffer, size_t size)
                 goto out;
         }
 
-        mutex_lock_nested(&dir->d_inode->i_mutex, I_MUTEX_XATTR);
-        err = reiserfs_readdir_inode(dir->d_inode, &buf.ctx);
-        mutex_unlock(&dir->d_inode->i_mutex);
+        mutex_lock_nested(&d_inode(dir)->i_mutex, I_MUTEX_XATTR);
+        err = reiserfs_readdir_inode(d_inode(dir), &buf.ctx);
+        mutex_unlock(&d_inode(dir)->i_mutex);
 
         if (!err)
                 err = buf.pos;
@@ -905,12 +905,12 @@ out:
 static int create_privroot(struct dentry *dentry)
 {
         int err;
-        struct inode *inode = dentry->d_parent->d_inode;
+        struct inode *inode = d_inode(dentry->d_parent);
 
         WARN_ON_ONCE(!mutex_is_locked(&inode->i_mutex));
 
         err = xattr_mkdir(inode, dentry, 0700);
-        if (err || !dentry->d_inode) {
+        if (err || d_really_is_negative(dentry)) {
                 reiserfs_warning(dentry->d_sb, "jdm-20006",
                                  "xattrs/ACLs enabled and couldn't "
                                  "find/create .reiserfs_priv. "
@@ -918,7 +918,7 @@ static int create_privroot(struct dentry *dentry)
                 return -EOPNOTSUPP;
         }
 
-        dentry->d_inode->i_flags |= S_PRIVATE;
+        d_inode(dentry)->i_flags |= S_PRIVATE;
         reiserfs_info(dentry->d_sb, "Created %s - reserved for xattr "
                       "storage.\n", PRIVROOT_NAME);
 
@@ -997,17 +997,17 @@ int reiserfs_lookup_privroot(struct super_block *s)
         int err = 0;
 
         /* If we don't have the privroot located yet - go find it */
-        mutex_lock(&s->s_root->d_inode->i_mutex);
+        mutex_lock(&d_inode(s->s_root)->i_mutex);
         dentry = lookup_one_len(PRIVROOT_NAME, s->s_root,
                                 strlen(PRIVROOT_NAME));
         if (!IS_ERR(dentry)) {
                 REISERFS_SB(s)->priv_root = dentry;
                 d_set_d_op(dentry, &xattr_lookup_poison_ops);
-                if (dentry->d_inode)
-                        dentry->d_inode->i_flags |= S_PRIVATE;
+                if (d_really_is_positive(dentry))
+                        d_inode(dentry)->i_flags |= S_PRIVATE;
         } else
                 err = PTR_ERR(dentry);
-        mutex_unlock(&s->s_root->d_inode->i_mutex);
+        mutex_unlock(&d_inode(s->s_root)->i_mutex);
 
         return err;
 }
@@ -1026,15 +1026,15 @@ int reiserfs_xattr_init(struct super_block *s, int mount_flags)
         if (err)
                 goto error;
 
-        if (!privroot->d_inode && !(mount_flags & MS_RDONLY)) {
-                mutex_lock(&s->s_root->d_inode->i_mutex);
+        if (d_really_is_negative(privroot) && !(mount_flags & MS_RDONLY)) {
+                mutex_lock(&d_inode(s->s_root)->i_mutex);
                 err = create_privroot(REISERFS_SB(s)->priv_root);
-                mutex_unlock(&s->s_root->d_inode->i_mutex);
+                mutex_unlock(&d_inode(s->s_root)->i_mutex);
         }
 
-        if (privroot->d_inode) {
+        if (d_really_is_positive(privroot)) {
                 s->s_xattr = reiserfs_xattr_handlers;
-                mutex_lock(&privroot->d_inode->i_mutex);
+                mutex_lock(&d_inode(privroot)->i_mutex);
                 if (!REISERFS_SB(s)->xattr_root) {
                         struct dentry *dentry;
 
@@ -1045,7 +1045,7 @@ int reiserfs_xattr_init(struct super_block *s, int mount_flags)
                         else
                                 err = PTR_ERR(dentry);
                 }
-                mutex_unlock(&privroot->d_inode->i_mutex);
+                mutex_unlock(&d_inode(privroot)->i_mutex);
         }
 
 error:
diff --git a/fs/reiserfs/xattr.h b/fs/reiserfs/xattr.h
index f620e9678dd5..15dde6262c00 100644
--- a/fs/reiserfs/xattr.h
+++ b/fs/reiserfs/xattr.h
@@ -78,7 +78,7 @@ static inline size_t reiserfs_xattr_jcreate_nblocks(struct inode *inode)
 
         if ((REISERFS_I(inode)->i_flags & i_has_xattr_dir) == 0) {
                 nblocks += JOURNAL_BLOCKS_PER_OBJECT(inode->i_sb);
-                if (!REISERFS_SB(inode->i_sb)->xattr_root->d_inode)
+                if (d_really_is_negative(REISERFS_SB(inode->i_sb)->xattr_root))
                         nblocks += JOURNAL_BLOCKS_PER_OBJECT(inode->i_sb);
         }
 
diff --git a/fs/reiserfs/xattr_security.c b/fs/reiserfs/xattr_security.c
index e7f8939a4cb5..9a3b0616f283 100644
--- a/fs/reiserfs/xattr_security.c
+++ b/fs/reiserfs/xattr_security.c
@@ -15,10 +15,10 @@ security_get(struct dentry *dentry, const char *name, void *buffer, size_t size,
         if (strlen(name) < sizeof(XATTR_SECURITY_PREFIX))
                 return -EINVAL;
 
-        if (IS_PRIVATE(dentry->d_inode))
+        if (IS_PRIVATE(d_inode(dentry)))
                 return -EPERM;
 
-        return reiserfs_xattr_get(dentry->d_inode, name, buffer, size);
+        return reiserfs_xattr_get(d_inode(dentry), name, buffer, size);
 }
 
 static int
@@ -28,10 +28,10 @@ security_set(struct dentry *dentry, const char *name, const void *buffer,
         if (strlen(name) < sizeof(XATTR_SECURITY_PREFIX))
                 return -EINVAL;
 
-        if (IS_PRIVATE(dentry->d_inode))
+        if (IS_PRIVATE(d_inode(dentry)))
                 return -EPERM;
 
-        return reiserfs_xattr_set(dentry->d_inode, name, buffer, size, flags);
+        return reiserfs_xattr_set(d_inode(dentry), name, buffer, size, flags);
 }
 
 static size_t security_list(struct dentry *dentry, char *list, size_t list_len,
@@ -39,7 +39,7 @@ static size_t security_list(struct dentry *dentry, char *list, size_t list_len,
 {
         const size_t len = namelen + 1;
 
-        if (IS_PRIVATE(dentry->d_inode))
+        if (IS_PRIVATE(d_inode(dentry)))
                 return 0;
 
         if (list && len <= list_len) {
diff --git a/fs/reiserfs/xattr_trusted.c b/fs/reiserfs/xattr_trusted.c
index 5eeb0c48ba46..e4f1343714e0 100644
--- a/fs/reiserfs/xattr_trusted.c
+++ b/fs/reiserfs/xattr_trusted.c
@@ -14,10 +14,10 @@ trusted_get(struct dentry *dentry, const char *name, void *buffer, size_t size,
         if (strlen(name) < sizeof(XATTR_TRUSTED_PREFIX))
                 return -EINVAL;
 
-        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(dentry->d_inode))
+        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(d_inode(dentry)))
                 return -EPERM;
 
-        return reiserfs_xattr_get(dentry->d_inode, name, buffer, size);
+        return reiserfs_xattr_get(d_inode(dentry), name, buffer, size);
 }
 
 static int
@@ -27,10 +27,10 @@ trusted_set(struct dentry *dentry, const char *name, const void *buffer,
         if (strlen(name) < sizeof(XATTR_TRUSTED_PREFIX))
                 return -EINVAL;
 
-        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(dentry->d_inode))
+        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(d_inode(dentry)))
                 return -EPERM;
 
-        return reiserfs_xattr_set(dentry->d_inode, name, buffer, size, flags);
+        return reiserfs_xattr_set(d_inode(dentry), name, buffer, size, flags);
 }
 
 static size_t trusted_list(struct dentry *dentry, char *list, size_t list_size,
@@ -38,7 +38,7 @@ static size_t trusted_list(struct dentry *dentry, char *list, size_t list_size,
 {
         const size_t len = name_len + 1;
 
-        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(dentry->d_inode))
+        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(d_inode(dentry)))
                 return 0;
 
         if (list && len <= list_size) {
diff --git a/fs/reiserfs/xattr_user.c b/fs/reiserfs/xattr_user.c
index e50eab046471..d0b08d3e5689 100644
--- a/fs/reiserfs/xattr_user.c
+++ b/fs/reiserfs/xattr_user.c
@@ -15,7 +15,7 @@ user_get(struct dentry *dentry, const char *name, void *buffer, size_t size,
                 return -EINVAL;
         if (!reiserfs_xattrs_user(dentry->d_sb))
                 return -EOPNOTSUPP;
-        return reiserfs_xattr_get(dentry->d_inode, name, buffer, size);
+        return reiserfs_xattr_get(d_inode(dentry), name, buffer, size);
 }
 
 static int
@@ -27,7 +27,7 @@ user_set(struct dentry *dentry, const char *name, const void *buffer,
 
         if (!reiserfs_xattrs_user(dentry->d_sb))
                 return -EOPNOTSUPP;
-        return reiserfs_xattr_set(dentry->d_inode, name, buffer, size, flags);
+        return reiserfs_xattr_set(d_inode(dentry), name, buffer, size, flags);
 }
 
 static size_t user_list(struct dentry *dentry, char *list, size_t list_size,