diff options
author | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2012-06-01 10:18:05 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-06-01 10:37:36 -0400 |
commit | 25729b0e94c2103a8d726eda843136a3775366cf (patch) | |
tree | b5858042ffb91144103a38b6be197cd54afa4d67 /fs/reiserfs | |
parent | efaa33eb1309d65528d5a54d87d69bdcbdae8c10 (diff) |
reiserfs: clean-up function return type
Turn 'reiserfs_flush_old_commits()' into a void function because the callers
do not cares about what it returns anyway.
We are going to remove the 'sb->s_dirt' field completely and this patch is a
small step towards this direction.
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/reiserfs')
-rw-r--r-- | fs/reiserfs/journal.c | 8 | ||||
-rw-r--r-- | fs/reiserfs/reiserfs.h | 2 |
2 files changed, 4 insertions, 6 deletions
diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index b1a08573fe14..68aea62ea61d 100644 --- a/fs/reiserfs/journal.c +++ b/fs/reiserfs/journal.c | |||
@@ -3492,7 +3492,7 @@ static void flush_async_commits(struct work_struct *work) | |||
3492 | ** flushes any old transactions to disk | 3492 | ** flushes any old transactions to disk |
3493 | ** ends the current transaction if it is too old | 3493 | ** ends the current transaction if it is too old |
3494 | */ | 3494 | */ |
3495 | int reiserfs_flush_old_commits(struct super_block *sb) | 3495 | void reiserfs_flush_old_commits(struct super_block *sb) |
3496 | { | 3496 | { |
3497 | time_t now; | 3497 | time_t now; |
3498 | struct reiserfs_transaction_handle th; | 3498 | struct reiserfs_transaction_handle th; |
@@ -3502,9 +3502,8 @@ int reiserfs_flush_old_commits(struct super_block *sb) | |||
3502 | /* safety check so we don't flush while we are replaying the log during | 3502 | /* safety check so we don't flush while we are replaying the log during |
3503 | * mount | 3503 | * mount |
3504 | */ | 3504 | */ |
3505 | if (list_empty(&journal->j_journal_list)) { | 3505 | if (list_empty(&journal->j_journal_list)) |
3506 | return 0; | 3506 | return; |
3507 | } | ||
3508 | 3507 | ||
3509 | /* check the current transaction. If there are no writers, and it is | 3508 | /* check the current transaction. If there are no writers, and it is |
3510 | * too old, finish it, and force the commit blocks to disk | 3509 | * too old, finish it, and force the commit blocks to disk |
@@ -3526,7 +3525,6 @@ int reiserfs_flush_old_commits(struct super_block *sb) | |||
3526 | do_journal_end(&th, sb, 1, COMMIT_NOW | WAIT); | 3525 | do_journal_end(&th, sb, 1, COMMIT_NOW | WAIT); |
3527 | } | 3526 | } |
3528 | } | 3527 | } |
3529 | return sb->s_dirt; | ||
3530 | } | 3528 | } |
3531 | 3529 | ||
3532 | /* | 3530 | /* |
diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h index 14a4f9dfb171..5c700550bb07 100644 --- a/fs/reiserfs/reiserfs.h +++ b/fs/reiserfs/reiserfs.h | |||
@@ -2452,7 +2452,7 @@ struct reiserfs_transaction_handle *reiserfs_persistent_transaction(struct | |||
2452 | int reiserfs_end_persistent_transaction(struct reiserfs_transaction_handle *); | 2452 | int reiserfs_end_persistent_transaction(struct reiserfs_transaction_handle *); |
2453 | int reiserfs_commit_page(struct inode *inode, struct page *page, | 2453 | int reiserfs_commit_page(struct inode *inode, struct page *page, |
2454 | unsigned from, unsigned to); | 2454 | unsigned from, unsigned to); |
2455 | int reiserfs_flush_old_commits(struct super_block *); | 2455 | void reiserfs_flush_old_commits(struct super_block *); |
2456 | int reiserfs_commit_for_inode(struct inode *); | 2456 | int reiserfs_commit_for_inode(struct inode *); |
2457 | int reiserfs_inode_needs_commit(struct inode *); | 2457 | int reiserfs_inode_needs_commit(struct inode *); |
2458 | void reiserfs_update_inode_transaction(struct inode *); | 2458 | void reiserfs_update_inode_transaction(struct inode *); |