reiserfs: use generic xattr handlers

Christoph Hellwig had asked me quite some time ago to port the reiserfs
xattrs to the generic xattr interface.

This patch replaces the reiserfs-specific xattr handling code with the
generic struct xattr_handler.

However, since reiserfs doesn't split the prefix and name when accessing
xattrs, it can't leverage generic_{set,get,list,remove}xattr without
needlessly reconstructing the name on the back end.

Update 7/26/07: Added missing dput() to deletion path.
Update 8/30/07: Added missing mark_inode_dirty when i_mode is used to
                represent an ACL and no previous ACL existed.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 11 insertions, 34 deletions

diff --git a/fs/reiserfs/xattr_trusted.c b/fs/reiserfs/xattr_trusted.c
index 076ad388d489..a865042f75e2 100644
--- a/fs/reiserfs/xattr_trusted.c
+++ b/fs/reiserfs/xattr_trusted.c
@@ -13,10 +13,7 @@ trusted_get(struct inode *inode, const char *name, void *buffer, size_t size)
         if (strlen(name) < sizeof(XATTR_TRUSTED_PREFIX))
                 return -EINVAL;
 
-        if (!reiserfs_xattrs(inode->i_sb))
-                return -EOPNOTSUPP;
-
-        if (!(capable(CAP_SYS_ADMIN) || IS_PRIVATE(inode)))
+        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(inode))
                 return -EPERM;
 
         return reiserfs_xattr_get(inode, name, buffer, size);
@@ -29,50 +26,30 @@ trusted_set(struct inode *inode, const char *name, const void *buffer,
         if (strlen(name) < sizeof(XATTR_TRUSTED_PREFIX))
                 return -EINVAL;
 
-        if (!reiserfs_xattrs(inode->i_sb))
-                return -EOPNOTSUPP;
-
-        if (!(capable(CAP_SYS_ADMIN) || IS_PRIVATE(inode)))
+        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(inode))
                 return -EPERM;
 
         return reiserfs_xattr_set(inode, name, buffer, size, flags);
 }
 
-static int trusted_del(struct inode *inode, const char *name)
+static size_t trusted_list(struct inode *inode, char *list, size_t list_size,
+                           const char *name, size_t name_len)
 {
-        if (strlen(name) < sizeof(XATTR_TRUSTED_PREFIX))
-                return -EINVAL;
+        const size_t len = name_len + 1;
 
-        if (!reiserfs_xattrs(inode->i_sb))
-                return -EOPNOTSUPP;
-
-        if (!(capable(CAP_SYS_ADMIN) || IS_PRIVATE(inode)))
-                return -EPERM;
-
-        return 0;
-}
-
-static int
-trusted_list(struct inode *inode, const char *name, int namelen, char *out)
-{
-        int len = namelen;
-
-        if (!reiserfs_xattrs(inode->i_sb))
+        if (!capable(CAP_SYS_ADMIN) || IS_PRIVATE(inode))
                 return 0;
 
-        if (!(capable(CAP_SYS_ADMIN) || IS_PRIVATE(inode)))
-                return 0;
-
-        if (out)
-                memcpy(out, name, len);
-
+        if (list && len <= list_size) {
+                memcpy(list, name, name_len);
+                list[name_len] = '\0';
+        }
         return len;
 }
 
-struct reiserfs_xattr_handler trusted_handler = {
+struct xattr_handler reiserfs_xattr_trusted_handler = {
         .prefix = XATTR_TRUSTED_PREFIX,
         .get = trusted_get,
         .set = trusted_set,
-        .del = trusted_del,
         .list = trusted_list,
 };