reiserfs: rework reiserfs_warning

ReiserFS warnings can be somewhat inconsistent.
In some cases:
 * a unique identifier may be associated with it
 * the function name may be included
 * the device may be printed separately

This patch aims to make warnings more consistent. reiserfs_warning() prints
the device name, so printing it a second time is not required. The function
name for a warning is always helpful in debugging, so it is now automatically
inserted into the output. Hans has stated that every warning should have
a unique identifier. Some cases lack them, others really shouldn't have them.
reiserfs_warning() now expects an id associated with each message. In the
rare case where one isn't needed, "" will suffice.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 2 insertions, 3 deletions

diff --git a/fs/reiserfs/procfs.c b/fs/reiserfs/procfs.c
index 370988efc8ad..d4d7f1433ed0 100644
--- a/fs/reiserfs/procfs.c
+++ b/fs/reiserfs/procfs.c
@@ -503,7 +503,7 @@ int reiserfs_proc_info_init(struct super_block *sb)
                 add_file(sb, "journal", show_journal);
                 return 0;
         }
-        reiserfs_warning(sb, "reiserfs: cannot create /proc/%s/%s",
+        reiserfs_warning(sb, "cannot create /proc/%s/%s",
                          proc_info_root_name, b);
         return 1;
 }
@@ -559,8 +559,7 @@ int reiserfs_proc_info_global_init(void)
                 if (proc_info_root) {
                         proc_info_root->owner = THIS_MODULE;
                 } else {
-                        reiserfs_warning(NULL,
-                                         "reiserfs: cannot create /proc/%s",
+                        reiserfs_warning(NULL, "cannot create /proc/%s",
                                          proc_info_root_name);
                         return 1;
                 }