reiserfs: rework reiserfs_warning

ReiserFS warnings can be somewhat inconsistent.
In some cases:
 * a unique identifier may be associated with it
 * the function name may be included
 * the device may be printed separately

This patch aims to make warnings more consistent. reiserfs_warning() prints
the device name, so printing it a second time is not required. The function
name for a warning is always helpful in debugging, so it is now automatically
inserted into the output. Hans has stated that every warning should have
a unique identifier. Some cases lack them, others really shouldn't have them.
reiserfs_warning() now expects an id associated with each message. In the
rare case where one isn't needed, "" will suffice.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 32 insertions, 28 deletions

diff --git a/fs/reiserfs/item_ops.c b/fs/reiserfs/item_ops.c
index 9475557ab499..8a11cf39f57b 100644
--- a/fs/reiserfs/item_ops.c
+++ b/fs/reiserfs/item_ops.c
@@ -97,7 +97,8 @@ static int sd_unit_num(struct virtual_item *vi)
 
 static void sd_print_vi(struct virtual_item *vi)
 {
-        reiserfs_warning(NULL, "STATDATA, index %d, type 0x%x, %h",
+        reiserfs_warning(NULL, "reiserfs-16100",
+                         "STATDATA, index %d, type 0x%x, %h",
                          vi->vi_index, vi->vi_type, vi->vi_ih);
 }
 
@@ -190,7 +191,8 @@ static int direct_unit_num(struct virtual_item *vi)
 
 static void direct_print_vi(struct virtual_item *vi)
 {
-        reiserfs_warning(NULL, "DIRECT, index %d, type 0x%x, %h",
+        reiserfs_warning(NULL, "reiserfs-16101",
+                         "DIRECT, index %d, type 0x%x, %h",
                          vi->vi_index, vi->vi_type, vi->vi_ih);
 }
 
@@ -278,7 +280,7 @@ static void indirect_print_item(struct item_head *ih, char *item)
         unp = (__le32 *) item;
 
         if (ih_item_len(ih) % UNFM_P_SIZE)
-                reiserfs_warning(NULL, "indirect_print_item: invalid item len");
+                reiserfs_warning(NULL, "reiserfs-16102", "invalid item len");
 
         printk("%d pointers\n[ ", (int)I_UNFM_NUM(ih));
         for (j = 0; j < I_UNFM_NUM(ih); j++) {
@@ -334,7 +336,8 @@ static int indirect_unit_num(struct virtual_item *vi)
 
 static void indirect_print_vi(struct virtual_item *vi)
 {
-        reiserfs_warning(NULL, "INDIRECT, index %d, type 0x%x, %h",
+        reiserfs_warning(NULL, "reiserfs-16103",
+                         "INDIRECT, index %d, type 0x%x, %h",
                          vi->vi_index, vi->vi_type, vi->vi_ih);
 }
 
@@ -359,7 +362,7 @@ static struct item_operations indirect_ops = {
 
 static int direntry_bytes_number(struct item_head *ih, int block_size)
 {
-        reiserfs_warning(NULL, "vs-16090: direntry_bytes_number: "
+        reiserfs_warning(NULL, "vs-16090",
                          "bytes number is asked for direntry");
         return 0;
 }
@@ -614,7 +617,8 @@ static void direntry_print_vi(struct virtual_item *vi)
         int i;
         struct direntry_uarea *dir_u = vi->vi_uarea;
 
-        reiserfs_warning(NULL, "DIRENTRY, index %d, type 0x%x, %h, flags 0x%x",
+        reiserfs_warning(NULL, "reiserfs-16104",
+                         "DIRENTRY, index %d, type 0x%x, %h, flags 0x%x",
                          vi->vi_index, vi->vi_type, vi->vi_ih, dir_u->flags);
         printk("%d entries: ", dir_u->entry_count);
         for (i = 0; i < dir_u->entry_count; i++)
@@ -642,43 +646,43 @@ static struct item_operations direntry_ops = {
 //
 static int errcatch_bytes_number(struct item_head *ih, int block_size)
 {
-        reiserfs_warning(NULL,
-                         "green-16001: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16001",
+                         "Invalid item type observed, run fsck ASAP");
         return 0;
 }
 
 static void errcatch_decrement_key(struct cpu_key *key)
 {
-        reiserfs_warning(NULL,
-                         "green-16002: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16002",
+                         "Invalid item type observed, run fsck ASAP");
 }
 
 static int errcatch_is_left_mergeable(struct reiserfs_key *key,
                                       unsigned long bsize)
 {
-        reiserfs_warning(NULL,
-                         "green-16003: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16003",
+                         "Invalid item type observed, run fsck ASAP");
         return 0;
 }
 
 static void errcatch_print_item(struct item_head *ih, char *item)
 {
-        reiserfs_warning(NULL,
-                         "green-16004: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16004",
+                         "Invalid item type observed, run fsck ASAP");
 }
 
 static void errcatch_check_item(struct item_head *ih, char *item)
 {
-        reiserfs_warning(NULL,
-                         "green-16005: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16005",
+                         "Invalid item type observed, run fsck ASAP");
 }
 
 static int errcatch_create_vi(struct virtual_node *vn,
                               struct virtual_item *vi,
                               int is_affected, int insert_size)
 {
-        reiserfs_warning(NULL,
-                         "green-16006: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16006",
+                         "Invalid item type observed, run fsck ASAP");
         return 0;               // We might return -1 here as well, but it won't help as create_virtual_node() from where
         // this operation is called from is of return type void.
 }
@@ -686,36 +690,36 @@ static int errcatch_create_vi(struct virtual_node *vn,
 static int errcatch_check_left(struct virtual_item *vi, int free,
                                int start_skip, int end_skip)
 {
-        reiserfs_warning(NULL,
-                         "green-16007: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16007",
+                         "Invalid item type observed, run fsck ASAP");
         return -1;
 }
 
 static int errcatch_check_right(struct virtual_item *vi, int free)
 {
-        reiserfs_warning(NULL,
-                         "green-16008: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16008",
+                         "Invalid item type observed, run fsck ASAP");
         return -1;
 }
 
 static int errcatch_part_size(struct virtual_item *vi, int first, int count)
 {
-        reiserfs_warning(NULL,
-                         "green-16009: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16009",
+                         "Invalid item type observed, run fsck ASAP");
         return 0;
 }
 
 static int errcatch_unit_num(struct virtual_item *vi)
 {
-        reiserfs_warning(NULL,
-                         "green-16010: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16010",
+                         "Invalid item type observed, run fsck ASAP");
         return 0;
 }
 
 static void errcatch_print_vi(struct virtual_item *vi)
 {
-        reiserfs_warning(NULL,
-                         "green-16011: Invalid item type observed, run fsck ASAP");
+        reiserfs_warning(NULL, "green-16011",
+                         "Invalid item type observed, run fsck ASAP");
 }
 
 static struct item_operations errcatch_ops = {