diff options
author | Robert Love <rml@novell.com> | 2005-07-12 17:06:03 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-07-12 23:38:38 -0400 |
commit | 0eeca28300df110bd6ed54b31193c83b87921443 (patch) | |
tree | 7db42d8a18d80eca538f5b7d25e0532b8fa38b85 /fs/read_write.c | |
parent | bd4c625c061c2a38568d0add3478f59172455159 (diff) |
[PATCH] inotify
inotify is intended to correct the deficiencies of dnotify, particularly
its inability to scale and its terrible user interface:
* dnotify requires the opening of one fd per each directory
that you intend to watch. This quickly results in too many
open files and pins removable media, preventing unmount.
* dnotify is directory-based. You only learn about changes to
directories. Sure, a change to a file in a directory affects
the directory, but you are then forced to keep a cache of
stat structures.
* dnotify's interface to user-space is awful. Signals?
inotify provides a more usable, simple, powerful solution to file change
notification:
* inotify's interface is a system call that returns a fd, not SIGIO.
You get a single fd, which is select()-able.
* inotify has an event that says "the filesystem that the item
you were watching is on was unmounted."
* inotify can watch directories or files.
Inotify is currently used by Beagle (a desktop search infrastructure),
Gamin (a FAM replacement), and other projects.
See Documentation/filesystems/inotify.txt.
Signed-off-by: Robert Love <rml@novell.com>
Cc: John McCutchan <ttb@tentacle.dhs.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/read_write.c')
-rw-r--r-- | fs/read_write.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/fs/read_write.c b/fs/read_write.c index 9292f5fa4d62..563abd09b5c8 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
@@ -10,7 +10,7 @@ | |||
10 | #include <linux/file.h> | 10 | #include <linux/file.h> |
11 | #include <linux/uio.h> | 11 | #include <linux/uio.h> |
12 | #include <linux/smp_lock.h> | 12 | #include <linux/smp_lock.h> |
13 | #include <linux/dnotify.h> | 13 | #include <linux/fsnotify.h> |
14 | #include <linux/security.h> | 14 | #include <linux/security.h> |
15 | #include <linux/module.h> | 15 | #include <linux/module.h> |
16 | #include <linux/syscalls.h> | 16 | #include <linux/syscalls.h> |
@@ -252,7 +252,7 @@ ssize_t vfs_read(struct file *file, char __user *buf, size_t count, loff_t *pos) | |||
252 | else | 252 | else |
253 | ret = do_sync_read(file, buf, count, pos); | 253 | ret = do_sync_read(file, buf, count, pos); |
254 | if (ret > 0) { | 254 | if (ret > 0) { |
255 | dnotify_parent(file->f_dentry, DN_ACCESS); | 255 | fsnotify_access(file->f_dentry); |
256 | current->rchar += ret; | 256 | current->rchar += ret; |
257 | } | 257 | } |
258 | current->syscr++; | 258 | current->syscr++; |
@@ -303,7 +303,7 @@ ssize_t vfs_write(struct file *file, const char __user *buf, size_t count, loff_ | |||
303 | else | 303 | else |
304 | ret = do_sync_write(file, buf, count, pos); | 304 | ret = do_sync_write(file, buf, count, pos); |
305 | if (ret > 0) { | 305 | if (ret > 0) { |
306 | dnotify_parent(file->f_dentry, DN_MODIFY); | 306 | fsnotify_modify(file->f_dentry); |
307 | current->wchar += ret; | 307 | current->wchar += ret; |
308 | } | 308 | } |
309 | current->syscw++; | 309 | current->syscw++; |
@@ -539,9 +539,12 @@ static ssize_t do_readv_writev(int type, struct file *file, | |||
539 | out: | 539 | out: |
540 | if (iov != iovstack) | 540 | if (iov != iovstack) |
541 | kfree(iov); | 541 | kfree(iov); |
542 | if ((ret + (type == READ)) > 0) | 542 | if ((ret + (type == READ)) > 0) { |
543 | dnotify_parent(file->f_dentry, | 543 | if (type == READ) |
544 | (type == READ) ? DN_ACCESS : DN_MODIFY); | 544 | fsnotify_access(file->f_dentry); |
545 | else | ||
546 | fsnotify_modify(file->f_dentry); | ||
547 | } | ||
545 | return ret; | 548 | return ret; |
546 | Efault: | 549 | Efault: |
547 | ret = -EFAULT; | 550 | ret = -EFAULT; |