diff options
author | Seiji Aguchi <seiji.aguchi@hds.com> | 2012-11-26 19:07:44 -0500 |
---|---|---|
committer | Tony Luck <tony.luck@intel.com> | 2012-11-26 19:07:44 -0500 |
commit | 755d4fe46529018ae45bc7c86df682de45ace764 (patch) | |
tree | 470788ad3e9fa704ef41fa62ac9e770193010853 /fs/pstore/ram.c | |
parent | a9efd39cd547223597cfe7c53acec44c099b9264 (diff) |
efi_pstore: Add a sequence counter to a variable name
[Issue]
Currently, a variable name, which identifies each entry, consists of type, id and ctime.
But if multiple events happens in a short time, a second/third event may fail to log because
efi_pstore can't distinguish each event with current variable name.
[Solution]
A reasonable way to identify all events precisely is introducing a sequence counter to
the variable name.
The sequence counter has already supported in a pstore layer with "oopscount".
So, this patch adds it to a variable name.
Also, it is passed to read/erase callbacks of platform drivers in accordance with
the modification of the variable name.
<before applying this patch>
a variable name of first event: dump-type0-1-12345678
a variable name of second event: dump-type0-1-12345678
type:0
id:1
ctime:12345678
If multiple events happen in a short time, efi_pstore can't distinguish them because
variable names are same among them.
<after applying this patch>
it can be distinguishable by adding a sequence counter as follows.
a variable name of first event: dump-type0-1-1-12345678
a variable name of Second event: dump-type0-1-2-12345678
type:0
id:1
sequence counter: 1(first event), 2(second event)
ctime:12345678
In case of a write callback executed in pstore_console_write(), "0" is added to
an argument of the write callback because it just logs all kernel messages and
doesn't need to care about multiple events.
Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Mike Waychison <mikew@google.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Diffstat (limited to 'fs/pstore/ram.c')
-rw-r--r-- | fs/pstore/ram.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 749693fcb75a..2bfa36e0ffe8 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c | |||
@@ -132,9 +132,8 @@ ramoops_get_next_prz(struct persistent_ram_zone *przs[], uint *c, uint max, | |||
132 | } | 132 | } |
133 | 133 | ||
134 | static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type, | 134 | static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type, |
135 | struct timespec *time, | 135 | int *count, struct timespec *time, |
136 | char **buf, | 136 | char **buf, struct pstore_info *psi) |
137 | struct pstore_info *psi) | ||
138 | { | 137 | { |
139 | ssize_t size; | 138 | ssize_t size; |
140 | struct ramoops_context *cxt = psi->data; | 139 | struct ramoops_context *cxt = psi->data; |
@@ -236,7 +235,7 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type, | |||
236 | return 0; | 235 | return 0; |
237 | } | 236 | } |
238 | 237 | ||
239 | static int ramoops_pstore_erase(enum pstore_type_id type, u64 id, | 238 | static int ramoops_pstore_erase(enum pstore_type_id type, u64 id, int count, |
240 | struct timespec time, struct pstore_info *psi) | 239 | struct timespec time, struct pstore_info *psi) |
241 | { | 240 | { |
242 | struct ramoops_context *cxt = psi->data; | 241 | struct ramoops_context *cxt = psi->data; |